[INFO] updating cached repository Ross65536/conway-game-of-life-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Ross65536/conway-game-of-life-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Ross65536/conway-game-of-life-rs" "work/ex/clippy-test-run/sources/stable/gh/Ross65536/conway-game-of-life-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ross65536/conway-game-of-life-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Ross65536/conway-game-of-life-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ross65536/conway-game-of-life-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ross65536/conway-game-of-life-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fa63390945615aa4e994f4aa271481692c25af49 [INFO] sha for GitHub repo Ross65536/conway-game-of-life-rs: fa63390945615aa4e994f4aa271481692c25af49 [INFO] validating manifest of Ross65536/conway-game-of-life-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Ross65536/conway-game-of-life-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Ross65536/conway-game-of-life-rs [INFO] finished frobbing Ross65536/conway-game-of-life-rs [INFO] frobbed toml for Ross65536/conway-game-of-life-rs written to work/ex/clippy-test-run/sources/stable/gh/Ross65536/conway-game-of-life-rs/Cargo.toml [INFO] started frobbing Ross65536/conway-game-of-life-rs [INFO] finished frobbing Ross65536/conway-game-of-life-rs [INFO] frobbed toml for Ross65536/conway-game-of-life-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ross65536/conway-game-of-life-rs/Cargo.toml [INFO] crate Ross65536/conway-game-of-life-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Ross65536/conway-game-of-life-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ross65536/conway-game-of-life-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8717d2e1f3d81800d6639b58b04bac555d12c636bf7ad95305620c41701bf8d7 [INFO] running `"docker" "start" "-a" "8717d2e1f3d81800d6639b58b04bac555d12c636bf7ad95305620c41701bf8d7"` [INFO] [stderr] Checking game-of-life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/configuration/mod.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | Configuration { x_size: x_size, y_size: y_size, frametime_ms: frametime, cells: cells } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `x_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/configuration/mod.rs:44:41 [INFO] [stderr] | [INFO] [stderr] 44 | Configuration { x_size: x_size, y_size: y_size, frametime_ms: frametime, cells: cells } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `y_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/configuration/mod.rs:44:82 [INFO] [stderr] | [INFO] [stderr] 44 | Configuration { x_size: x_size, y_size: y_size, frametime_ms: frametime, cells: cells } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/cell.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | Cell { x:x, y:y } [INFO] [stderr] | ^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/cell.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | Cell { x:x, y:y } [INFO] [stderr] | ^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game_state.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | GameState { cells: cells } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game_view.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | GameView { x_size: x_size, y_size: y_size } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `x_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game_view.rs:12:36 [INFO] [stderr] | [INFO] [stderr] 12 | GameView { x_size: x_size, y_size: y_size } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `y_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | game_state: game_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | game_view: game_view, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/configuration/mod.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | Configuration { x_size: x_size, y_size: y_size, frametime_ms: frametime, cells: cells } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `x_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/configuration/mod.rs:44:41 [INFO] [stderr] | [INFO] [stderr] 44 | Configuration { x_size: x_size, y_size: y_size, frametime_ms: frametime, cells: cells } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `y_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/configuration/mod.rs:44:82 [INFO] [stderr] | [INFO] [stderr] 44 | Configuration { x_size: x_size, y_size: y_size, frametime_ms: frametime, cells: cells } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/cell.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | Cell { x:x, y:y } [INFO] [stderr] | ^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/cell.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | Cell { x:x, y:y } [INFO] [stderr] | ^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game_state.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | GameState { cells: cells } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game_view.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | GameView { x_size: x_size, y_size: y_size } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `x_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game_view.rs:12:36 [INFO] [stderr] | [INFO] [stderr] 12 | GameView { x_size: x_size, y_size: y_size } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `y_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | game_state: game_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/game.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | game_view: game_view, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game_view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/configuration/mod.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | const X_SIZE: &'static str = "15"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/configuration/mod.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | const Y_SIZE: &'static str = "10"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/configuration/mod.rs:9:27 [INFO] [stderr] | [INFO] [stderr] 9 | const FRAME_TIME_MILLIS: &'static str = "1000"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/configuration/mod.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | const PATTERN: &'static str = "5,5;6,5;7,5"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/game/game_state.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / if num_neighbours >= 2 && num_neighbours <= 3 { [INFO] [stderr] 36 | | if num_neighbours == 3 || self.cells.contains(&cell) { [INFO] [stderr] 37 | | new_cells.insert(cell); [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | if num_neighbours >= 2 && num_neighbours <= 3 && (num_neighbours == 3 || self.cells.contains(&cell)) { [INFO] [stderr] 36 | new_cells.insert(cell); [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/game/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub mod game; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/display/mod.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | const LIVE_CELL: &'static str = "X"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/display/mod.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | const DEAD_CELL: &'static str = "."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/configuration/mod.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | const X_SIZE: &'static str = "15"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/configuration/mod.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | const Y_SIZE: &'static str = "10"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/configuration/mod.rs:9:27 [INFO] [stderr] | [INFO] [stderr] 9 | const FRAME_TIME_MILLIS: &'static str = "1000"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/configuration/mod.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | const PATTERN: &'static str = "5,5;6,5;7,5"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/game/game_state.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / if num_neighbours >= 2 && num_neighbours <= 3 { [INFO] [stderr] 36 | | if num_neighbours == 3 || self.cells.contains(&cell) { [INFO] [stderr] 37 | | new_cells.insert(cell); [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | if num_neighbours >= 2 && num_neighbours <= 3 && (num_neighbours == 3 || self.cells.contains(&cell)) { [INFO] [stderr] 36 | new_cells.insert(cell); [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/game/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub mod game; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/display/mod.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | const LIVE_CELL: &'static str = "X"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/display/mod.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | const DEAD_CELL: &'static str = "."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/configuration/mod.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | .split(";") [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/configuration/mod.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | let cells = config.get("pattern".into()) [INFO] [stderr] | _____________________^ [INFO] [stderr] 29 | | .unwrap() [INFO] [stderr] | |_____________________^ help: try this: `&config["pattern".into()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/configuration/mod.rs:28:32 [INFO] [stderr] | [INFO] [stderr] 28 | let cells = config.get("pattern".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"pattern"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/configuration/mod.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashMap [INFO] [stderr] --> src/configuration/mod.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | configuration.into_iter().for_each(|(k, v)| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/configuration/mod.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | config.get(arg.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `arg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/game/cell.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | neighbours.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/display/mod.rs:14:28 [INFO] [stderr] | [INFO] [stderr] 14 | if arg.starts_with("-") && arg.len() > 1 { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/display/mod.rs:15:33 [INFO] [stderr] | [INFO] [stderr] 15 | key = arg.splitn(2, "-").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `game-of-life`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/configuration/mod.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | .split(";") [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/configuration/mod.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | let cells = config.get("pattern".into()) [INFO] [stderr] | _____________________^ [INFO] [stderr] 29 | | .unwrap() [INFO] [stderr] | |_____________________^ help: try this: `&config["pattern".into()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/configuration/mod.rs:28:32 [INFO] [stderr] | [INFO] [stderr] 28 | let cells = config.get("pattern".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"pattern"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/configuration/mod.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashMap [INFO] [stderr] --> src/configuration/mod.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | configuration.into_iter().for_each(|(k, v)| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/configuration/mod.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | config.get(arg.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `arg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/game/cell.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | neighbours.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/display/mod.rs:14:28 [INFO] [stderr] | [INFO] [stderr] 14 | if arg.starts_with("-") && arg.len() > 1 { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/display/mod.rs:15:33 [INFO] [stderr] | [INFO] [stderr] 15 | key = arg.splitn(2, "-").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `game-of-life`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8717d2e1f3d81800d6639b58b04bac555d12c636bf7ad95305620c41701bf8d7"` [INFO] running `"docker" "rm" "-f" "8717d2e1f3d81800d6639b58b04bac555d12c636bf7ad95305620c41701bf8d7"` [INFO] [stdout] 8717d2e1f3d81800d6639b58b04bac555d12c636bf7ad95305620c41701bf8d7