[INFO] updating cached repository Rocko10/Rust-CRUD [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Rocko10/Rust-CRUD [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Rocko10/Rust-CRUD" "work/ex/clippy-test-run/sources/stable/gh/Rocko10/Rust-CRUD"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Rocko10/Rust-CRUD'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Rocko10/Rust-CRUD" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Rocko10/Rust-CRUD"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Rocko10/Rust-CRUD'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b0aff19c32548e96fb13f6df88e40157f696b8a6 [INFO] sha for GitHub repo Rocko10/Rust-CRUD: b0aff19c32548e96fb13f6df88e40157f696b8a6 [INFO] validating manifest of Rocko10/Rust-CRUD on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Rocko10/Rust-CRUD on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Rocko10/Rust-CRUD [INFO] finished frobbing Rocko10/Rust-CRUD [INFO] frobbed toml for Rocko10/Rust-CRUD written to work/ex/clippy-test-run/sources/stable/gh/Rocko10/Rust-CRUD/Cargo.toml [INFO] started frobbing Rocko10/Rust-CRUD [INFO] finished frobbing Rocko10/Rust-CRUD [INFO] frobbed toml for Rocko10/Rust-CRUD written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Rocko10/Rust-CRUD/Cargo.toml [INFO] crate Rocko10/Rust-CRUD has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Rocko10/Rust-CRUD against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Rocko10/Rust-CRUD:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 761032966f6d1a5dc51160e3cc72e4a2c45d0744746c6e12b9fbcb0390b7f2b2 [INFO] running `"docker" "start" "-a" "761032966f6d1a5dc51160e3cc72e4a2c45d0744746c6e12b9fbcb0390b7f2b2"` [INFO] [stderr] Checking zoo_crud v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/memory.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ShowImp` [INFO] [stderr] --> src/use_case/show.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub struct ShowImp<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/use_case/show.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(data_provider: &'a dyn Gateway) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DeleteImp` [INFO] [stderr] --> src/use_case/delete.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub struct DeleteImp<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/use_case/delete.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(data_provider: &'a mut dyn Gateway) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/memory.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/gateway.rs:6:44 [INFO] [stderr] | [INFO] [stderr] 6 | fn show(&self, name: String) -> Option<&Box>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&dyn Animal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/use_case/mod.rs:17:47 [INFO] [stderr] | [INFO] [stderr] 17 | fn execute(&self, name: String) -> Option<&Box>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&dyn Animal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/memory.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/gateway.rs:6:44 [INFO] [stderr] | [INFO] [stderr] 6 | fn show(&self, name: String) -> Option<&Box>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&dyn Animal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/use_case/mod.rs:17:47 [INFO] [stderr] | [INFO] [stderr] 17 | fn execute(&self, name: String) -> Option<&Box>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&dyn Animal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "761032966f6d1a5dc51160e3cc72e4a2c45d0744746c6e12b9fbcb0390b7f2b2"` [INFO] running `"docker" "rm" "-f" "761032966f6d1a5dc51160e3cc72e4a2c45d0744746c6e12b9fbcb0390b7f2b2"` [INFO] [stdout] 761032966f6d1a5dc51160e3cc72e4a2c45d0744746c6e12b9fbcb0390b7f2b2