[INFO] updating cached repository RisingStack/node-with-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RisingStack/node-with-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RisingStack/node-with-rust" "work/ex/clippy-test-run/sources/stable/gh/RisingStack/node-with-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RisingStack/node-with-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RisingStack/node-with-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RisingStack/node-with-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RisingStack/node-with-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eefd1397a83b18182a73607ad4dece19cc308d5c [INFO] sha for GitHub repo RisingStack/node-with-rust: eefd1397a83b18182a73607ad4dece19cc308d5c [INFO] validating manifest of RisingStack/node-with-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RisingStack/node-with-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RisingStack/node-with-rust [INFO] finished frobbing RisingStack/node-with-rust [INFO] frobbed toml for RisingStack/node-with-rust written to work/ex/clippy-test-run/sources/stable/gh/RisingStack/node-with-rust/Cargo.toml [INFO] started frobbing RisingStack/node-with-rust [INFO] finished frobbing RisingStack/node-with-rust [INFO] frobbed toml for RisingStack/node-with-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RisingStack/node-with-rust/Cargo.toml [INFO] crate RisingStack/node-with-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RisingStack/node-with-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RisingStack/node-with-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da291992315c50a316f4871126cfdad3b8cddbbedf1305196ea848286bca37ec [INFO] running `"docker" "start" "-a" "da291992315c50a316f4871126cfdad3b8cddbbedf1305196ea848286bca37ec"` [INFO] [stderr] warning: path `/opt/crater/workdir/src/embed.rs` was erroneously implicitly accepted for library `embed`, [INFO] [stderr] please rename the file to `src/lib.rs` or set lib.path in Cargo.toml [INFO] [stderr] Checking hello_node v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/embed.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | return a * b; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `a * b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/embed.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/embed.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return fibonacci(x - 1) + fibonacci(x - 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fibonacci(x - 1) + fibonacci(x - 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/embed.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | return a * b; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `a * b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/embed.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/embed.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return fibonacci(x - 1) + fibonacci(x - 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fibonacci(x - 1) + fibonacci(x - 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.62s [INFO] running `"docker" "inspect" "da291992315c50a316f4871126cfdad3b8cddbbedf1305196ea848286bca37ec"` [INFO] running `"docker" "rm" "-f" "da291992315c50a316f4871126cfdad3b8cddbbedf1305196ea848286bca37ec"` [INFO] [stdout] da291992315c50a316f4871126cfdad3b8cddbbedf1305196ea848286bca37ec