[INFO] updating cached repository Rep2/RS_2_lab [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Rep2/RS_2_lab [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Rep2/RS_2_lab" "work/ex/clippy-test-run/sources/stable/gh/Rep2/RS_2_lab"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Rep2/RS_2_lab'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Rep2/RS_2_lab" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Rep2/RS_2_lab"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Rep2/RS_2_lab'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 04983c92873fb56da2b806ea7bd6b70e11178bc0 [INFO] sha for GitHub repo Rep2/RS_2_lab: 04983c92873fb56da2b806ea7bd6b70e11178bc0 [INFO] validating manifest of Rep2/RS_2_lab on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Rep2/RS_2_lab on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Rep2/RS_2_lab [INFO] finished frobbing Rep2/RS_2_lab [INFO] frobbed toml for Rep2/RS_2_lab written to work/ex/clippy-test-run/sources/stable/gh/Rep2/RS_2_lab/Cargo.toml [INFO] started frobbing Rep2/RS_2_lab [INFO] finished frobbing Rep2/RS_2_lab [INFO] frobbed toml for Rep2/RS_2_lab written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Rep2/RS_2_lab/Cargo.toml [INFO] crate Rep2/RS_2_lab has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Rep2/RS_2_lab against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Rep2/RS_2_lab:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5fa3fc26bc796c92b819782e52f4ee3a74076d6176ba8f03227958ca534b530f [INFO] running `"docker" "start" "-a" "5fa3fc26bc796c92b819782e52f4ee3a74076d6176ba8f03227958ca534b530f"` [INFO] [stderr] Checking rs2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nodes.rs:58:53 [INFO] [stderr] | [INFO] [stderr] 58 | let node = NodeAddress{ ip: String::from(vec[0]), port: port }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nodes.rs:58:53 [INFO] [stderr] | [INFO] [stderr] 58 | let node = NodeAddress{ ip: String::from(vec[0]), port: port }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/nodes.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{self, BufReader}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/nodes.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nodes.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nodes.rs:67:3 [INFO] [stderr] | [INFO] [stderr] 67 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:26:2 [INFO] [stderr] | [INFO] [stderr] 26 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:31:2 [INFO] [stderr] | [INFO] [stderr] 31 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/nodes.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{self, BufReader}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/nodes.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nodes.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nodes.rs:67:3 [INFO] [stderr] | [INFO] [stderr] 67 | return node [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:26:2 [INFO] [stderr] | [INFO] [stderr] 26 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:31:2 [INFO] [stderr] | [INFO] [stderr] 31 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `node` [INFO] [stderr] --> src/main.rs:24:6 [INFO] [stderr] | [INFO] [stderr] 24 | let node = nodes::register_node(); [INFO] [stderr] | ^^^^ help: consider using `_node` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/nodes.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let mut file_in = match OpenOptions::new(). [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `readLine` should have a snake case name such as `read_line` [INFO] [stderr] --> src/nodes.rs:30:6 [INFO] [stderr] | [INFO] [stderr] 30 | let mut readLine = String::new(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `node` [INFO] [stderr] --> src/main.rs:24:6 [INFO] [stderr] | [INFO] [stderr] 24 | let node = nodes::register_node(); [INFO] [stderr] | ^^^^ help: consider using `_node` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/nodes.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | let vec = readLine.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/nodes.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let mut file_in = match OpenOptions::new(). [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `readLine` should have a snake case name such as `read_line` [INFO] [stderr] --> src/nodes.rs:30:6 [INFO] [stderr] | [INFO] [stderr] 30 | let mut readLine = String::new(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/nodes.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | let vec = readLine.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.36s [INFO] running `"docker" "inspect" "5fa3fc26bc796c92b819782e52f4ee3a74076d6176ba8f03227958ca534b530f"` [INFO] running `"docker" "rm" "-f" "5fa3fc26bc796c92b819782e52f4ee3a74076d6176ba8f03227958ca534b530f"` [INFO] [stdout] 5fa3fc26bc796c92b819782e52f4ee3a74076d6176ba8f03227958ca534b530f