[INFO] updating cached repository Reeywhaar/line_by_line [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Reeywhaar/line_by_line [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Reeywhaar/line_by_line" "work/ex/clippy-test-run/sources/stable/gh/Reeywhaar/line_by_line"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Reeywhaar/line_by_line'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Reeywhaar/line_by_line" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Reeywhaar/line_by_line"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Reeywhaar/line_by_line'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 474c04a06e922b47181d6245d8315a6c12f605c2 [INFO] sha for GitHub repo Reeywhaar/line_by_line: 474c04a06e922b47181d6245d8315a6c12f605c2 [INFO] validating manifest of Reeywhaar/line_by_line on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Reeywhaar/line_by_line on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Reeywhaar/line_by_line [INFO] finished frobbing Reeywhaar/line_by_line [INFO] frobbed toml for Reeywhaar/line_by_line written to work/ex/clippy-test-run/sources/stable/gh/Reeywhaar/line_by_line/Cargo.toml [INFO] started frobbing Reeywhaar/line_by_line [INFO] finished frobbing Reeywhaar/line_by_line [INFO] frobbed toml for Reeywhaar/line_by_line written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Reeywhaar/line_by_line/Cargo.toml [INFO] crate Reeywhaar/line_by_line has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Reeywhaar/line_by_line against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Reeywhaar/line_by_line:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d75f0265afc3d1ee1c670da062eb2f2ad66e9ac7ce6d49e29daa515d1824192 [INFO] running `"docker" "start" "-a" "1d75f0265afc3d1ee1c670da062eb2f2ad66e9ac7ce6d49e29daa515d1824192"` [INFO] [stderr] Checking line_by_line v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | if args.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:36:7 [INFO] [stderr] | [INFO] [stderr] 36 | if paths.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:64:35 [INFO] [stderr] | [INFO] [stderr] 64 | .map(|(l, padding)| (l.next(), padding.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*padding` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:66:15 [INFO] [stderr] | [INFO] [stderr] 66 | if (&lines).into_iter().by_ref().all(|(x, _)| x.is_none()) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:88:10 [INFO] [stderr] | [INFO] [stderr] 88 | if let Err(_) = stdo.write(output.as_bytes()) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 89 | | eprintln!("Error while writing file"); [INFO] [stderr] 90 | | exit(1); [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________- help: try this: `if stdo.write(output.as_bytes()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | if let Err(_) = stdo.flush() { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 94 | | eprintln!("Error while writing file"); [INFO] [stderr] 95 | | exit(1); [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____- help: try this: `if stdo.flush().is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | if args.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:36:7 [INFO] [stderr] | [INFO] [stderr] 36 | if paths.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/main.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:64:35 [INFO] [stderr] | [INFO] [stderr] 64 | .map(|(l, padding)| (l.next(), padding.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*padding` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:66:15 [INFO] [stderr] | [INFO] [stderr] 66 | if (&lines).into_iter().by_ref().all(|(x, _)| x.is_none()) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:88:10 [INFO] [stderr] | [INFO] [stderr] 88 | if let Err(_) = stdo.write(output.as_bytes()) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 89 | | eprintln!("Error while writing file"); [INFO] [stderr] 90 | | exit(1); [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________- help: try this: `if stdo.write(output.as_bytes()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | if let Err(_) = stdo.flush() { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 94 | | eprintln!("Error while writing file"); [INFO] [stderr] 95 | | exit(1); [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____- help: try this: `if stdo.flush().is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.47s [INFO] running `"docker" "inspect" "1d75f0265afc3d1ee1c670da062eb2f2ad66e9ac7ce6d49e29daa515d1824192"` [INFO] running `"docker" "rm" "-f" "1d75f0265afc3d1ee1c670da062eb2f2ad66e9ac7ce6d49e29daa515d1824192"` [INFO] [stdout] 1d75f0265afc3d1ee1c670da062eb2f2ad66e9ac7ce6d49e29daa515d1824192