[INFO] updating cached repository RebeccaSyria/mud [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RebeccaSyria/mud [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RebeccaSyria/mud" "work/ex/clippy-test-run/sources/stable/gh/RebeccaSyria/mud"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RebeccaSyria/mud'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RebeccaSyria/mud" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RebeccaSyria/mud"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RebeccaSyria/mud'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b8f2a8d5def731212f3b69b4757de84f288e685a [INFO] sha for GitHub repo RebeccaSyria/mud: b8f2a8d5def731212f3b69b4757de84f288e685a [INFO] validating manifest of RebeccaSyria/mud on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RebeccaSyria/mud on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RebeccaSyria/mud [INFO] finished frobbing RebeccaSyria/mud [INFO] frobbed toml for RebeccaSyria/mud written to work/ex/clippy-test-run/sources/stable/gh/RebeccaSyria/mud/Cargo.toml [INFO] started frobbing RebeccaSyria/mud [INFO] finished frobbing RebeccaSyria/mud [INFO] frobbed toml for RebeccaSyria/mud written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RebeccaSyria/mud/Cargo.toml [INFO] crate RebeccaSyria/mud has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RebeccaSyria/mud against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RebeccaSyria/mud:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b0df10793fff8de2807dd457905af50f83217baa38e36125d8d09b6c15bc080d [INFO] running `"docker" "start" "-a" "b0df10793fff8de2807dd457905af50f83217baa38e36125d8d09b6c15bc080d"` [INFO] [stderr] Checking mud v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/room.rs:11:11 [INFO] [stderr] | [INFO] [stderr] 11 | Room{ room_name: room_name, description: description, room_id: room_id, messages: messages} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `room_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/room.rs:11:33 [INFO] [stderr] | [INFO] [stderr] 11 | Room{ room_name: room_name, description: description, room_id: room_id, messages: messages} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/room.rs:11:59 [INFO] [stderr] | [INFO] [stderr] 11 | Room{ room_name: room_name, description: description, room_id: room_id, messages: messages} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `room_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/room.rs:11:77 [INFO] [stderr] | [INFO] [stderr] 11 | Room{ room_name: room_name, description: description, room_id: room_id, messages: messages} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `messages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/room.rs:11:11 [INFO] [stderr] | [INFO] [stderr] 11 | Room{ room_name: room_name, description: description, room_id: room_id, messages: messages} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `room_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/room.rs:11:33 [INFO] [stderr] | [INFO] [stderr] 11 | Room{ room_name: room_name, description: description, room_id: room_id, messages: messages} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/room.rs:11:59 [INFO] [stderr] | [INFO] [stderr] 11 | Room{ room_name: room_name, description: description, room_id: room_id, messages: messages} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `room_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/room.rs:11:77 [INFO] [stderr] | [INFO] [stderr] 11 | Room{ room_name: room_name, description: description, room_id: room_id, messages: messages} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `messages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/room.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `output` is never read [INFO] [stderr] --> src/main.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | let mut output = ""; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `room_name` [INFO] [stderr] --> src/room.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | room_name: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `room_id` [INFO] [stderr] --> src/room.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | room_id: i32, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `messages` [INFO] [stderr] --> src/room.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | messages: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if let Err(_) = stream.write("Hello from Rust\n".as_bytes()) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 32 | | return; [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____- help: try this: `if stream.write("Hello from Rust\n".as_bytes()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | if let Err(_) = stream.write("\n> ".as_bytes()){ [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 37 | | return; [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________- help: try this: `if stream.write("\n> ".as_bytes()).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | if let Err(_) = stream.write_all(output.as_bytes()){ [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 53 | | break; [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________________- help: try this: `if stream.write_all(output.as_bytes()).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/room.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `output` is never read [INFO] [stderr] --> src/main.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | let mut output = ""; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `room_name` [INFO] [stderr] --> src/room.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | room_name: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `room_id` [INFO] [stderr] --> src/room.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | room_id: i32, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `messages` [INFO] [stderr] --> src/room.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | messages: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if let Err(_) = stream.write("Hello from Rust\n".as_bytes()) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 32 | | return; [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____- help: try this: `if stream.write("Hello from Rust\n".as_bytes()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | if let Err(_) = stream.write("\n> ".as_bytes()){ [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 37 | | return; [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________- help: try this: `if stream.write("\n> ".as_bytes()).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | if let Err(_) = stream.write_all(output.as_bytes()){ [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 53 | | break; [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________________- help: try this: `if stream.write_all(output.as_bytes()).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.32s [INFO] running `"docker" "inspect" "b0df10793fff8de2807dd457905af50f83217baa38e36125d8d09b6c15bc080d"` [INFO] running `"docker" "rm" "-f" "b0df10793fff8de2807dd457905af50f83217baa38e36125d8d09b6c15bc080d"` [INFO] [stdout] b0df10793fff8de2807dd457905af50f83217baa38e36125d8d09b6c15bc080d