[INFO] updating cached repository RealOrangeOne/watts [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RealOrangeOne/watts [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RealOrangeOne/watts" "work/ex/clippy-test-run/sources/stable/gh/RealOrangeOne/watts"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RealOrangeOne/watts'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RealOrangeOne/watts" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RealOrangeOne/watts"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RealOrangeOne/watts'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d4d4da0dd812e2e53cb5ab60a128775cc3fd2f9b [INFO] sha for GitHub repo RealOrangeOne/watts: d4d4da0dd812e2e53cb5ab60a128775cc3fd2f9b [INFO] validating manifest of RealOrangeOne/watts on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RealOrangeOne/watts on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RealOrangeOne/watts [INFO] finished frobbing RealOrangeOne/watts [INFO] frobbed toml for RealOrangeOne/watts written to work/ex/clippy-test-run/sources/stable/gh/RealOrangeOne/watts/Cargo.toml [INFO] started frobbing RealOrangeOne/watts [INFO] finished frobbing RealOrangeOne/watts [INFO] frobbed toml for RealOrangeOne/watts written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RealOrangeOne/watts/Cargo.toml [INFO] crate RealOrangeOne/watts has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RealOrangeOne/watts against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RealOrangeOne/watts:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe1b09db2dec1b0788bac044e6b0f21c33b83676b6911b6a4e6f373e0e01012c [INFO] running `"docker" "start" "-a" "fe1b09db2dec1b0788bac044e6b0f21c33b83676b6911b6a4e6f373e0e01012c"` [INFO] [stderr] Checking watts v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | const DIVISOR: f64 = 1000000000000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / return contents.replace("\n", "").parse::().expect(&format!( [INFO] [stderr] 18 | | "Failed to parse {}", [INFO] [stderr] 19 | | filename [INFO] [stderr] 20 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | contents.replace("\n", "").parse::().expect(&format!( [INFO] [stderr] 18 | "Failed to parse {}", [INFO] [stderr] 19 | filename [INFO] [stderr] 20 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | const DIVISOR: f64 = 1000000000000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / return contents.replace("\n", "").parse::().expect(&format!( [INFO] [stderr] 18 | | "Failed to parse {}", [INFO] [stderr] 19 | | filename [INFO] [stderr] 20 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | contents.replace("\n", "").parse::().expect(&format!( [INFO] [stderr] 18 | "Failed to parse {}", [INFO] [stderr] 19 | filename [INFO] [stderr] 20 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:11:41 [INFO] [stderr] | [INFO] [stderr] 11 | let mut file = File::open(filepath).expect(&format!("Could not find file {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not find file {}", filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:13:40 [INFO] [stderr] | [INFO] [stderr] 13 | file.read_to_string(&mut contents).expect(&format!( [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 14 | | "Failed to read {}", [INFO] [stderr] 15 | | filename [INFO] [stderr] 16 | | )); [INFO] [stderr] | |______^ help: try this: `unwrap_or_else(|_| panic!("Failed to read {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:17:54 [INFO] [stderr] | [INFO] [stderr] 17 | return contents.replace("\n", "").parse::().expect(&format!( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 18 | | "Failed to parse {}", [INFO] [stderr] 19 | | filename [INFO] [stderr] 20 | | )); [INFO] [stderr] | |______^ help: try this: `unwrap_or_else(|_| panic!("Failed to parse {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:11:41 [INFO] [stderr] | [INFO] [stderr] 11 | let mut file = File::open(filepath).expect(&format!("Could not find file {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not find file {}", filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:13:40 [INFO] [stderr] | [INFO] [stderr] 13 | file.read_to_string(&mut contents).expect(&format!( [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 14 | | "Failed to read {}", [INFO] [stderr] 15 | | filename [INFO] [stderr] 16 | | )); [INFO] [stderr] | |______^ help: try this: `unwrap_or_else(|_| panic!("Failed to read {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:17:54 [INFO] [stderr] | [INFO] [stderr] 17 | return contents.replace("\n", "").parse::().expect(&format!( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 18 | | "Failed to parse {}", [INFO] [stderr] 19 | | filename [INFO] [stderr] 20 | | )); [INFO] [stderr] | |______^ help: try this: `unwrap_or_else(|_| panic!("Failed to parse {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.28s [INFO] running `"docker" "inspect" "fe1b09db2dec1b0788bac044e6b0f21c33b83676b6911b6a4e6f373e0e01012c"` [INFO] running `"docker" "rm" "-f" "fe1b09db2dec1b0788bac044e6b0f21c33b83676b6911b6a4e6f373e0e01012c"` [INFO] [stdout] fe1b09db2dec1b0788bac044e6b0f21c33b83676b6911b6a4e6f373e0e01012c