[INFO] updating cached repository RealOrangeOne/tbg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RealOrangeOne/tbg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RealOrangeOne/tbg" "work/ex/clippy-test-run/sources/stable/gh/RealOrangeOne/tbg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RealOrangeOne/tbg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RealOrangeOne/tbg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RealOrangeOne/tbg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RealOrangeOne/tbg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cff042ab1b30f93b0e7cea025931bbdae174bfdf [INFO] sha for GitHub repo RealOrangeOne/tbg: cff042ab1b30f93b0e7cea025931bbdae174bfdf [INFO] validating manifest of RealOrangeOne/tbg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RealOrangeOne/tbg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RealOrangeOne/tbg [INFO] finished frobbing RealOrangeOne/tbg [INFO] frobbed toml for RealOrangeOne/tbg written to work/ex/clippy-test-run/sources/stable/gh/RealOrangeOne/tbg/Cargo.toml [INFO] started frobbing RealOrangeOne/tbg [INFO] finished frobbing RealOrangeOne/tbg [INFO] frobbed toml for RealOrangeOne/tbg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RealOrangeOne/tbg/Cargo.toml [INFO] crate RealOrangeOne/tbg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RealOrangeOne/tbg against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RealOrangeOne/tbg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d721d5556027deeca6ba0e86b2b69bb56b1749654dbba55003b56544166d95e9 [INFO] running `"docker" "start" "-a" "d721d5556027deeca6ba0e86b2b69bb56b1749654dbba55003b56544166d95e9"` [INFO] [stderr] Checking tbg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/files.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / return input_files [INFO] [stderr] 7 | | .map(|d| d.unwrap()) [INFO] [stderr] 8 | | .filter(|d| d.path().is_file()) [INFO] [stderr] 9 | | .map(|d| d.path()) [INFO] [stderr] 10 | | .filter(is_valid_image) [INFO] [stderr] 11 | | .collect(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 6 | input_files [INFO] [stderr] 7 | .map(|d| d.unwrap()) [INFO] [stderr] 8 | .filter(|d| d.path().is_file()) [INFO] [stderr] 9 | .map(|d| d.path()) [INFO] [stderr] 10 | .filter(is_valid_image) [INFO] [stderr] 11 | .collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/image.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / return Command::new("feh") [INFO] [stderr] 14 | | .arg("--list") [INFO] [stderr] 15 | | .arg(img.display().to_string()) [INFO] [stderr] 16 | | .stdout(Stdio::null()) [INFO] [stderr] ... | [INFO] [stderr] 19 | | .status [INFO] [stderr] 20 | | .success(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | Command::new("feh") [INFO] [stderr] 14 | .arg("--list") [INFO] [stderr] 15 | .arg(img.display().to_string()) [INFO] [stderr] 16 | .stdout(Stdio::null()) [INFO] [stderr] 17 | .output() [INFO] [stderr] 18 | .expect("Failed to get output") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/image.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/args.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/args.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/args.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / return App::new(crate_name!()) [INFO] [stderr] 27 | | .about(crate_description!()) [INFO] [stderr] 28 | | .version(crate_version!()) [INFO] [stderr] 29 | | .global_setting(AppSettings::ColoredHelp) [INFO] [stderr] ... | [INFO] [stderr] 33 | | .arg(Arg::with_name("command").takes_value(true).short("c").long("command")) [INFO] [stderr] 34 | | .get_matches(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | App::new(crate_name!()) [INFO] [stderr] 27 | .about(crate_description!()) [INFO] [stderr] 28 | .version(crate_version!()) [INFO] [stderr] 29 | .global_setting(AppSettings::ColoredHelp) [INFO] [stderr] 30 | .global_setting(AppSettings::StrictUtf8) [INFO] [stderr] 31 | .arg(Arg::with_name("directory").required(true).validator(validate_path)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/files.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / return input_files [INFO] [stderr] 7 | | .map(|d| d.unwrap()) [INFO] [stderr] 8 | | .filter(|d| d.path().is_file()) [INFO] [stderr] 9 | | .map(|d| d.path()) [INFO] [stderr] 10 | | .filter(is_valid_image) [INFO] [stderr] 11 | | .collect(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 6 | input_files [INFO] [stderr] 7 | .map(|d| d.unwrap()) [INFO] [stderr] 8 | .filter(|d| d.path().is_file()) [INFO] [stderr] 9 | .map(|d| d.path()) [INFO] [stderr] 10 | .filter(is_valid_image) [INFO] [stderr] 11 | .collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/image.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / return Command::new("feh") [INFO] [stderr] 14 | | .arg("--list") [INFO] [stderr] 15 | | .arg(img.display().to_string()) [INFO] [stderr] 16 | | .stdout(Stdio::null()) [INFO] [stderr] ... | [INFO] [stderr] 19 | | .status [INFO] [stderr] 20 | | .success(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | Command::new("feh") [INFO] [stderr] 14 | .arg("--list") [INFO] [stderr] 15 | .arg(img.display().to_string()) [INFO] [stderr] 16 | .stdout(Stdio::null()) [INFO] [stderr] 17 | .output() [INFO] [stderr] 18 | .expect("Failed to get output") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/image.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/args.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/args.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/args.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / return App::new(crate_name!()) [INFO] [stderr] 27 | | .about(crate_description!()) [INFO] [stderr] 28 | | .version(crate_version!()) [INFO] [stderr] 29 | | .global_setting(AppSettings::ColoredHelp) [INFO] [stderr] ... | [INFO] [stderr] 33 | | .arg(Arg::with_name("command").takes_value(true).short("c").long("command")) [INFO] [stderr] 34 | | .get_matches(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | App::new(crate_name!()) [INFO] [stderr] 27 | .about(crate_description!()) [INFO] [stderr] 28 | .version(crate_version!()) [INFO] [stderr] 29 | .global_setting(AppSettings::ColoredHelp) [INFO] [stderr] 30 | .global_setting(AppSettings::StrictUtf8) [INFO] [stderr] 31 | .arg(Arg::with_name("directory").required(true).validator(validate_path)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.63s [INFO] running `"docker" "inspect" "d721d5556027deeca6ba0e86b2b69bb56b1749654dbba55003b56544166d95e9"` [INFO] running `"docker" "rm" "-f" "d721d5556027deeca6ba0e86b2b69bb56b1749654dbba55003b56544166d95e9"` [INFO] [stdout] d721d5556027deeca6ba0e86b2b69bb56b1749654dbba55003b56544166d95e9