[INFO] updating cached repository Re3ker/rust-todocli-test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Re3ker/rust-todocli-test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Re3ker/rust-todocli-test" "work/ex/clippy-test-run/sources/stable/gh/Re3ker/rust-todocli-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Re3ker/rust-todocli-test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Re3ker/rust-todocli-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Re3ker/rust-todocli-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Re3ker/rust-todocli-test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 56142a16a4112072867c993c6a4988bcbbaddb01 [INFO] sha for GitHub repo Re3ker/rust-todocli-test: 56142a16a4112072867c993c6a4988bcbbaddb01 [INFO] validating manifest of Re3ker/rust-todocli-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Re3ker/rust-todocli-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Re3ker/rust-todocli-test [INFO] finished frobbing Re3ker/rust-todocli-test [INFO] frobbed toml for Re3ker/rust-todocli-test written to work/ex/clippy-test-run/sources/stable/gh/Re3ker/rust-todocli-test/Cargo.toml [INFO] started frobbing Re3ker/rust-todocli-test [INFO] finished frobbing Re3ker/rust-todocli-test [INFO] frobbed toml for Re3ker/rust-todocli-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Re3ker/rust-todocli-test/Cargo.toml [INFO] crate Re3ker/rust-todocli-test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Re3ker/rust-todocli-test against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Re3ker/rust-todocli-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b7e920a1c6785953404899a50baddab6f40bc16f1d17dbcb7b863b7d9e29410b [INFO] running `"docker" "start" "-a" "b7e920a1c6785953404899a50baddab6f40bc16f1d17dbcb7b863b7d9e29410b"` [INFO] [stderr] Checking todocli v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/todo.rs:9:7 [INFO] [stderr] | [INFO] [stderr] 9 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/todo.rs:9:7 [INFO] [stderr] | [INFO] [stderr] 9 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / return TodoItem { [INFO] [stderr] 9 | | name: name, [INFO] [stderr] 10 | | completed: ' ', [INFO] [stderr] 11 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 8 | TodoItem { [INFO] [stderr] 9 | name: name, [INFO] [stderr] 10 | completed: ' ', [INFO] [stderr] 11 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return TodoList { list: Vec::new() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TodoList { list: Vec::new() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / return TodoItem { [INFO] [stderr] 9 | | name: name, [INFO] [stderr] 10 | | completed: ' ', [INFO] [stderr] 11 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 8 | TodoItem { [INFO] [stderr] 9 | name: name, [INFO] [stderr] 10 | completed: ' ', [INFO] [stderr] 11 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return TodoList { list: Vec::new() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TodoList { list: Vec::new() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.31s [INFO] running `"docker" "inspect" "b7e920a1c6785953404899a50baddab6f40bc16f1d17dbcb7b863b7d9e29410b"` [INFO] running `"docker" "rm" "-f" "b7e920a1c6785953404899a50baddab6f40bc16f1d17dbcb7b863b7d9e29410b"` [INFO] [stdout] b7e920a1c6785953404899a50baddab6f40bc16f1d17dbcb7b863b7d9e29410b