[INFO] updating cached repository RaphaelAddile/monkeylang-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RaphaelAddile/monkeylang-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RaphaelAddile/monkeylang-rs" "work/ex/clippy-test-run/sources/stable/gh/RaphaelAddile/monkeylang-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RaphaelAddile/monkeylang-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RaphaelAddile/monkeylang-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RaphaelAddile/monkeylang-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RaphaelAddile/monkeylang-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 838b054cc9842f0df87b50e4f8d1d898d4ba671e [INFO] sha for GitHub repo RaphaelAddile/monkeylang-rs: 838b054cc9842f0df87b50e4f8d1d898d4ba671e [INFO] validating manifest of RaphaelAddile/monkeylang-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RaphaelAddile/monkeylang-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RaphaelAddile/monkeylang-rs [INFO] finished frobbing RaphaelAddile/monkeylang-rs [INFO] frobbed toml for RaphaelAddile/monkeylang-rs written to work/ex/clippy-test-run/sources/stable/gh/RaphaelAddile/monkeylang-rs/Cargo.toml [INFO] started frobbing RaphaelAddile/monkeylang-rs [INFO] finished frobbing RaphaelAddile/monkeylang-rs [INFO] frobbed toml for RaphaelAddile/monkeylang-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RaphaelAddile/monkeylang-rs/Cargo.toml [INFO] crate RaphaelAddile/monkeylang-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RaphaelAddile/monkeylang-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RaphaelAddile/monkeylang-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b4e645f3dd5f9c9ca4deeb91d6fa5fe1c7b2866e2de8149f6d1f1d8c9223cd88 [INFO] running `"docker" "start" "-a" "b4e645f3dd5f9c9ca4deeb91d6fa5fe1c7b2866e2de8149f6d1f1d8c9223cd88"` [INFO] [stderr] Checking monkeylang-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `parser::Parser` [INFO] [stderr] --> src/ast.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use parser::Parser; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/parser.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Discriminant`, `discriminant` [INFO] [stderr] --> src/parser.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | use std::mem::{discriminant, replace, Discriminant}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | return Statement::Expr(expr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Statement::Expr(expr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `parser::Parser` [INFO] [stderr] --> src/ast.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use parser::Parser; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/parser.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Discriminant`, `discriminant` [INFO] [stderr] --> src/parser.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | use std::mem::{discriminant, replace, Discriminant}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | return Statement::Expr(expr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Statement::Expr(expr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Program` [INFO] [stderr] --> src/ast.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub struct Program { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/ast.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn new() -> Program { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Let` [INFO] [stderr] --> src/ast.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | Let(String, Expression), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Return` [INFO] [stderr] --> src/ast.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | Return(Expression), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Expr` [INFO] [stderr] --> src/ast.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | Expr(Expression), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Invalid` [INFO] [stderr] --> src/ast.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | Invalid, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Identifier` [INFO] [stderr] --> src/ast.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | Identifier(String), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `IntegerLiteral` [INFO] [stderr] --> src/ast.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | IntegerLiteral(i64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Not` [INFO] [stderr] --> src/ast.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | Not(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Negative` [INFO] [stderr] --> src/ast.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | Negative(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Add` [INFO] [stderr] --> src/ast.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | Add(Box, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Sub` [INFO] [stderr] --> src/ast.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | Sub(Box, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Mul` [INFO] [stderr] --> src/ast.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | Mul(Box, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Div` [INFO] [stderr] --> src/ast.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | Div(Box, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GreaterThan` [INFO] [stderr] --> src/ast.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | GreaterThan(Box, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LessThan` [INFO] [stderr] --> src/ast.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | LessThan(Box, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Equal` [INFO] [stderr] --> src/ast.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | Equal(Box, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NotEqual` [INFO] [stderr] --> src/ast.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | NotEqual(Box, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Invalid` [INFO] [stderr] --> src/ast.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | Invalid, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Lowest` [INFO] [stderr] --> src/parser.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Lowest, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Equals` [INFO] [stderr] --> src/parser.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Equals, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LessGreater` [INFO] [stderr] --> src/parser.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | LessGreater, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Sum` [INFO] [stderr] --> src/parser.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Sum, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Product` [INFO] [stderr] --> src/parser.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Product, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Prefix` [INFO] [stderr] --> src/parser.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Prefix, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Call` [INFO] [stderr] --> src/parser.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Call, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Parser` [INFO] [stderr] --> src/parser.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub struct Parser { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/parser.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn new(lexer: Lexer) -> Parser { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_identifier` [INFO] [stderr] --> src/parser.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn parse_identifier(&mut self) -> Expression { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `print_errors` [INFO] [stderr] --> src/parser.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn print_errors(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `next_token` [INFO] [stderr] --> src/parser.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn next_token(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_program` [INFO] [stderr] --> src/parser.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn parse_program(&mut self) -> Program { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_statement` [INFO] [stderr] --> src/parser.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn parse_statement(&mut self) -> Statement { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_return_statement` [INFO] [stderr] --> src/parser.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn parse_return_statement(&mut self) -> Statement { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_let_statement` [INFO] [stderr] --> src/parser.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn parse_let_statement(&mut self) -> Statement { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_expression_statement` [INFO] [stderr] --> src/parser.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn parse_expression_statement(&mut self) -> Statement { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_prefix_expression` [INFO] [stderr] --> src/parser.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn parse_prefix_expression(&mut self) -> Expression { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_expression` [INFO] [stderr] --> src/parser.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn parse_expression(&mut self, precedence: Precedence) -> Expression { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_infix_expression` [INFO] [stderr] --> src/parser.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | pub fn parse_infix_expression(&mut self, left: Expression) -> Expression { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_integer_literal` [INFO] [stderr] --> src/parser.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | pub fn parse_integer_literal(&mut self) -> Expression { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_precedence` [INFO] [stderr] --> src/parser.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | pub fn get_precedence(token: &Token) -> Precedence { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `peek_precedence` [INFO] [stderr] --> src/parser.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | pub fn peek_precedence(&self) -> Precedence { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `current_precedence` [INFO] [stderr] --> src/parser.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | pub fn current_precedence(&self) -> Precedence { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `expression` [INFO] [stderr] --> src/parser.rs:289:49 [INFO] [stderr] | [INFO] [stderr] 289 | &Statement::Let(ref identifier, ref expression) => { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_expression` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/parser.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match &self.current { [INFO] [stderr] 43 | | &Token::Identifier(ref name) => Expression::Identifier(name.clone()), [INFO] [stderr] 44 | | _ => Expression::Invalid, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | match self.current { [INFO] [stderr] 43 | Token::Identifier(ref name) => Expression::Identifier(name.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | / match token { [INFO] [stderr] 209 | | &Token::Equal | &Token::NotEqual => Precedence::Equals, [INFO] [stderr] 210 | | &Token::LessThan | &Token::GreaterThan => Precedence::LessGreater, [INFO] [stderr] 211 | | &Token::Plus | &Token::Minus => Precedence::Sum, [INFO] [stderr] 212 | | &Token::Slash | &Token::Asterisk => Precedence::Product, [INFO] [stderr] 213 | | _ => Precedence::Lowest, [INFO] [stderr] 214 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 208 | match *token { [INFO] [stderr] 209 | Token::Equal | Token::NotEqual => Precedence::Equals, [INFO] [stderr] 210 | Token::LessThan | Token::GreaterThan => Precedence::LessGreater, [INFO] [stderr] 211 | Token::Plus | Token::Minus => Precedence::Sum, [INFO] [stderr] 212 | Token::Slash | Token::Asterisk => Precedence::Product, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Call` [INFO] [stderr] --> src/parser.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Call, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/parser.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match &self.current { [INFO] [stderr] 43 | | &Token::Identifier(ref name) => Expression::Identifier(name.clone()), [INFO] [stderr] 44 | | _ => Expression::Invalid, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | match self.current { [INFO] [stderr] 43 | Token::Identifier(ref name) => Expression::Identifier(name.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | / match token { [INFO] [stderr] 209 | | &Token::Equal | &Token::NotEqual => Precedence::Equals, [INFO] [stderr] 210 | | &Token::LessThan | &Token::GreaterThan => Precedence::LessGreater, [INFO] [stderr] 211 | | &Token::Plus | &Token::Minus => Precedence::Sum, [INFO] [stderr] 212 | | &Token::Slash | &Token::Asterisk => Precedence::Product, [INFO] [stderr] 213 | | _ => Precedence::Lowest, [INFO] [stderr] 214 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 208 | match *token { [INFO] [stderr] 209 | Token::Equal | Token::NotEqual => Precedence::Equals, [INFO] [stderr] 210 | Token::LessThan | Token::GreaterThan => Precedence::LessGreater, [INFO] [stderr] 211 | Token::Plus | Token::Minus => Precedence::Sum, [INFO] [stderr] 212 | Token::Slash | Token::Asterisk => Precedence::Product, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | / match statement { [INFO] [stderr] 278 | | &Statement::Return(_) => {} [INFO] [stderr] 279 | | _ => panic!( [INFO] [stderr] 280 | | "Statement isn't a return statement. Received {:?}.", [INFO] [stderr] 281 | | statement [INFO] [stderr] 282 | | ), [INFO] [stderr] 283 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 277 | match *statement { [INFO] [stderr] 278 | Statement::Return(_) => {} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parser.rs:287:71 [INFO] [stderr] | [INFO] [stderr] 287 | fn test_let_statement(statement: &Statement, expected_identifier: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | / match statement { [INFO] [stderr] 289 | | &Statement::Let(ref identifier, ref expression) => { [INFO] [stderr] 290 | | assert_eq!( [INFO] [stderr] 291 | | identifier, [INFO] [stderr] ... | [INFO] [stderr] 298 | | _ => panic!("Expected Let statement, got: {:?}", statement), [INFO] [stderr] 299 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 288 | match *statement { [INFO] [stderr] 289 | Statement::Let(ref identifier, ref expression) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:321:9 [INFO] [stderr] | [INFO] [stderr] 321 | / match stmt { [INFO] [stderr] 322 | | &Statement::Expr(Expression::Identifier(ref name)) => assert_eq!( [INFO] [stderr] 323 | | name, [INFO] [stderr] 324 | | "foobar", [INFO] [stderr] ... | [INFO] [stderr] 330 | | _ => panic!("Statement isn't an expression."), [INFO] [stderr] 331 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 321 | match *stmt { [INFO] [stderr] 322 | Statement::Expr(Expression::Identifier(ref name)) => assert_eq!( [INFO] [stderr] 323 | name, [INFO] [stderr] 324 | "foobar", [INFO] [stderr] 325 | "Identifier name not {}. Got {}.", [INFO] [stderr] 326 | "foobar", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:353:9 [INFO] [stderr] | [INFO] [stderr] 353 | / match stmt { [INFO] [stderr] 354 | | &Statement::Expr(Expression::IntegerLiteral(val)) => { [INFO] [stderr] 355 | | assert_eq!(val, 5, "Literal value not {}. Got {}.", 5, val) [INFO] [stderr] 356 | | } [INFO] [stderr] 357 | | &Statement::Expr(_) => panic!("Not an integer literal expression"), [INFO] [stderr] 358 | | _ => panic!("Statement isn't an expression."), [INFO] [stderr] 359 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 353 | match *stmt { [INFO] [stderr] 354 | Statement::Expr(Expression::IntegerLiteral(val)) => { [INFO] [stderr] 355 | assert_eq!(val, 5, "Literal value not {}. Got {}.", 5, val) [INFO] [stderr] 356 | } [INFO] [stderr] 357 | Statement::Expr(_) => panic!("Not an integer literal expression"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:390:13 [INFO] [stderr] | [INFO] [stderr] 390 | / match stmt { [INFO] [stderr] 391 | | &Statement::Expr(ref e) => assert_eq!(e, expected), [INFO] [stderr] 392 | | _ => panic!("Statement isn't an expression."), [INFO] [stderr] 393 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 390 | match *stmt { [INFO] [stderr] 391 | Statement::Expr(ref e) => assert_eq!(e, expected), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:473:13 [INFO] [stderr] | [INFO] [stderr] 473 | / match stmt { [INFO] [stderr] 474 | | &Statement::Expr(ref e) => assert_eq!(e, expected), [INFO] [stderr] 475 | | _ => panic!("Statement isn't an expression."), [INFO] [stderr] 476 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 473 | match *stmt { [INFO] [stderr] 474 | Statement::Expr(ref e) => assert_eq!(e, expected), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.07s [INFO] running `"docker" "inspect" "b4e645f3dd5f9c9ca4deeb91d6fa5fe1c7b2866e2de8149f6d1f1d8c9223cd88"` [INFO] running `"docker" "rm" "-f" "b4e645f3dd5f9c9ca4deeb91d6fa5fe1c7b2866e2de8149f6d1f1d8c9223cd88"` [INFO] [stdout] b4e645f3dd5f9c9ca4deeb91d6fa5fe1c7b2866e2de8149f6d1f1d8c9223cd88