[INFO] updating cached repository Ramzec/union-find [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Ramzec/union-find [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Ramzec/union-find" "work/ex/clippy-test-run/sources/stable/gh/Ramzec/union-find"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ramzec/union-find'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Ramzec/union-find" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ramzec/union-find"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ramzec/union-find'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1f1587062f90cf1c634c312f4073099babd30dd0 [INFO] sha for GitHub repo Ramzec/union-find: 1f1587062f90cf1c634c312f4073099babd30dd0 [INFO] validating manifest of Ramzec/union-find on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Ramzec/union-find on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Ramzec/union-find [INFO] finished frobbing Ramzec/union-find [INFO] frobbed toml for Ramzec/union-find written to work/ex/clippy-test-run/sources/stable/gh/Ramzec/union-find/Cargo.toml [INFO] started frobbing Ramzec/union-find [INFO] finished frobbing Ramzec/union-find [INFO] frobbed toml for Ramzec/union-find written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ramzec/union-find/Cargo.toml [INFO] crate Ramzec/union-find has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Ramzec/union-find against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ramzec/union-find:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cd1a256dcecfb7983ea3c76d7a21b2e7a74f353c6368d3fcf2b4d76acb1ac532 [INFO] running `"docker" "start" "-a" "cd1a256dcecfb7983ea3c76d7a21b2e7a74f353c6368d3fcf2b4d76acb1ac532"` [INFO] [stderr] Checking union-find v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/union_find.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/union_find.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | weights: weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/union_find.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | stype: stype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/union_find.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/union_find.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | weights: weights, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/union_find.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | stype: stype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/union_find.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/union_find.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/union_find.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | cnt = cnt + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `cnt += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/union_find.rs:146:25 [INFO] [stderr] | [INFO] [stderr] 146 | fn root(&self, idx: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/union_find.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | cnt = cnt + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `cnt += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/union_find.rs:146:25 [INFO] [stderr] | [INFO] [stderr] 146 | fn root(&self, idx: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "cd1a256dcecfb7983ea3c76d7a21b2e7a74f353c6368d3fcf2b4d76acb1ac532"` [INFO] running `"docker" "rm" "-f" "cd1a256dcecfb7983ea3c76d7a21b2e7a74f353c6368d3fcf2b4d76acb1ac532"` [INFO] [stdout] cd1a256dcecfb7983ea3c76d7a21b2e7a74f353c6368d3fcf2b4d76acb1ac532