[INFO] updating cached repository RDDDIB/relations [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RDDDIB/relations [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RDDDIB/relations" "work/ex/clippy-test-run/sources/stable/gh/RDDDIB/relations"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RDDDIB/relations'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RDDDIB/relations" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RDDDIB/relations"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RDDDIB/relations'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 867854ae80991cf19867d6664e13a42aa228a30d [INFO] sha for GitHub repo RDDDIB/relations: 867854ae80991cf19867d6664e13a42aa228a30d [INFO] validating manifest of RDDDIB/relations on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RDDDIB/relations on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RDDDIB/relations [INFO] finished frobbing RDDDIB/relations [INFO] frobbed toml for RDDDIB/relations written to work/ex/clippy-test-run/sources/stable/gh/RDDDIB/relations/Cargo.toml [INFO] started frobbing RDDDIB/relations [INFO] finished frobbing RDDDIB/relations [INFO] frobbed toml for RDDDIB/relations written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RDDDIB/relations/Cargo.toml [INFO] crate RDDDIB/relations has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RDDDIB/relations against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RDDDIB/relations:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5f9fe7058986e9d4d2bc788cd114a1737d8d39b9cf2d53e7f440cb037c1e509d [INFO] running `"docker" "start" "-a" "5f9fe7058986e9d4d2bc788cd114a1737d8d39b9cf2d53e7f440cb037c1e509d"` [INFO] [stderr] Checking relations v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:276:17 [INFO] [stderr] | [INFO] [stderr] 276 | / if self.has(&(item1.clone(), item2.clone())) { [INFO] [stderr] 277 | | if !test.clone().any(|x| { [INFO] [stderr] 278 | | self.has(&(item1.clone(), x.clone())) && [INFO] [stderr] 279 | | self.has(&(x.clone(), item2.clone())) [INFO] [stderr] ... | [INFO] [stderr] 282 | | } [INFO] [stderr] 283 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 276 | if self.has(&(item1.clone(), item2.clone())) && !test.clone().any(|x| { [INFO] [stderr] 277 | self.has(&(item1.clone(), x.clone())) && [INFO] [stderr] 278 | self.has(&(x.clone(), item2.clone())) [INFO] [stderr] 279 | }) { [INFO] [stderr] 280 | return false; [INFO] [stderr] 281 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:276:17 [INFO] [stderr] | [INFO] [stderr] 276 | / if self.has(&(item1.clone(), item2.clone())) { [INFO] [stderr] 277 | | if !test.clone().any(|x| { [INFO] [stderr] 278 | | self.has(&(item1.clone(), x.clone())) && [INFO] [stderr] 279 | | self.has(&(x.clone(), item2.clone())) [INFO] [stderr] ... | [INFO] [stderr] 282 | | } [INFO] [stderr] 283 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 276 | if self.has(&(item1.clone(), item2.clone())) && !test.clone().any(|x| { [INFO] [stderr] 277 | self.has(&(item1.clone(), x.clone())) && [INFO] [stderr] 278 | self.has(&(x.clone(), item2.clone())) [INFO] [stderr] 279 | }) { [INFO] [stderr] 280 | return false; [INFO] [stderr] 281 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | let ref a = *self.items; [INFO] [stderr] | ----^^^^^--------------- help: try: `let a = &(*self.items);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: item `Set` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / impl Set { [INFO] [stderr] 25 | | /// Creates a new `Set` with a given `Vec` of objects. [INFO] [stderr] 26 | | pub fn new(items: &Vec) -> Set { [INFO] [stderr] 27 | | Set { items: items.clone() } [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new(items: &Vec) -> Set { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new(items: &[T]) -> Set { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `items.clone()` to [INFO] [stderr] | [INFO] [stderr] 27 | Set { items: items.to_owned() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:84:15 [INFO] [stderr] | [INFO] [stderr] 84 | Set::new(&this.items [INFO] [stderr] | _______________^ [INFO] [stderr] 85 | | .iter() [INFO] [stderr] 86 | | .filter(|x| that.has(&x)) [INFO] [stderr] 87 | | .map(|x| x.clone()) [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 84 | Set::new(&this.items [INFO] [stderr] 85 | .iter() [INFO] [stderr] 86 | .filter(|x| that.has(&x)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:105:15 [INFO] [stderr] | [INFO] [stderr] 105 | Set::new(&this.items [INFO] [stderr] | _______________^ [INFO] [stderr] 106 | | .iter() [INFO] [stderr] 107 | | .filter(|x| !that.has(&x)) [INFO] [stderr] 108 | | .map(|x| x.clone()) [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 105 | Set::new(&this.items [INFO] [stderr] 106 | .iter() [INFO] [stderr] 107 | .filter(|x| !that.has(&x)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | let ref a = *self.links; [INFO] [stderr] | ----^^^^^--------------- help: try: `let a = &(*self.links);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:137:37 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn new(set: &Set, links: &Vec<(T, T)>) -> Relation { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 137 | pub fn new(set: &Set, links: &[(T, T)]) -> Relation { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: change `links.clone()` to [INFO] [stderr] | [INFO] [stderr] 140 | links: links.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:277:46 [INFO] [stderr] | [INFO] [stderr] 277 | if !test.clone().any(|x| { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 278 | | self.has(&(item1.clone(), x.clone())) && [INFO] [stderr] 279 | | self.has(&(x.clone(), item2.clone())) [INFO] [stderr] 280 | | }) { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:396:6 [INFO] [stderr] | [INFO] [stderr] 396 | &this.links [INFO] [stderr] | ______^ [INFO] [stderr] 397 | | .iter() [INFO] [stderr] 398 | | .filter(|x| that.has(&x)) [INFO] [stderr] 399 | | .map(|x| x.clone()) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 396 | &this.links [INFO] [stderr] 397 | .iter() [INFO] [stderr] 398 | .filter(|x| that.has(&x)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:417:6 [INFO] [stderr] | [INFO] [stderr] 417 | &this.links [INFO] [stderr] | ______^ [INFO] [stderr] 418 | | .iter() [INFO] [stderr] 419 | | .filter(|x| !that.has(&x)) [INFO] [stderr] 420 | | .map(|x| x.clone()) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 417 | &this.links [INFO] [stderr] 418 | .iter() [INFO] [stderr] 419 | .filter(|x| !that.has(&x)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | let ref a = *self.items; [INFO] [stderr] | ----^^^^^--------------- help: try: `let a = &(*self.items);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: item `Set` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / impl Set { [INFO] [stderr] 25 | | /// Creates a new `Set` with a given `Vec` of objects. [INFO] [stderr] 26 | | pub fn new(items: &Vec) -> Set { [INFO] [stderr] 27 | | Set { items: items.clone() } [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new(items: &Vec) -> Set { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new(items: &[T]) -> Set { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `items.clone()` to [INFO] [stderr] | [INFO] [stderr] 27 | Set { items: items.to_owned() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:84:15 [INFO] [stderr] | [INFO] [stderr] 84 | Set::new(&this.items [INFO] [stderr] | _______________^ [INFO] [stderr] 85 | | .iter() [INFO] [stderr] 86 | | .filter(|x| that.has(&x)) [INFO] [stderr] 87 | | .map(|x| x.clone()) [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 84 | Set::new(&this.items [INFO] [stderr] 85 | .iter() [INFO] [stderr] 86 | .filter(|x| that.has(&x)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:105:15 [INFO] [stderr] | [INFO] [stderr] 105 | Set::new(&this.items [INFO] [stderr] | _______________^ [INFO] [stderr] 106 | | .iter() [INFO] [stderr] 107 | | .filter(|x| !that.has(&x)) [INFO] [stderr] 108 | | .map(|x| x.clone()) [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 105 | Set::new(&this.items [INFO] [stderr] 106 | .iter() [INFO] [stderr] 107 | .filter(|x| !that.has(&x)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | let ref a = *self.links; [INFO] [stderr] | ----^^^^^--------------- help: try: `let a = &(*self.links);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:137:37 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn new(set: &Set, links: &Vec<(T, T)>) -> Relation { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 137 | pub fn new(set: &Set, links: &[(T, T)]) -> Relation { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: change `links.clone()` to [INFO] [stderr] | [INFO] [stderr] 140 | links: links.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:277:46 [INFO] [stderr] | [INFO] [stderr] 277 | if !test.clone().any(|x| { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 278 | | self.has(&(item1.clone(), x.clone())) && [INFO] [stderr] 279 | | self.has(&(x.clone(), item2.clone())) [INFO] [stderr] 280 | | }) { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:396:6 [INFO] [stderr] | [INFO] [stderr] 396 | &this.links [INFO] [stderr] | ______^ [INFO] [stderr] 397 | | .iter() [INFO] [stderr] 398 | | .filter(|x| that.has(&x)) [INFO] [stderr] 399 | | .map(|x| x.clone()) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 396 | &this.links [INFO] [stderr] 397 | .iter() [INFO] [stderr] 398 | .filter(|x| that.has(&x)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:417:6 [INFO] [stderr] | [INFO] [stderr] 417 | &this.links [INFO] [stderr] | ______^ [INFO] [stderr] 418 | | .iter() [INFO] [stderr] 419 | | .filter(|x| !that.has(&x)) [INFO] [stderr] 420 | | .map(|x| x.clone()) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 417 | &this.links [INFO] [stderr] 418 | .iter() [INFO] [stderr] 419 | .filter(|x| !that.has(&x)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "5f9fe7058986e9d4d2bc788cd114a1737d8d39b9cf2d53e7f440cb037c1e509d"` [INFO] running `"docker" "rm" "-f" "5f9fe7058986e9d4d2bc788cd114a1737d8d39b9cf2d53e7f440cb037c1e509d"` [INFO] [stdout] 5f9fe7058986e9d4d2bc788cd114a1737d8d39b9cf2d53e7f440cb037c1e509d