[INFO] updating cached repository QusaiHroub/-Simple_Calc
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/QusaiHroub/-Simple_Calc
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/QusaiHroub/-Simple_Calc" "work/ex/clippy-test-run/sources/stable/gh/QusaiHroub/-Simple_Calc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/QusaiHroub/-Simple_Calc'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/QusaiHroub/-Simple_Calc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/QusaiHroub/-Simple_Calc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/QusaiHroub/-Simple_Calc'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c5dbe46260f0e90fbf716a85df70e99e67916dd4
[INFO] sha for GitHub repo QusaiHroub/-Simple_Calc: c5dbe46260f0e90fbf716a85df70e99e67916dd4
[INFO] validating manifest of QusaiHroub/-Simple_Calc on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of QusaiHroub/-Simple_Calc on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing QusaiHroub/-Simple_Calc
[INFO] finished frobbing QusaiHroub/-Simple_Calc
[INFO] frobbed toml for QusaiHroub/-Simple_Calc written to work/ex/clippy-test-run/sources/stable/gh/QusaiHroub/-Simple_Calc/Cargo.toml
[INFO] started frobbing QusaiHroub/-Simple_Calc
[INFO] finished frobbing QusaiHroub/-Simple_Calc
[INFO] frobbed toml for QusaiHroub/-Simple_Calc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/QusaiHroub/-Simple_Calc/Cargo.toml
[INFO] crate QusaiHroub/-Simple_Calc has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting QusaiHroub/-Simple_Calc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/QusaiHroub/-Simple_Calc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1d4f2662b638925818404881e195b851beaa61617e80bce11a7d0fb9e55c9e63
[INFO] running `"docker" "start" "-a" "1d4f2662b638925818404881e195b851beaa61617e80bce11a7d0fb9e55c9e63"`
[INFO] [stderr]     Checking rscalc v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/calc.rs:34:3
[INFO] [stderr]    |
[INFO] [stderr] 34 |         return false;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/calc.rs:83:3
[INFO] [stderr]    |
[INFO] [stderr] 83 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:24:3
[INFO] [stderr]    |
[INFO] [stderr] 24 |           if Calc::analysis(m_str, &mut num , &mut opr) {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 25 | |             if Calc::get_result(num , opr , &mut result) {
[INFO] [stderr] 26 | |                 println!("\n\tresult = {}\n" , result );
[INFO] [stderr] 27 | |             }
[INFO] [stderr] 28 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 24 |         if Calc::analysis(m_str, &mut num , &mut opr) && Calc::get_result(num , opr , &mut result) {
[INFO] [stderr] 25 |     println!("\n\tresult = {}\n" , result );
[INFO] [stderr] 26 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/calc.rs:34:3
[INFO] [stderr]    |
[INFO] [stderr] 34 |         return false;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/calc.rs:83:3
[INFO] [stderr]    |
[INFO] [stderr] 83 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:24:3
[INFO] [stderr]    |
[INFO] [stderr] 24 |           if Calc::analysis(m_str, &mut num , &mut opr) {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 25 | |             if Calc::get_result(num , opr , &mut result) {
[INFO] [stderr] 26 | |                 println!("\n\tresult = {}\n" , result );
[INFO] [stderr] 27 | |             }
[INFO] [stderr] 28 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 24 |         if Calc::analysis(m_str, &mut num , &mut opr) && Calc::get_result(num , opr , &mut result) {
[INFO] [stderr] 25 |     println!("\n\tresult = {}\n" , result );
[INFO] [stderr] 26 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/calc.rs:10:8
[INFO] [stderr]    |
[INFO] [stderr] 10 |                 if _str.len() == 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `_str.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/calc.rs:18:8
[INFO] [stderr]    |
[INFO] [stderr] 18 |                 if _str.len() == 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `_str.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/calc.rs:10:8
[INFO] [stderr]    |
[INFO] [stderr] 10 |                 if _str.len() == 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `_str.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/calc.rs:18:8
[INFO] [stderr]    |
[INFO] [stderr] 18 |                 if _str.len() == 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `_str.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.62s
[INFO] running `"docker" "inspect" "1d4f2662b638925818404881e195b851beaa61617e80bce11a7d0fb9e55c9e63"`
[INFO] running `"docker" "rm" "-f" "1d4f2662b638925818404881e195b851beaa61617e80bce11a7d0fb9e55c9e63"`
[INFO] [stdout] 1d4f2662b638925818404881e195b851beaa61617e80bce11a7d0fb9e55c9e63