[INFO] updating cached repository PurpleMyst/bleso-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/PurpleMyst/bleso-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/PurpleMyst/bleso-rs" "work/ex/clippy-test-run/sources/stable/gh/PurpleMyst/bleso-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PurpleMyst/bleso-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/PurpleMyst/bleso-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PurpleMyst/bleso-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PurpleMyst/bleso-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 62aaf9c439aeb6e33f316dffd11f90be5e61a0b8
[INFO] sha for GitHub repo PurpleMyst/bleso-rs: 62aaf9c439aeb6e33f316dffd11f90be5e61a0b8
[INFO] validating manifest of PurpleMyst/bleso-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of PurpleMyst/bleso-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing PurpleMyst/bleso-rs
[INFO] finished frobbing PurpleMyst/bleso-rs
[INFO] frobbed toml for PurpleMyst/bleso-rs written to work/ex/clippy-test-run/sources/stable/gh/PurpleMyst/bleso-rs/Cargo.toml
[INFO] started frobbing PurpleMyst/bleso-rs
[INFO] finished frobbing PurpleMyst/bleso-rs
[INFO] frobbed toml for PurpleMyst/bleso-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PurpleMyst/bleso-rs/Cargo.toml
[INFO] crate PurpleMyst/bleso-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting PurpleMyst/bleso-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PurpleMyst/bleso-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 124ec40aec7099c7e35def42af5c4f6bc8e88976ad9d9ee4c4ea380368c6145a
[INFO] running `"docker" "start" "-a" "124ec40aec7099c7e35def42af5c4f6bc8e88976ad9d9ee4c4ea380368c6145a"`
[INFO] [stderr]     Checking bleso v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `std::rc::Rc`
[INFO] [stderr]  --> src/main.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::rc::Rc;
[INFO] [stderr]   |     ^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `values::Value`
[INFO] [stderr]  --> src/main.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use values::Value;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::rc::Rc`
[INFO] [stderr]  --> src/main.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::rc::Rc;
[INFO] [stderr]   |     ^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `values::Value`
[INFO] [stderr]  --> src/main.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use values::Value;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/values.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 | /         match self {
[INFO] [stderr] 33 | |             &Value::Cons(None) => panic!("Can't get the car of an empty cons"),
[INFO] [stderr] 34 | |             &Value::Cons(Some((ref car, _))) => Rc::clone(car),
[INFO] [stderr] 35 | |             _ => panic!("Can't get the car of a non-cons value"),
[INFO] [stderr] 36 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 32 |         match *self {
[INFO] [stderr] 33 |             Value::Cons(None) => panic!("Can't get the car of an empty cons"),
[INFO] [stderr] 34 |             Value::Cons(Some((ref car, _))) => Rc::clone(car),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/values.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 | /         match self {
[INFO] [stderr] 41 | |             &Value::Cons(Some((_, Some(ref cdr)))) => Rc::clone(cdr),
[INFO] [stderr] 42 | |             &Value::Cons(_) => panic!("Can't get the cdr of a cons that doesn't have one!"),
[INFO] [stderr] 43 | |             _ => panic!("Can't get the car of a non-cons value"),
[INFO] [stderr] 44 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 40 |         match *self {
[INFO] [stderr] 41 |             Value::Cons(Some((_, Some(ref cdr)))) => Rc::clone(cdr),
[INFO] [stderr] 42 |             Value::Cons(_) => panic!("Can't get the cdr of a cons that doesn't have one!"),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/values.rs:81:9
[INFO] [stderr]    |
[INFO] [stderr] 81 | /         match self {
[INFO] [stderr] 82 | |             &Value::Integer(ref n) => write!(f, "{}", n),
[INFO] [stderr] 83 | |
[INFO] [stderr] 84 | |             &Value::Symbol(ref s) => write!(f, "{}", s),
[INFO] [stderr] ...  |
[INFO] [stderr] 96 | |             &Value::Cons(None) => write!(f, "()"),
[INFO] [stderr] 97 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 81 |         match *self {
[INFO] [stderr] 82 |             Value::Integer(ref n) => write!(f, "{}", n),
[INFO] [stderr] 83 | 
[INFO] [stderr] 84 |             Value::Symbol(ref s) => write!(f, "{}", s),
[INFO] [stderr] 85 | 
[INFO] [stderr] 86 |             Value::Cons(Some((ref car, ref cdr))) => {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/values.rs:89:17
[INFO] [stderr]    |
[INFO] [stderr] 89 | /                 if let &Some(ref cdr) = cdr {
[INFO] [stderr] 90 | |                     write!(f, " {}", cdr)?;
[INFO] [stderr] 91 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 89 |                 if let Some(ref cdr) = *cdr {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/parser.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     loop {
[INFO] [stderr] 20 | |         let c = match chars.next() {
[INFO] [stderr] 21 | |             Some(c) => c,
[INFO] [stderr] 22 | |             None => break,
[INFO] [stderr] ...  |
[INFO] [stderr] 39 | |         }
[INFO] [stderr] 40 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(c) = chars.next() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/values.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 | /         match self {
[INFO] [stderr] 33 | |             &Value::Cons(None) => panic!("Can't get the car of an empty cons"),
[INFO] [stderr] 34 | |             &Value::Cons(Some((ref car, _))) => Rc::clone(car),
[INFO] [stderr] 35 | |             _ => panic!("Can't get the car of a non-cons value"),
[INFO] [stderr] 36 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 32 |         match *self {
[INFO] [stderr] 33 |             Value::Cons(None) => panic!("Can't get the car of an empty cons"),
[INFO] [stderr] 34 |             Value::Cons(Some((ref car, _))) => Rc::clone(car),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/values.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 | /         match self {
[INFO] [stderr] 41 | |             &Value::Cons(Some((_, Some(ref cdr)))) => Rc::clone(cdr),
[INFO] [stderr] 42 | |             &Value::Cons(_) => panic!("Can't get the cdr of a cons that doesn't have one!"),
[INFO] [stderr] 43 | |             _ => panic!("Can't get the car of a non-cons value"),
[INFO] [stderr] 44 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 40 |         match *self {
[INFO] [stderr] 41 |             Value::Cons(Some((_, Some(ref cdr)))) => Rc::clone(cdr),
[INFO] [stderr] 42 |             Value::Cons(_) => panic!("Can't get the cdr of a cons that doesn't have one!"),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/values.rs:81:9
[INFO] [stderr]    |
[INFO] [stderr] 81 | /         match self {
[INFO] [stderr] 82 | |             &Value::Integer(ref n) => write!(f, "{}", n),
[INFO] [stderr] 83 | |
[INFO] [stderr] 84 | |             &Value::Symbol(ref s) => write!(f, "{}", s),
[INFO] [stderr] ...  |
[INFO] [stderr] 96 | |             &Value::Cons(None) => write!(f, "()"),
[INFO] [stderr] 97 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 81 |         match *self {
[INFO] [stderr] 82 |             Value::Integer(ref n) => write!(f, "{}", n),
[INFO] [stderr] 83 | 
[INFO] [stderr] 84 |             Value::Symbol(ref s) => write!(f, "{}", s),
[INFO] [stderr] 85 | 
[INFO] [stderr] 86 |             Value::Cons(Some((ref car, ref cdr))) => {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/values.rs:89:17
[INFO] [stderr]    |
[INFO] [stderr] 89 | /                 if let &Some(ref cdr) = cdr {
[INFO] [stderr] 90 | |                     write!(f, " {}", cdr)?;
[INFO] [stderr] 91 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 89 |                 if let Some(ref cdr) = *cdr {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/parser.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     loop {
[INFO] [stderr] 20 | |         let c = match chars.next() {
[INFO] [stderr] 21 | |             Some(c) => c,
[INFO] [stderr] 22 | |             None => break,
[INFO] [stderr] ...  |
[INFO] [stderr] 39 | |         }
[INFO] [stderr] 40 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(c) = chars.next() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.55s
[INFO] running `"docker" "inspect" "124ec40aec7099c7e35def42af5c4f6bc8e88976ad9d9ee4c4ea380368c6145a"`
[INFO] running `"docker" "rm" "-f" "124ec40aec7099c7e35def42af5c4f6bc8e88976ad9d9ee4c4ea380368c6145a"`
[INFO] [stdout] 124ec40aec7099c7e35def42af5c4f6bc8e88976ad9d9ee4c4ea380368c6145a