[INFO] updating cached repository PurpleMyst/avocado [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PurpleMyst/avocado [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PurpleMyst/avocado" "work/ex/clippy-test-run/sources/stable/gh/PurpleMyst/avocado"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PurpleMyst/avocado'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PurpleMyst/avocado" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PurpleMyst/avocado"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PurpleMyst/avocado'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c3c139cd5662c3fa9981141b938f5fe515fc2b39 [INFO] sha for GitHub repo PurpleMyst/avocado: c3c139cd5662c3fa9981141b938f5fe515fc2b39 [INFO] validating manifest of PurpleMyst/avocado on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PurpleMyst/avocado on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PurpleMyst/avocado [INFO] finished frobbing PurpleMyst/avocado [INFO] frobbed toml for PurpleMyst/avocado written to work/ex/clippy-test-run/sources/stable/gh/PurpleMyst/avocado/Cargo.toml [INFO] started frobbing PurpleMyst/avocado [INFO] finished frobbing PurpleMyst/avocado [INFO] frobbed toml for PurpleMyst/avocado written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PurpleMyst/avocado/Cargo.toml [INFO] crate PurpleMyst/avocado has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PurpleMyst/avocado against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PurpleMyst/avocado:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c734794f648025b4d322f23316fce469dc003468cced7f4501c7fe0df43b9971 [INFO] running `"docker" "start" "-a" "c734794f648025b4d322f23316fce469dc003468cced7f4501c7fe0df43b9971"` [INFO] [stderr] Checking avocado v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / loop { [INFO] [stderr] 71 | | match self.code_chars.peek() { [INFO] [stderr] 72 | | Some(c) => { [INFO] [stderr] 73 | | buf.push(*c); [INFO] [stderr] ... | [INFO] [stderr] 84 | | self.code_chars.next().unwrap(); [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c) = self.code_chars.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | / loop { [INFO] [stderr] 129 | | match self.expression() { [INFO] [stderr] 130 | | Some(arg) => args.push(arg), [INFO] [stderr] 131 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 138 | | self.skip_whitespace(); [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________________________^ help: try: `while let Some(arg) = self.expression() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / loop { [INFO] [stderr] 71 | | match self.code_chars.peek() { [INFO] [stderr] 72 | | Some(c) => { [INFO] [stderr] 73 | | buf.push(*c); [INFO] [stderr] ... | [INFO] [stderr] 84 | | self.code_chars.next().unwrap(); [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c) = self.code_chars.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | / loop { [INFO] [stderr] 129 | | match self.expression() { [INFO] [stderr] 130 | | Some(arg) => args.push(arg), [INFO] [stderr] 131 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 138 | | self.skip_whitespace(); [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________________________^ help: try: `while let Some(arg) = self.expression() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `"docker" "inspect" "c734794f648025b4d322f23316fce469dc003468cced7f4501c7fe0df43b9971"` [INFO] running `"docker" "rm" "-f" "c734794f648025b4d322f23316fce469dc003468cced7f4501c7fe0df43b9971"` [INFO] [stdout] c734794f648025b4d322f23316fce469dc003468cced7f4501c7fe0df43b9971