[INFO] updating cached repository PureW/tokio-key-value-store
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/PureW/tokio-key-value-store
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/PureW/tokio-key-value-store" "work/ex/clippy-test-run/sources/stable/gh/PureW/tokio-key-value-store"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PureW/tokio-key-value-store'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/PureW/tokio-key-value-store" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PureW/tokio-key-value-store"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PureW/tokio-key-value-store'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c9e61a8c50b6774f4c293f506035ef5026d56763
[INFO] sha for GitHub repo PureW/tokio-key-value-store: c9e61a8c50b6774f4c293f506035ef5026d56763
[INFO] validating manifest of PureW/tokio-key-value-store on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of PureW/tokio-key-value-store on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing PureW/tokio-key-value-store
[INFO] finished frobbing PureW/tokio-key-value-store
[INFO] frobbed toml for PureW/tokio-key-value-store written to work/ex/clippy-test-run/sources/stable/gh/PureW/tokio-key-value-store/Cargo.toml
[INFO] started frobbing PureW/tokio-key-value-store
[INFO] finished frobbing PureW/tokio-key-value-store
[INFO] frobbed toml for PureW/tokio-key-value-store written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PureW/tokio-key-value-store/Cargo.toml
[INFO] crate PureW/tokio-key-value-store has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting PureW/tokio-key-value-store against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PureW/tokio-key-value-store:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 601eb5a2efab2a7859a3e820e26f1128866801b91e8a318df5f84980e69270aa
[INFO] running `"docker" "start" "-a" "601eb5a2efab2a7859a3e820e26f1128866801b91e8a318df5f84980e69270aa"`
[INFO] [stderr]     Checking futures v0.1.11
[INFO] [stderr]     Checking crossbeam v0.2.10
[INFO] [stderr]     Checking bytes v0.4.1
[INFO] [stderr]     Checking concurrent-kv v0.2.1
[INFO] [stderr]     Checking tokio-io v0.1.1
[INFO] [stderr]     Checking tokio-service v0.1.0
[INFO] [stderr]     Checking tokio-core v0.1.6
[INFO] [stderr]     Checking tokio-proto v0.1.1
[INFO] [stderr]     Checking key-value-store v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/keyvalue/mod.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub mod keyvalue;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/keyvalue/mod.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub mod keyvalue;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/keyvalue/keyvalue.rs:22:28
[INFO] [stderr]    |
[INFO] [stderr] 22 |     pub fn get(&self, key: &String) -> Option<Arc<String>> {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/keyvalue/keyvalue.rs:22:28
[INFO] [stderr]    |
[INFO] [stderr] 22 |     pub fn get(&self, key: &String) -> Option<Arc<String>> {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/keyvalue/keyvalue.rs:39:44
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for &(ref key, ref value) in tests.into_iter() {
[INFO] [stderr]    |                                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: requested on the command line with `-D clippy::into-iter-on-array`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `key-value-store`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:156:21
[INFO] [stderr]     |
[INFO] [stderr] 156 |         KVService { map: map }
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `map`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:156:21
[INFO] [stderr]     |
[INFO] [stderr] 156 |         KVService { map: map }
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `map`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:49:60
[INFO] [stderr]    |
[INFO] [stderr] 49 |     fn verify_input_args(cmd: &str, num_args: usize, args: &Vec<String>) -> Result<(), io::Error> {
[INFO] [stderr]    |                                                            ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:71:59
[INFO] [stderr]    |
[INFO] [stderr] 71 |             _ => Err(io::Error::new(io::ErrorKind::Other, format!("unknown command"))),
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"unknown command".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 | /         match req {
[INFO] [stderr] 166 | |             &Command::Set(ref k, ref v) => {
[INFO] [stderr] 167 | |                 self.map.set(k.clone(), v.clone());
[INFO] [stderr] 168 | |                 KVResponse::Ok
[INFO] [stderr] ...   |
[INFO] [stderr] 176 | |             &Command::Unknown => KVResponse::Error("ERR".to_string(), format!("unknown command")),
[INFO] [stderr] 177 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 165 |         match *req {
[INFO] [stderr] 166 |             Command::Set(ref k, ref v) => {
[INFO] [stderr] 167 |                 self.map.set(k.clone(), v.clone());
[INFO] [stderr] 168 |                 KVResponse::Ok
[INFO] [stderr] 169 |             }
[INFO] [stderr] 170 |             Command::Get(ref k) => {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:176:71
[INFO] [stderr]     |
[INFO] [stderr] 176 |             &Command::Unknown => KVResponse::Error("ERR".to_string(), format!("unknown command")),
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"unknown command".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:49:60
[INFO] [stderr]    |
[INFO] [stderr] 49 |     fn verify_input_args(cmd: &str, num_args: usize, args: &Vec<String>) -> Result<(), io::Error> {
[INFO] [stderr]    |                                                            ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:71:59
[INFO] [stderr]    |
[INFO] [stderr] 71 |             _ => Err(io::Error::new(io::ErrorKind::Other, format!("unknown command"))),
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"unknown command".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 | /         match req {
[INFO] [stderr] 166 | |             &Command::Set(ref k, ref v) => {
[INFO] [stderr] 167 | |                 self.map.set(k.clone(), v.clone());
[INFO] [stderr] 168 | |                 KVResponse::Ok
[INFO] [stderr] ...   |
[INFO] [stderr] 176 | |             &Command::Unknown => KVResponse::Error("ERR".to_string(), format!("unknown command")),
[INFO] [stderr] 177 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 165 |         match *req {
[INFO] [stderr] 166 |             Command::Set(ref k, ref v) => {
[INFO] [stderr] 167 |                 self.map.set(k.clone(), v.clone());
[INFO] [stderr] 168 |                 KVResponse::Ok
[INFO] [stderr] 169 |             }
[INFO] [stderr] 170 |             Command::Get(ref k) => {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:176:71
[INFO] [stderr]     |
[INFO] [stderr] 176 |             &Command::Unknown => KVResponse::Error("ERR".to_string(), format!("unknown command")),
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"unknown command".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "601eb5a2efab2a7859a3e820e26f1128866801b91e8a318df5f84980e69270aa"`
[INFO] running `"docker" "rm" "-f" "601eb5a2efab2a7859a3e820e26f1128866801b91e8a318df5f84980e69270aa"`
[INFO] [stdout] 601eb5a2efab2a7859a3e820e26f1128866801b91e8a318df5f84980e69270aa