[INFO] updating cached repository PhdTrollSlayer/morust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PhdTrollSlayer/morust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PhdTrollSlayer/morust" "work/ex/clippy-test-run/sources/stable/gh/PhdTrollSlayer/morust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PhdTrollSlayer/morust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PhdTrollSlayer/morust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PhdTrollSlayer/morust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PhdTrollSlayer/morust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d333f25157ad975b2ab372499957d0d4ee389847 [INFO] sha for GitHub repo PhdTrollSlayer/morust: d333f25157ad975b2ab372499957d0d4ee389847 [INFO] validating manifest of PhdTrollSlayer/morust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PhdTrollSlayer/morust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PhdTrollSlayer/morust [INFO] finished frobbing PhdTrollSlayer/morust [INFO] frobbed toml for PhdTrollSlayer/morust written to work/ex/clippy-test-run/sources/stable/gh/PhdTrollSlayer/morust/Cargo.toml [INFO] started frobbing PhdTrollSlayer/morust [INFO] finished frobbing PhdTrollSlayer/morust [INFO] frobbed toml for PhdTrollSlayer/morust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PhdTrollSlayer/morust/Cargo.toml [INFO] crate PhdTrollSlayer/morust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PhdTrollSlayer/morust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PhdTrollSlayer/morust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0cc26a55f76fa0cd9b9f401244de594da4652ff7642eab4cef6ccfcbacc3d8eb [INFO] running `"docker" "start" "-a" "0cc26a55f76fa0cd9b9f401244de594da4652ff7642eab4cef6ccfcbacc3d8eb"` [INFO] [stderr] Checking arvore-morse v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tree.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | / if !start.clone().direita.is_none() { [INFO] [stderr] 233 | | if search_morse(&start.clone().direita.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 234 | | //println!("DIREITA"); [INFO] [stderr] 235 | | return search_morse(&start.clone().direita.expect("linh 170"), q); [INFO] [stderr] 236 | | } [INFO] [stderr] 237 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 232 | if !start.clone().direita.is_none() && search_morse(&start.clone().direita.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 233 | //println!("DIREITA"); [INFO] [stderr] 234 | return search_morse(&start.clone().direita.expect("linh 170"), q); [INFO] [stderr] 235 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tree.rs:239:5 [INFO] [stderr] | [INFO] [stderr] 239 | / if !start.clone().esquerda.is_none() { [INFO] [stderr] 240 | | if search_morse(&start.clone().esquerda.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 241 | | //println!("ESQUERDA"); [INFO] [stderr] 242 | | return search_morse(&start.clone().esquerda.expect("linh 170"), q); [INFO] [stderr] 243 | | } [INFO] [stderr] 244 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 239 | if !start.clone().esquerda.is_none() && search_morse(&start.clone().esquerda.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 240 | //println!("ESQUERDA"); [INFO] [stderr] 241 | return search_morse(&start.clone().esquerda.expect("linh 170"), q); [INFO] [stderr] 242 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tree.rs:256:5 [INFO] [stderr] | [INFO] [stderr] 256 | / if !start.clone().direita.is_none() { [INFO] [stderr] 257 | | if search_alfa(&start.clone().direita.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 258 | | //println!("DIREITA"); [INFO] [stderr] 259 | | return search_alfa(&start.clone().direita.expect("linh 170"), q); [INFO] [stderr] 260 | | } [INFO] [stderr] 261 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 256 | if !start.clone().direita.is_none() && search_alfa(&start.clone().direita.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 257 | //println!("DIREITA"); [INFO] [stderr] 258 | return search_alfa(&start.clone().direita.expect("linh 170"), q); [INFO] [stderr] 259 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tree.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | / if !start.clone().esquerda.is_none() { [INFO] [stderr] 264 | | if search_alfa(&start.clone().esquerda.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 265 | | //println!("ESQUERDA"); [INFO] [stderr] 266 | | return search_alfa(&start.clone().esquerda.expect("linh 170"), q); [INFO] [stderr] 267 | | } [INFO] [stderr] 268 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 263 | if !start.clone().esquerda.is_none() && search_alfa(&start.clone().esquerda.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 264 | //println!("ESQUERDA"); [INFO] [stderr] 265 | return search_alfa(&start.clone().esquerda.expect("linh 170"), q); [INFO] [stderr] 266 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tree.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | / if !start.clone().direita.is_none() { [INFO] [stderr] 233 | | if search_morse(&start.clone().direita.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 234 | | //println!("DIREITA"); [INFO] [stderr] 235 | | return search_morse(&start.clone().direita.expect("linh 170"), q); [INFO] [stderr] 236 | | } [INFO] [stderr] 237 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 232 | if !start.clone().direita.is_none() && search_morse(&start.clone().direita.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 233 | //println!("DIREITA"); [INFO] [stderr] 234 | return search_morse(&start.clone().direita.expect("linh 170"), q); [INFO] [stderr] 235 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tree.rs:239:5 [INFO] [stderr] | [INFO] [stderr] 239 | / if !start.clone().esquerda.is_none() { [INFO] [stderr] 240 | | if search_morse(&start.clone().esquerda.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 241 | | //println!("ESQUERDA"); [INFO] [stderr] 242 | | return search_morse(&start.clone().esquerda.expect("linh 170"), q); [INFO] [stderr] 243 | | } [INFO] [stderr] 244 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 239 | if !start.clone().esquerda.is_none() && search_morse(&start.clone().esquerda.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 240 | //println!("ESQUERDA"); [INFO] [stderr] 241 | return search_morse(&start.clone().esquerda.expect("linh 170"), q); [INFO] [stderr] 242 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tree.rs:256:5 [INFO] [stderr] | [INFO] [stderr] 256 | / if !start.clone().direita.is_none() { [INFO] [stderr] 257 | | if search_alfa(&start.clone().direita.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 258 | | //println!("DIREITA"); [INFO] [stderr] 259 | | return search_alfa(&start.clone().direita.expect("linh 170"), q); [INFO] [stderr] 260 | | } [INFO] [stderr] 261 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 256 | if !start.clone().direita.is_none() && search_alfa(&start.clone().direita.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 257 | //println!("DIREITA"); [INFO] [stderr] 258 | return search_alfa(&start.clone().direita.expect("linh 170"), q); [INFO] [stderr] 259 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tree.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | / if !start.clone().esquerda.is_none() { [INFO] [stderr] 264 | | if search_alfa(&start.clone().esquerda.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 265 | | //println!("ESQUERDA"); [INFO] [stderr] 266 | | return search_alfa(&start.clone().esquerda.expect("linh 170"), q); [INFO] [stderr] 267 | | } [INFO] [stderr] 268 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 263 | if !start.clone().esquerda.is_none() && search_alfa(&start.clone().esquerda.expect("linh 169"), q) != "".to_ascii_uppercase() { [INFO] [stderr] 264 | //println!("ESQUERDA"); [INFO] [stderr] 265 | return search_alfa(&start.clone().esquerda.expect("linh 170"), q); [INFO] [stderr] 266 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/tree.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn into_morse_tree(&mut self)-> &mut Node { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tree.rs:232:8 [INFO] [stderr] | [INFO] [stderr] 232 | if !start.clone().direita.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start.clone().direita.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tree.rs:239:8 [INFO] [stderr] | [INFO] [stderr] 239 | if !start.clone().esquerda.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start.clone().esquerda.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tree.rs:256:8 [INFO] [stderr] | [INFO] [stderr] 256 | if !start.clone().direita.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start.clone().direita.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tree.rs:263:8 [INFO] [stderr] | [INFO] [stderr] 263 | if !start.clone().esquerda.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start.clone().esquerda.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/tree.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn into_morse_tree(&mut self)-> &mut Node { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tree.rs:232:8 [INFO] [stderr] | [INFO] [stderr] 232 | if !start.clone().direita.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start.clone().direita.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tree.rs:239:8 [INFO] [stderr] | [INFO] [stderr] 239 | if !start.clone().esquerda.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start.clone().esquerda.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tree.rs:256:8 [INFO] [stderr] | [INFO] [stderr] 256 | if !start.clone().direita.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start.clone().direita.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tree.rs:263:8 [INFO] [stderr] | [INFO] [stderr] 263 | if !start.clone().esquerda.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start.clone().esquerda.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `"docker" "inspect" "0cc26a55f76fa0cd9b9f401244de594da4652ff7642eab4cef6ccfcbacc3d8eb"` [INFO] running `"docker" "rm" "-f" "0cc26a55f76fa0cd9b9f401244de594da4652ff7642eab4cef6ccfcbacc3d8eb"` [INFO] [stdout] 0cc26a55f76fa0cd9b9f401244de594da4652ff7642eab4cef6ccfcbacc3d8eb