[INFO] updating cached repository Payathp/text-adventure [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Payathp/text-adventure [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Payathp/text-adventure" "work/ex/clippy-test-run/sources/stable/gh/Payathp/text-adventure"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Payathp/text-adventure'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Payathp/text-adventure" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Payathp/text-adventure"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Payathp/text-adventure'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 15342f7159d7024a6e3186bebf4dd84c944977ee [INFO] sha for GitHub repo Payathp/text-adventure: 15342f7159d7024a6e3186bebf4dd84c944977ee [INFO] validating manifest of Payathp/text-adventure on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Payathp/text-adventure on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Payathp/text-adventure [INFO] finished frobbing Payathp/text-adventure [INFO] frobbed toml for Payathp/text-adventure written to work/ex/clippy-test-run/sources/stable/gh/Payathp/text-adventure/Cargo.toml [INFO] started frobbing Payathp/text-adventure [INFO] finished frobbing Payathp/text-adventure [INFO] frobbed toml for Payathp/text-adventure written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Payathp/text-adventure/Cargo.toml [INFO] crate Payathp/text-adventure has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Payathp/text-adventure against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Payathp/text-adventure:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e3b6d5d2f14d6b0f67adf4eaf00b267a58669941bec4d21b2f9d724ab6ad3b41 [INFO] running `"docker" "start" "-a" "e3b6d5d2f14d6b0f67adf4eaf00b267a58669941bec4d21b2f9d724ab6ad3b41"` [INFO] [stderr] Checking text-adventure v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tiles.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tiles.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tiles.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tiles.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | enemy: enemy, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `enemy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tiles.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | damage: damage, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `damage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enemies.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enemies.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | hp: hp, [INFO] [stderr] | ^^^^^^ help: replace it with: `hp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enemies.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | damage: damage, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `damage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | inventory: inventory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inventory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | hp: hp, [INFO] [stderr] | ^^^^^^ help: replace it with: `hp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actions.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actions.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | hotkey: hotkey, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hotkey` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tiles.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tiles.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tiles.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tiles.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | enemy: enemy, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `enemy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tiles.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | damage: damage, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `damage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enemies.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enemies.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | hp: hp, [INFO] [stderr] | ^^^^^^ help: replace it with: `hp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enemies.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | damage: damage, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `damage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | inventory: inventory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inventory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | hp: hp, [INFO] [stderr] | ^^^^^^ help: replace it with: `hp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actions.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actions.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | hotkey: hotkey, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hotkey` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:109:19 [INFO] [stderr] | [INFO] [stderr] 109 | "" => return Room::empty_room(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::empty_room(x, y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:110:31 [INFO] [stderr] | [INFO] [stderr] 110 | "StartingRoom" => return Room::make_starting_room(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::make_starting_room(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:111:33 [INFO] [stderr] | [INFO] [stderr] 111 | "FindDaggerRoom" => return Room::make_find_dagger_room(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::make_find_dagger_room(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:112:31 [INFO] [stderr] | [INFO] [stderr] 112 | "SnakePitRoom" => return Room::make_snake_pit_room(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::make_snake_pit_room(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:113:32 [INFO] [stderr] | [INFO] [stderr] 113 | "Find5GoldRoom" => return Room::make_find_gold_room(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::make_find_gold_room(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:114:34 [INFO] [stderr] | [INFO] [stderr] 114 | "GiantSpiderRoom" => return Room::make_giant_spider_room(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::make_giant_spider_room(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:115:32 [INFO] [stderr] | [INFO] [stderr] 115 | "EmptyCavePath" => return Room::make_empty_cave_path(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::make_empty_cave_path(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:116:32 [INFO] [stderr] | [INFO] [stderr] 116 | "LeaveCaveRoom" => return Room::make_leave_cave_room(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::make_leave_cave_room(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:125:19 [INFO] [stderr] | [INFO] [stderr] 125 | "" => return "", [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | / return "You find yourself in a cave with a flickering toch on the wall.\ [INFO] [stderr] 128 | | You can make out four paths, each equally as dark and foreboding.", [INFO] [stderr] | |__________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 127 | "You find yourself in a cave with a flickering toch on the wall.\ [INFO] [stderr] 128 | You can make out four paths, each equally as dark and foreboding.", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | / return "You notice something shiny in the corner.\ [INFO] [stderr] 131 | | It's a dagger! You pick it up.", [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 130 | "You notice something shiny in the corner.\ [INFO] [stderr] 131 | It's a dagger! You pick it up.", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | / return "You have fallen into a pit of deadly snakes!\n\ [INFO] [stderr] 134 | | You have died!", [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 133 | "You have fallen into a pit of deadly snakes!\n\ [INFO] [stderr] 134 | You have died!", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | return "Someone dropped a 5 gold piece. You pick it up", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Someone dropped a 5 gold piece. You pick it up"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:141:21 [INFO] [stderr] | [INFO] [stderr] 141 | return "A giant spider jumps dowm from its web in front of you!" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"A giant spider jumps dowm from its web in front of you!"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | return "The corps of a dead spider rots on the ground." [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"The corps of a dead spider rots on the ground."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | return "Another unremarkable part of the cave. You must forge onwards.", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Another unremarkable part of the cave. You must forge onwards."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | / return "You see a bright light in the distance ...\ [INFO] [stderr] 152 | | ... it grows as you get closer! It's sunlight\n\ [INFO] [stderr] 153 | | Victory is yours!", [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 151 | "You see a bright light in the distance ...\ [INFO] [stderr] 152 | ... it grows as you get closer! It's sunlight\n\ [INFO] [stderr] 153 | Victory is yours!", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | return moves; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `moves` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/tiles.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | if (self.position.x+1 <= world::get_x_limit(map)) & world::tile_in_existence(map, self.position.x+1, self.position.y) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 207 | if (self.position.x < world::get_x_limit(map)) & world::tile_in_existence(map, self.position.x+1, self.position.y) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/tiles.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | if (self.position.x-1 >= 0) & world::tile_in_existence(map, self.position.x-1, self.position.y) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 211 | if (self.position.x > 0) & world::tile_in_existence(map, self.position.x-1, self.position.y) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/tiles.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | if (self.position.y-1 >= 0) & world::tile_in_existence(map, self.position.x, self.position.y-1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 215 | if (self.position.y > 0) & world::tile_in_existence(map, self.position.x, self.position.y-1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | return moves; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `moves` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | return moves; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `moves` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return (width, height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(width, height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return res.0 * res.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `res.0 * res.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | return map_display; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `map_display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:112:20 [INFO] [stderr] | [INFO] [stderr] 112 | Some(_) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:113:14 [INFO] [stderr] | [INFO] [stderr] 113 | _ => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | return biggest_x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `biggest_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | return biggest_y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `biggest_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `enemies` [INFO] [stderr] --> src/player.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use enemies; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actions.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actions.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actions.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actions.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actions.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actions.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actions.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:109:19 [INFO] [stderr] | [INFO] [stderr] 109 | "" => return Room::empty_room(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::empty_room(x, y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:110:31 [INFO] [stderr] | [INFO] [stderr] 110 | "StartingRoom" => return Room::make_starting_room(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::make_starting_room(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:111:33 [INFO] [stderr] | [INFO] [stderr] 111 | "FindDaggerRoom" => return Room::make_find_dagger_room(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::make_find_dagger_room(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:112:31 [INFO] [stderr] | [INFO] [stderr] 112 | "SnakePitRoom" => return Room::make_snake_pit_room(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::make_snake_pit_room(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:113:32 [INFO] [stderr] | [INFO] [stderr] 113 | "Find5GoldRoom" => return Room::make_find_gold_room(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::make_find_gold_room(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:114:34 [INFO] [stderr] | [INFO] [stderr] 114 | "GiantSpiderRoom" => return Room::make_giant_spider_room(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::make_giant_spider_room(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:115:32 [INFO] [stderr] | [INFO] [stderr] 115 | "EmptyCavePath" => return Room::make_empty_cave_path(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::make_empty_cave_path(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:116:32 [INFO] [stderr] | [INFO] [stderr] 116 | "LeaveCaveRoom" => return Room::make_leave_cave_room(x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Room::make_leave_cave_room(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:125:19 [INFO] [stderr] | [INFO] [stderr] 125 | "" => return "", [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | / return "You find yourself in a cave with a flickering toch on the wall.\ [INFO] [stderr] 128 | | You can make out four paths, each equally as dark and foreboding.", [INFO] [stderr] | |__________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 127 | "You find yourself in a cave with a flickering toch on the wall.\ [INFO] [stderr] 128 | You can make out four paths, each equally as dark and foreboding.", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | / return "You notice something shiny in the corner.\ [INFO] [stderr] 131 | | It's a dagger! You pick it up.", [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 130 | "You notice something shiny in the corner.\ [INFO] [stderr] 131 | It's a dagger! You pick it up.", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | / return "You have fallen into a pit of deadly snakes!\n\ [INFO] [stderr] 134 | | You have died!", [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 133 | "You have fallen into a pit of deadly snakes!\n\ [INFO] [stderr] 134 | You have died!", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | return "Someone dropped a 5 gold piece. You pick it up", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Someone dropped a 5 gold piece. You pick it up"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:141:21 [INFO] [stderr] | [INFO] [stderr] 141 | return "A giant spider jumps dowm from its web in front of you!" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"A giant spider jumps dowm from its web in front of you!"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | return "The corps of a dead spider rots on the ground." [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"The corps of a dead spider rots on the ground."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | return "Another unremarkable part of the cave. You must forge onwards.", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Another unremarkable part of the cave. You must forge onwards."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | / return "You see a bright light in the distance ...\ [INFO] [stderr] 152 | | ... it grows as you get closer! It's sunlight\n\ [INFO] [stderr] 153 | | Victory is yours!", [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 151 | "You see a bright light in the distance ...\ [INFO] [stderr] 152 | ... it grows as you get closer! It's sunlight\n\ [INFO] [stderr] 153 | Victory is yours!", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | return moves; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `moves` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/tiles.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | if (self.position.x+1 <= world::get_x_limit(map)) & world::tile_in_existence(map, self.position.x+1, self.position.y) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 207 | if (self.position.x < world::get_x_limit(map)) & world::tile_in_existence(map, self.position.x+1, self.position.y) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/tiles.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | if (self.position.x-1 >= 0) & world::tile_in_existence(map, self.position.x-1, self.position.y) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 211 | if (self.position.x > 0) & world::tile_in_existence(map, self.position.x-1, self.position.y) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/tiles.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | if (self.position.y-1 >= 0) & world::tile_in_existence(map, self.position.x, self.position.y-1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 215 | if (self.position.y > 0) & world::tile_in_existence(map, self.position.x, self.position.y-1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | return moves; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `moves` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tiles.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | return moves; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `moves` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return (width, height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(width, height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return res.0 * res.1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `res.0 * res.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | return map_display; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `map_display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:112:20 [INFO] [stderr] | [INFO] [stderr] 112 | Some(_) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:113:14 [INFO] [stderr] | [INFO] [stderr] 113 | _ => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | return biggest_x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `biggest_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | return biggest_y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `biggest_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `enemies` [INFO] [stderr] --> src/player.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use enemies; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/player.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actions.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actions.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actions.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actions.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actions.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actions.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/actions.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `victory` [INFO] [stderr] --> src/player.rs:19:66 [INFO] [stderr] | [INFO] [stderr] 19 | fn new(inventory: Vec, hp: i32, x: i32, y: i32, victory: bool) -> Player [INFO] [stderr] | ^^^^^^^ help: consider using `_victory` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `action_method` [INFO] [stderr] --> src/player.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | let mut action_method = actions::Action::identify_action_with_enemies(action, self, map); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_action_method` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/player.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | let mut action_method = actions::Action::identify_action_with_enemies(action, self, map); [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/game.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | let mut current_room = &mut world::tile_exists(&map, current_player.position.x, current_player.position.y).unwrap().clone(); [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_name` [INFO] [stderr] --> src/tiles.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | pub fn get_name(&self) -> &'static str [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `not_empty_tile` [INFO] [stderr] --> src/tiles.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | pub fn not_empty_tile(&self) -> bool [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_rock` [INFO] [stderr] --> src/items.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn new_rock() -> Item [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_damage` [INFO] [stderr] --> src/items.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn get_damage(&self) -> i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_ogre` [INFO] [stderr] --> src/enemies.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn new_ogre() -> Enemy [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_name` [INFO] [stderr] --> src/enemies.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn get_name<'a>(&self) -> &'a str [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `current_position` [INFO] [stderr] --> src/player.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn current_position(&self) -> &tiles::Position [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `do_action` [INFO] [stderr] --> src/player.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn do_action<'a>(&mut self, map: &mut Vec, action: &'a str) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/tiles.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / pub fn make_room_from_str<'a>(x: i32, y: i32, room_name: &'a str) -> Room [INFO] [stderr] 106 | | { [INFO] [stderr] 107 | | match room_name [INFO] [stderr] 108 | | { [INFO] [stderr] ... | [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tiles.rs:204:39 [INFO] [stderr] | [INFO] [stderr] 204 | pub fn adjacent_moves(&self, map: &Vec) -> Vec [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Room]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tiles.rs:227:46 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn available_actions(&mut self, map: &Vec) -> Vec [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Room]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/world.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn load_map_from_file<'a>(file_name: &'a str) -> Vec [INFO] [stderr] 8 | | { [INFO] [stderr] 9 | | let mut file = File::open(file_name).unwrap(); [INFO] [stderr] 10 | | let mut container = String::new(); [INFO] [stderr] 11 | | file.read_to_string(&mut container).unwrap(); [INFO] [stderr] 12 | | process(&container[ .. ]) [INFO] [stderr] 13 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/world.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn need_size<'a>(map: &'a str) -> u32 [INFO] [stderr] 28 | | { [INFO] [stderr] 29 | | let res = dimensions(map); [INFO] [stderr] 30 | | return res.0 * res.1; [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/world.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn process<'a>(map: &'a str) -> Vec [INFO] [stderr] 34 | | { [INFO] [stderr] 35 | | let mut map_display: Vec = Vec::new(); [INFO] [stderr] 36 | | map_display.reserve(need_size(&map) as usize); [INFO] [stderr] ... | [INFO] [stderr] 55 | | return map_display; [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/world.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | if current_str.contains("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/world.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn count_occurence<'a>(map: &'a str, sym: char) -> u32 [INFO] [stderr] 59 | | { [INFO] [stderr] 60 | | let map_chars = map.chars(); [INFO] [stderr] 61 | | let mut res = 0; [INFO] [stderr] ... | [INFO] [stderr] 69 | | return res; [INFO] [stderr] 70 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn tile_exists(map: &Vec, x: i32, y: i32) -> Option<&tiles::Room> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[tiles::Room]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:108:31 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn tile_in_existence(map: &Vec, x: i32, y: i32) -> bool [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[tiles::Room]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn get_x_limit(map: &Vec) -> i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[tiles::Room]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn get_y_limit(map: &Vec) -> i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[tiles::Room]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:145:27 [INFO] [stderr] | [INFO] [stderr] 145 | pub fn starting_room(map: &Vec) -> &tiles::Position [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[tiles::Room]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/player.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn make_player(map: &Vec) -> Player [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[tiles::Room]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/game.rs:63:33 [INFO] [stderr] | [INFO] [stderr] 63 | / match actions::Action::identify_action_with_enemies(&action_input.trim(), &mut current_player, &mut map) [INFO] [stderr] 64 | | { [INFO] [stderr] 65 | | true => break 'inputloop, [INFO] [stderr] 66 | | _ => continue 'inputloop, [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________________________________^ help: consider using an if/else expression: `if actions::Action::identify_action_with_enemies(&action_input.trim(), &mut current_player, &mut map) { break 'inputloop } else { continue 'inputloop }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: unused variable: `victory` [INFO] [stderr] --> src/player.rs:19:66 [INFO] [stderr] | [INFO] [stderr] 19 | fn new(inventory: Vec, hp: i32, x: i32, y: i32, victory: bool) -> Player [INFO] [stderr] | ^^^^^^^ help: consider using `_victory` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `action_method` [INFO] [stderr] --> src/player.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | let mut action_method = actions::Action::identify_action_with_enemies(action, self, map); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_action_method` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/player.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | let mut action_method = actions::Action::identify_action_with_enemies(action, self, map); [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/game.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | let mut current_room = &mut world::tile_exists(&map, current_player.position.x, current_player.position.y).unwrap().clone(); [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_name` [INFO] [stderr] --> src/tiles.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | pub fn get_name(&self) -> &'static str [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `not_empty_tile` [INFO] [stderr] --> src/tiles.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | pub fn not_empty_tile(&self) -> bool [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_rock` [INFO] [stderr] --> src/items.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn new_rock() -> Item [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_damage` [INFO] [stderr] --> src/items.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn get_damage(&self) -> i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_ogre` [INFO] [stderr] --> src/enemies.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn new_ogre() -> Enemy [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_name` [INFO] [stderr] --> src/enemies.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn get_name<'a>(&self) -> &'a str [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `current_position` [INFO] [stderr] --> src/player.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn current_position(&self) -> &tiles::Position [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `do_action` [INFO] [stderr] --> src/player.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn do_action<'a>(&mut self, map: &mut Vec, action: &'a str) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/tiles.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / pub fn make_room_from_str<'a>(x: i32, y: i32, room_name: &'a str) -> Room [INFO] [stderr] 106 | | { [INFO] [stderr] 107 | | match room_name [INFO] [stderr] 108 | | { [INFO] [stderr] ... | [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tiles.rs:204:39 [INFO] [stderr] | [INFO] [stderr] 204 | pub fn adjacent_moves(&self, map: &Vec) -> Vec [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Room]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tiles.rs:227:46 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn available_actions(&mut self, map: &Vec) -> Vec [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Room]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/world.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn load_map_from_file<'a>(file_name: &'a str) -> Vec [INFO] [stderr] 8 | | { [INFO] [stderr] 9 | | let mut file = File::open(file_name).unwrap(); [INFO] [stderr] 10 | | let mut container = String::new(); [INFO] [stderr] 11 | | file.read_to_string(&mut container).unwrap(); [INFO] [stderr] 12 | | process(&container[ .. ]) [INFO] [stderr] 13 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/world.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn need_size<'a>(map: &'a str) -> u32 [INFO] [stderr] 28 | | { [INFO] [stderr] 29 | | let res = dimensions(map); [INFO] [stderr] 30 | | return res.0 * res.1; [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/world.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn process<'a>(map: &'a str) -> Vec [INFO] [stderr] 34 | | { [INFO] [stderr] 35 | | let mut map_display: Vec = Vec::new(); [INFO] [stderr] 36 | | map_display.reserve(need_size(&map) as usize); [INFO] [stderr] ... | [INFO] [stderr] 55 | | return map_display; [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/world.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | if current_str.contains("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/world.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn count_occurence<'a>(map: &'a str, sym: char) -> u32 [INFO] [stderr] 59 | | { [INFO] [stderr] 60 | | let map_chars = map.chars(); [INFO] [stderr] 61 | | let mut res = 0; [INFO] [stderr] ... | [INFO] [stderr] 69 | | return res; [INFO] [stderr] 70 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn tile_exists(map: &Vec, x: i32, y: i32) -> Option<&tiles::Room> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[tiles::Room]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:108:31 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn tile_in_existence(map: &Vec, x: i32, y: i32) -> bool [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[tiles::Room]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn get_x_limit(map: &Vec) -> i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[tiles::Room]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn get_y_limit(map: &Vec) -> i32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[tiles::Room]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:145:27 [INFO] [stderr] | [INFO] [stderr] 145 | pub fn starting_room(map: &Vec) -> &tiles::Position [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[tiles::Room]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/player.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn make_player(map: &Vec) -> Player [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[tiles::Room]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/game.rs:63:33 [INFO] [stderr] | [INFO] [stderr] 63 | / match actions::Action::identify_action_with_enemies(&action_input.trim(), &mut current_player, &mut map) [INFO] [stderr] 64 | | { [INFO] [stderr] 65 | | true => break 'inputloop, [INFO] [stderr] 66 | | _ => continue 'inputloop, [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________________________________^ help: consider using an if/else expression: `if actions::Action::identify_action_with_enemies(&action_input.trim(), &mut current_player, &mut map) { break 'inputloop } else { continue 'inputloop }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "e3b6d5d2f14d6b0f67adf4eaf00b267a58669941bec4d21b2f9d724ab6ad3b41"` [INFO] running `"docker" "rm" "-f" "e3b6d5d2f14d6b0f67adf4eaf00b267a58669941bec4d21b2f9d724ab6ad3b41"` [INFO] [stdout] e3b6d5d2f14d6b0f67adf4eaf00b267a58669941bec4d21b2f9d724ab6ad3b41