[INFO] updating cached repository Pamplemousse/mathematical_expression_evaluation [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Pamplemousse/mathematical_expression_evaluation [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Pamplemousse/mathematical_expression_evaluation" "work/ex/clippy-test-run/sources/stable/gh/Pamplemousse/mathematical_expression_evaluation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Pamplemousse/mathematical_expression_evaluation'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Pamplemousse/mathematical_expression_evaluation" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Pamplemousse/mathematical_expression_evaluation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Pamplemousse/mathematical_expression_evaluation'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d245ccaa3c9a29ef822865c96f5078c164e0c3b1 [INFO] sha for GitHub repo Pamplemousse/mathematical_expression_evaluation: d245ccaa3c9a29ef822865c96f5078c164e0c3b1 [INFO] validating manifest of Pamplemousse/mathematical_expression_evaluation on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Pamplemousse/mathematical_expression_evaluation on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Pamplemousse/mathematical_expression_evaluation [INFO] finished frobbing Pamplemousse/mathematical_expression_evaluation [INFO] frobbed toml for Pamplemousse/mathematical_expression_evaluation written to work/ex/clippy-test-run/sources/stable/gh/Pamplemousse/mathematical_expression_evaluation/Cargo.toml [INFO] started frobbing Pamplemousse/mathematical_expression_evaluation [INFO] finished frobbing Pamplemousse/mathematical_expression_evaluation [INFO] frobbed toml for Pamplemousse/mathematical_expression_evaluation written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Pamplemousse/mathematical_expression_evaluation/Cargo.toml [INFO] crate Pamplemousse/mathematical_expression_evaluation has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Pamplemousse/mathematical_expression_evaluation against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Pamplemousse/mathematical_expression_evaluation:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 02ad9cea3dc783f2345333ae571ec152cea0d5593c00c357c459c3855dbc7dae [INFO] running `"docker" "start" "-a" "02ad9cea3dc783f2345333ae571ec152cea0d5593c00c357c459c3855dbc7dae"` [INFO] [stderr] Checking math_eval v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer/token/operator.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return operator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `operator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer/token/literal/digit.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return operator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `operator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer/token/literal/mod.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | return Literal(digits); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Literal(digits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::literal::digit::Digit` [INFO] [stderr] --> src/tokenizer/token/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use self::literal::digit::Digit; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::token::operator::Operator` [INFO] [stderr] --> src/tokenizer/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use self::token::operator::Operator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer/mod.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return tokens; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from` [INFO] [stderr] --> src/tokenizer/token/literal/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn from(string: String) -> Literal { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tokenizer/token/literal/mod.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | .map(|c| Digit::new(c)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Digit::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tokenizer/mod.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match digit { [INFO] [stderr] 22 | | Some(digit) => { [INFO] [stderr] 23 | | literal_buffer.push(digit); [INFO] [stderr] 24 | | continue; [INFO] [stderr] 25 | | }, [INFO] [stderr] 26 | | None => () [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Some(digit) = digit { [INFO] [stderr] 22 | literal_buffer.push(digit); [INFO] [stderr] 23 | continue; [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tokenizer/mod.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match token { [INFO] [stderr] 36 | | Some(token) => tokens.push(token), [INFO] [stderr] 37 | | _ => () [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(token) = token { tokens.push(token) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer/token/operator.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return operator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `operator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer/token/literal/digit.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return operator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `operator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer/token/literal/mod.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | return Literal(digits); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Literal(digits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::literal::digit::Digit` [INFO] [stderr] --> src/tokenizer/token/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use self::literal::digit::Digit; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::token::operator::Operator` [INFO] [stderr] --> src/tokenizer/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use self::token::operator::Operator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer/mod.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return tokens; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tokenizer/token/literal/mod.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | .map(|c| Digit::new(c)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Digit::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tokenizer/token/literal/mod.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | .map(|vector| Literal::new(vector)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Literal::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tokenizer/token/literal/mod.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | .map(|string| Literal::from(string)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Literal::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tokenizer/token/literal/mod.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | .map(|vector| Literal::new(vector)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Literal::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tokenizer/mod.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match digit { [INFO] [stderr] 22 | | Some(digit) => { [INFO] [stderr] 23 | | literal_buffer.push(digit); [INFO] [stderr] 24 | | continue; [INFO] [stderr] 25 | | }, [INFO] [stderr] 26 | | None => () [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Some(digit) = digit { [INFO] [stderr] 22 | literal_buffer.push(digit); [INFO] [stderr] 23 | continue; [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tokenizer/mod.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match token { [INFO] [stderr] 36 | | Some(token) => tokens.push(token), [INFO] [stderr] 37 | | _ => () [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(token) = token { tokens.push(token) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.86s [INFO] running `"docker" "inspect" "02ad9cea3dc783f2345333ae571ec152cea0d5593c00c357c459c3855dbc7dae"` [INFO] running `"docker" "rm" "-f" "02ad9cea3dc783f2345333ae571ec152cea0d5593c00c357c459c3855dbc7dae"` [INFO] [stdout] 02ad9cea3dc783f2345333ae571ec152cea0d5593c00c357c459c3855dbc7dae