[INFO] updating cached repository PJB3005/bsdiff-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PJB3005/bsdiff-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PJB3005/bsdiff-rs" "work/ex/clippy-test-run/sources/stable/gh/PJB3005/bsdiff-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PJB3005/bsdiff-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PJB3005/bsdiff-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PJB3005/bsdiff-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PJB3005/bsdiff-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e84234fb5a2c0020209fa3135a0ba0c9ca56c77a [INFO] sha for GitHub repo PJB3005/bsdiff-rs: e84234fb5a2c0020209fa3135a0ba0c9ca56c77a [INFO] validating manifest of PJB3005/bsdiff-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PJB3005/bsdiff-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PJB3005/bsdiff-rs [INFO] finished frobbing PJB3005/bsdiff-rs [INFO] frobbed toml for PJB3005/bsdiff-rs written to work/ex/clippy-test-run/sources/stable/gh/PJB3005/bsdiff-rs/Cargo.toml [INFO] started frobbing PJB3005/bsdiff-rs [INFO] finished frobbing PJB3005/bsdiff-rs [INFO] frobbed toml for PJB3005/bsdiff-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PJB3005/bsdiff-rs/Cargo.toml [INFO] crate PJB3005/bsdiff-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PJB3005/bsdiff-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PJB3005/bsdiff-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d90e53d658aa1be16ee6a5244067df7341ebe0d68548dec314f9f9e7f301521e [INFO] running `"docker" "start" "-a" "d90e53d658aa1be16ee6a5244067df7341ebe0d68548dec314f9f9e7f301521e"` [INFO] [stderr] Checking bsdiff v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diff.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | I: I, [INFO] [stderr] | ^^^^ help: replace it with: `I` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diff.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/diff.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | let mut x: isize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diff.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | I: I, [INFO] [stderr] | ^^^^ help: replace it with: `I` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diff.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/diff.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | let mut x: isize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/diff.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | if I == ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/diff.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | if buffer == ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:92:16 [INFO] [stderr] | [INFO] [stderr] 92 | if !(k < start + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `k >= start + len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | if !(k + i < start + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `k + i >= start + len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:116:20 [INFO] [stderr] | [INFO] [stderr] 116 | if !(i < j) { [INFO] [stderr] | ^^^^^^^^ help: try: `i >= j` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:133:16 [INFO] [stderr] | [INFO] [stderr] 133 | if !(i < start + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i >= start + len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:150:16 [INFO] [stderr] | [INFO] [stderr] 150 | if !(i < jj) { [INFO] [stderr] | ^^^^^^^^^ help: try: `i >= jj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:168:16 [INFO] [stderr] | [INFO] [stderr] 168 | if !(jj + j < kk) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `jj + j >= kk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:185:16 [INFO] [stderr] | [INFO] [stderr] 185 | if !(i < kk - jj) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= kk - jj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop5` [INFO] [stderr] --> src/diff.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / 'loop5: loop { [INFO] [stderr] 168 | | if !(jj + j < kk) { [INFO] [stderr] 169 | | break; [INFO] [stderr] 170 | | } [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop2` [INFO] [stderr] --> src/diff.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | / 'loop2: loop { [INFO] [stderr] 133 | | if !(i < start + len) { [INFO] [stderr] 134 | | break; [INFO] [stderr] 135 | | } [INFO] [stderr] ... | [INFO] [stderr] 142 | | i = i + 1isize; [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop9` [INFO] [stderr] --> src/diff.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | / 'loop9: loop { [INFO] [stderr] 185 | | if !(i < kk - jj) { [INFO] [stderr] 186 | | break; [INFO] [stderr] 187 | | } [INFO] [stderr] 188 | | *V.offset(*I.offset(jj + i)) = kk - 1isize; [INFO] [stderr] 189 | | i = i + 1isize; [INFO] [stderr] 190 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop34` [INFO] [stderr] --> src/diff.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | / 'loop34: loop { [INFO] [stderr] 99 | | if !(k + i < start + len) { [INFO] [stderr] 100 | | break; [INFO] [stderr] 101 | | } [INFO] [stderr] ... | [INFO] [stderr] 112 | | i = i + 1isize; [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop36` [INFO] [stderr] --> src/diff.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | / 'loop36: loop { [INFO] [stderr] 116 | | if !(i < j) { [INFO] [stderr] 117 | | break; [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | *V.offset(*I.offset(k + i)) = k + j - 1isize; [INFO] [stderr] 120 | | i = i + 1isize; [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop4` [INFO] [stderr] --> src/diff.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | / 'loop4: loop { [INFO] [stderr] 150 | | if !(i < jj) { [INFO] [stderr] 151 | | break; [INFO] [stderr] 152 | | } [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop31` [INFO] [stderr] --> src/diff.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / 'loop31: loop { [INFO] [stderr] 92 | | if !(k < start + len) { [INFO] [stderr] 93 | | break; [INFO] [stderr] 94 | | } [INFO] [stderr] ... | [INFO] [stderr] 125 | | k = k + j; [INFO] [stderr] 126 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:110:21 [INFO] [stderr] | [INFO] [stderr] 110 | j = j + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | k = k + j; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `k += j` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | jj = jj + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `jj += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | kk = kk + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `kk += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | jj = jj + start; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `jj += start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | kk = kk + jj; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `kk += jj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | j = j + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | k = k + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `k += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | j = j + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | k = k + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `k += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:207:12 [INFO] [stderr] | [INFO] [stderr] 207 | if !(i < 256isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i >= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:215:12 [INFO] [stderr] | [INFO] [stderr] 215 | if !(i < oldsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= oldsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:225:12 [INFO] [stderr] | [INFO] [stderr] 225 | if !(i < 256isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i >= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:235:12 [INFO] [stderr] | [INFO] [stderr] 235 | if !(i > 0isize) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i <= 0isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:244:12 [INFO] [stderr] | [INFO] [stderr] 244 | if !(i < oldsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= oldsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:258:12 [INFO] [stderr] | [INFO] [stderr] 258 | if !(i < oldsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= oldsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:267:12 [INFO] [stderr] | [INFO] [stderr] 267 | if !(i < 256isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i >= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:278:12 [INFO] [stderr] | [INFO] [stderr] 278 | if !(*I.offset(0isize) != -(oldsize + 1isize)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*I.offset(0isize) == -(oldsize + 1isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:284:16 [INFO] [stderr] | [INFO] [stderr] 284 | if !(i < oldsize + 1isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i >= oldsize + 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:307:12 [INFO] [stderr] | [INFO] [stderr] 307 | if !(i < oldsize + 1isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i >= oldsize + 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop17` [INFO] [stderr] --> src/diff.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | / 'loop17: loop { [INFO] [stderr] 307 | | if !(i < oldsize + 1isize) { [INFO] [stderr] 308 | | break; [INFO] [stderr] 309 | | } [INFO] [stderr] 310 | | *I.offset(*V.offset(i)) = i; [INFO] [stderr] 311 | | i = i + 1isize; [INFO] [stderr] 312 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop11` [INFO] [stderr] --> src/diff.rs:257:5 [INFO] [stderr] | [INFO] [stderr] 257 | / 'loop11: loop { [INFO] [stderr] 258 | | if !(i < oldsize) { [INFO] [stderr] 259 | | break; [INFO] [stderr] 260 | | } [INFO] [stderr] 261 | | *V.offset(i) = buckets[*old.offset(i) as (usize)]; [INFO] [stderr] 262 | | i = i + 1isize; [INFO] [stderr] 263 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop5` [INFO] [stderr] --> src/diff.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | / 'loop5: loop { [INFO] [stderr] 225 | | if !(i < 256isize) { [INFO] [stderr] 226 | | break; [INFO] [stderr] 227 | | } [INFO] [stderr] ... | [INFO] [stderr] 231 | | i = i + 1isize; [INFO] [stderr] 232 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop7` [INFO] [stderr] --> src/diff.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | / 'loop7: loop { [INFO] [stderr] 235 | | if !(i > 0isize) { [INFO] [stderr] 236 | | break; [INFO] [stderr] 237 | | } [INFO] [stderr] 238 | | buckets[i as (usize)] = buckets[(i - 1isize) as (usize)]; [INFO] [stderr] 239 | | i = i - 1isize; [INFO] [stderr] 240 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop15` [INFO] [stderr] --> src/diff.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | / 'loop15: loop { [INFO] [stderr] 278 | | if !(*I.offset(0isize) != -(oldsize + 1isize)) { [INFO] [stderr] 279 | | break; [INFO] [stderr] 280 | | } [INFO] [stderr] ... | [INFO] [stderr] 303 | | h = h + h; [INFO] [stderr] 304 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop13` [INFO] [stderr] --> src/diff.rs:266:5 [INFO] [stderr] | [INFO] [stderr] 266 | / 'loop13: loop { [INFO] [stderr] 267 | | if !(i < 256isize) { [INFO] [stderr] 268 | | break; [INFO] [stderr] 269 | | } [INFO] [stderr] ... | [INFO] [stderr] 273 | | i = i + 1isize; [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop9` [INFO] [stderr] --> src/diff.rs:243:5 [INFO] [stderr] | [INFO] [stderr] 243 | / 'loop9: loop { [INFO] [stderr] 244 | | if !(i < oldsize) { [INFO] [stderr] 245 | | break; [INFO] [stderr] 246 | | } [INFO] [stderr] ... | [INFO] [stderr] 253 | | i = i + 1isize; [INFO] [stderr] 254 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop1` [INFO] [stderr] --> src/diff.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | / 'loop1: loop { [INFO] [stderr] 207 | | if !(i < 256isize) { [INFO] [stderr] 208 | | break; [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | buckets[i as (usize)] = 0isize; [INFO] [stderr] 211 | | i = i + 1isize; [INFO] [stderr] 212 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop3` [INFO] [stderr] --> src/diff.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | / 'loop3: loop { [INFO] [stderr] 215 | | if !(i < oldsize) { [INFO] [stderr] 216 | | break; [INFO] [stderr] 217 | | } [INFO] [stderr] ... | [INFO] [stderr] 221 | | i = i + 1isize; [INFO] [stderr] 222 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop22` [INFO] [stderr] --> src/diff.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | / 'loop22: loop { [INFO] [stderr] 284 | | if !(i < oldsize + 1isize) { [INFO] [stderr] 285 | | break; [INFO] [stderr] 286 | | } [INFO] [stderr] ... | [INFO] [stderr] 298 | | } [INFO] [stderr] 299 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | *_lhs = *_lhs + _rhs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:239:9 [INFO] [stderr] | [INFO] [stderr] 239 | i = i - 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i -= 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:250:23 [INFO] [stderr] | [INFO] [stderr] 250 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:288:17 [INFO] [stderr] | [INFO] [stderr] 288 | len = len - *I.offset(i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `len -= *I.offset(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:296:17 [INFO] [stderr] | [INFO] [stderr] 296 | i = i + len; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `i += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop1` [INFO] [stderr] --> src/diff.rs:322:5 [INFO] [stderr] | [INFO] [stderr] 322 | / 'loop1: loop { [INFO] [stderr] 323 | | if !(i < oldsize && (i < newsize)) { [INFO] [stderr] 324 | | break; [INFO] [stderr] 325 | | } [INFO] [stderr] ... | [INFO] [stderr] 329 | | i = i + 1isize; [INFO] [stderr] 330 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:326:12 [INFO] [stderr] | [INFO] [stderr] 326 | if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*old.offset(i))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:326:39 [INFO] [stderr] | [INFO] [stderr] 326 | if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*new.offset(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/diff.rs:334:1 [INFO] [stderr] | [INFO] [stderr] 334 | / unsafe fn search(mut I: *const isize, [INFO] [stderr] 335 | | mut old: *const u8, [INFO] [stderr] 336 | | mut oldsize: isize, [INFO] [stderr] 337 | | mut new: *const u8, [INFO] [stderr] ... | [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/diff.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | / let mut y: isize; [INFO] [stderr] 379 | | if x < 0isize { [INFO] [stderr] 380 | | y = -x; [INFO] [stderr] 381 | | } else { [INFO] [stderr] 382 | | y = x; [INFO] [stderr] 383 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let y = if x < 0isize { -x } else { x };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:385:5 [INFO] [stderr] | [INFO] [stderr] 385 | y = y - *buf.offset(0isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(0isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:386:5 [INFO] [stderr] | [INFO] [stderr] 386 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:388:5 [INFO] [stderr] | [INFO] [stderr] 388 | y = y - *buf.offset(1isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(1isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:389:5 [INFO] [stderr] | [INFO] [stderr] 389 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:391:5 [INFO] [stderr] | [INFO] [stderr] 391 | y = y - *buf.offset(2isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(2isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:392:5 [INFO] [stderr] | [INFO] [stderr] 392 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:394:5 [INFO] [stderr] | [INFO] [stderr] 394 | y = y - *buf.offset(3isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(3isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:395:5 [INFO] [stderr] | [INFO] [stderr] 395 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:397:5 [INFO] [stderr] | [INFO] [stderr] 397 | y = y - *buf.offset(4isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(4isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:398:5 [INFO] [stderr] | [INFO] [stderr] 398 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:400:5 [INFO] [stderr] | [INFO] [stderr] 400 | y = y - *buf.offset(5isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(5isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:401:5 [INFO] [stderr] | [INFO] [stderr] 401 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:403:5 [INFO] [stderr] | [INFO] [stderr] 403 | y = y - *buf.offset(6isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(6isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:404:5 [INFO] [stderr] | [INFO] [stderr] 404 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:409:18 [INFO] [stderr] | [INFO] [stderr] 409 | *_lhs = (*_lhs as (i32) | _rhs) as (u8); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(*_lhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:472:12 [INFO] [stderr] | [INFO] [stderr] 472 | if !(scan < req.newsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `scan >= req.newsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:481:16 [INFO] [stderr] | [INFO] [stderr] 481 | if !(scan < req.newsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `scan >= req.newsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:493:20 [INFO] [stderr] | [INFO] [stderr] 493 | if !(scsc < scan + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `scsc >= scan + len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:527:16 [INFO] [stderr] | [INFO] [stderr] 527 | if !(s * 2isize - i > Sf * 2isize - lenf) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s * 2isize - i <= Sf * 2isize - lenf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:559:20 [INFO] [stderr] | [INFO] [stderr] 559 | if !(i < overlap) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= overlap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:589:16 [INFO] [stderr] | [INFO] [stderr] 589 | if !(i < lenf) { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i >= lenf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:600:16 [INFO] [stderr] | [INFO] [stderr] 600 | if !(i < scan - lenb - (lastscan + lenf)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i >= scan - lenb - (lastscan + lenf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop17` [INFO] [stderr] --> src/diff.rs:538:13 [INFO] [stderr] | [INFO] [stderr] 538 | / 'loop17: loop { [INFO] [stderr] 539 | | if !(scan >= lastscan + i && (pos >= i)) { [INFO] [stderr] 540 | | break; [INFO] [stderr] 541 | | } [INFO] [stderr] ... | [INFO] [stderr] 549 | | i = i + 1isize; [INFO] [stderr] 550 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop5` [INFO] [stderr] --> src/diff.rs:480:9 [INFO] [stderr] | [INFO] [stderr] 480 | / 'loop5: loop { [INFO] [stderr] 481 | | if !(scan < req.newsize) { [INFO] [stderr] 482 | | break; [INFO] [stderr] 483 | | } [INFO] [stderr] ... | [INFO] [stderr] 510 | | scan = scan + 1isize; [INFO] [stderr] 511 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop7` [INFO] [stderr] --> src/diff.rs:492:13 [INFO] [stderr] | [INFO] [stderr] 492 | / 'loop7: loop { [INFO] [stderr] 493 | | if !(scsc < scan + len) { [INFO] [stderr] 494 | | break; [INFO] [stderr] 495 | | } [INFO] [stderr] ... | [INFO] [stderr] 501 | | scsc = scsc + 1isize; [INFO] [stderr] 502 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop20` [INFO] [stderr] --> src/diff.rs:558:13 [INFO] [stderr] | [INFO] [stderr] 558 | / 'loop20: loop { [INFO] [stderr] 559 | | if !(i < overlap) { [INFO] [stderr] 560 | | break; [INFO] [stderr] 561 | | } [INFO] [stderr] ... | [INFO] [stderr] 574 | | i = i + 1isize; [INFO] [stderr] 575 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop2` [INFO] [stderr] --> src/diff.rs:471:5 [INFO] [stderr] | [INFO] [stderr] 471 | / 'loop2: loop { [INFO] [stderr] 472 | | if !(scan < req.newsize) { [INFO] [stderr] 473 | | break; [INFO] [stderr] 474 | | } [INFO] [stderr] ... | [INFO] [stderr] 612 | | lastoffset = pos - scan; [INFO] [stderr] 613 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop27` [INFO] [stderr] --> src/diff.rs:599:9 [INFO] [stderr] | [INFO] [stderr] 599 | / 'loop27: loop { [INFO] [stderr] 600 | | if !(i < scan - lenb - (lastscan + lenf)) { [INFO] [stderr] 601 | | break; [INFO] [stderr] 602 | | } [INFO] [stderr] 603 | | *buffer.offset(i) = *req.new.offset(lastscan + lenf + i); [INFO] [stderr] 604 | | i = i + 1isize; [INFO] [stderr] 605 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop14` [INFO] [stderr] --> src/diff.rs:519:9 [INFO] [stderr] | [INFO] [stderr] 519 | / 'loop14: loop { [INFO] [stderr] 520 | | if !(lastscan + i < scan && (lastpos + i < req.oldsize)) { [INFO] [stderr] 521 | | break; [INFO] [stderr] 522 | | } [INFO] [stderr] ... | [INFO] [stderr] 531 | | lenf = i; [INFO] [stderr] 532 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop24` [INFO] [stderr] --> src/diff.rs:588:9 [INFO] [stderr] | [INFO] [stderr] 588 | / 'loop24: loop { [INFO] [stderr] 589 | | if !(i < lenf) { [INFO] [stderr] 590 | | break; [INFO] [stderr] 591 | | } [INFO] [stderr] ... | [INFO] [stderr] 595 | | i = i + 1isize; [INFO] [stderr] 596 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/diff.rs:458:8 [INFO] [stderr] | [INFO] [stderr] 458 | if V == ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:477:13 [INFO] [stderr] | [INFO] [stderr] 477 | scan = scan + len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `scan += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:497:22 [INFO] [stderr] | [INFO] [stderr] 497 | (*req.old.offset(scsc + lastoffset) as (i32) == [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(scsc + lastoffset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:498:21 [INFO] [stderr] | [INFO] [stderr] 498 | *req.new.offset(scsc) as (i32)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scsc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:499:21 [INFO] [stderr] | [INFO] [stderr] 499 | oldscore = oldscore + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oldscore += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:501:17 [INFO] [stderr] | [INFO] [stderr] 501 | scsc = scsc + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scsc += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:507:18 [INFO] [stderr] | [INFO] [stderr] 507 | (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(scan + lastoffset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:507:65 [INFO] [stderr] | [INFO] [stderr] 507 | (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scan))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:508:17 [INFO] [stderr] | [INFO] [stderr] 508 | oldscore = oldscore - 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oldscore -= 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:510:13 [INFO] [stderr] | [INFO] [stderr] 510 | scan = scan + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scan += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:523:16 [INFO] [stderr] | [INFO] [stderr] 523 | if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(lastpos + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:523:57 [INFO] [stderr] | [INFO] [stderr] 523 | if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(lastscan + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:524:17 [INFO] [stderr] | [INFO] [stderr] 524 | s = s + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:526:13 [INFO] [stderr] | [INFO] [stderr] 526 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:542:20 [INFO] [stderr] | [INFO] [stderr] 542 | if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(pos - i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:542:57 [INFO] [stderr] | [INFO] [stderr] 542 | if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scan - i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:543:21 [INFO] [stderr] | [INFO] [stderr] 543 | s = s + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:549:17 [INFO] [stderr] | [INFO] [stderr] 549 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:562:20 [INFO] [stderr] | [INFO] [stderr] 562 | if *req.new.offset(lastscan + lenf - overlap + i) as (i32) == [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(lastscan + lenf - overlap + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:563:21 [INFO] [stderr] | [INFO] [stderr] 563 | *req.old.offset(lastpos + lenf - overlap + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(lastpos + lenf - overlap + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:564:21 [INFO] [stderr] | [INFO] [stderr] 564 | s = s + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:566:20 [INFO] [stderr] | [INFO] [stderr] 566 | if *req.new.offset(scan - lenb + i) as (i32) == [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scan - lenb + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:567:21 [INFO] [stderr] | [INFO] [stderr] 567 | *req.old.offset(pos - lenb + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(pos - lenb + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:568:21 [INFO] [stderr] | [INFO] [stderr] 568 | s = s - 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s -= 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:574:17 [INFO] [stderr] | [INFO] [stderr] 574 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | lenf = lenf + (lens - overlap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lenf += (lens - overlap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:577:13 [INFO] [stderr] | [INFO] [stderr] 577 | lenb = lenb - lens; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lenb -= lens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:592:34 [INFO] [stderr] | [INFO] [stderr] 592 | *buffer.offset(i) = (*req.new.offset(lastscan + i) as (i32) - [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(lastscan + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:593:37 [INFO] [stderr] | [INFO] [stderr] 593 | *req.old.offset(lastpos + i) as (i32)) as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(lastpos + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:595:13 [INFO] [stderr] | [INFO] [stderr] 595 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:604:13 [INFO] [stderr] | [INFO] [stderr] 604 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `ctrl`. [INFO] [stderr] --> src/patch.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 46 | for in &mut ctrl { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buf[7] as (i32) & 0x7Fi32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:91:10 [INFO] [stderr] | [INFO] [stderr] 91 | y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | y = y + buf[6] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[6] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | y = y + buf[6] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | y = y + buf[5] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[5] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | y = y + buf[5] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | y = y + buf[4] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[4] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | y = y + buf[4] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | y = y + buf[3] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[3] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | y = y + buf[3] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | y = y + buf[2] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[2] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | y = y + buf[2] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | y = y + buf[1] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[1] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | y = y + buf[1] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | y = y + buf[0] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[0] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | y = y + buf[0] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:106:8 [INFO] [stderr] | [INFO] [stderr] 106 | if buf[7] as (i32) & 0x80i32 != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/diff.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | if I == ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/diff.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | if buffer == ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:92:16 [INFO] [stderr] | [INFO] [stderr] 92 | if !(k < start + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `k >= start + len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | if !(k + i < start + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `k + i >= start + len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:116:20 [INFO] [stderr] | [INFO] [stderr] 116 | if !(i < j) { [INFO] [stderr] | ^^^^^^^^ help: try: `i >= j` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:133:16 [INFO] [stderr] | [INFO] [stderr] 133 | if !(i < start + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i >= start + len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:150:16 [INFO] [stderr] | [INFO] [stderr] 150 | if !(i < jj) { [INFO] [stderr] | ^^^^^^^^^ help: try: `i >= jj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:168:16 [INFO] [stderr] | [INFO] [stderr] 168 | if !(jj + j < kk) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `jj + j >= kk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:185:16 [INFO] [stderr] | [INFO] [stderr] 185 | if !(i < kk - jj) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= kk - jj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop5` [INFO] [stderr] --> src/diff.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / 'loop5: loop { [INFO] [stderr] 168 | | if !(jj + j < kk) { [INFO] [stderr] 169 | | break; [INFO] [stderr] 170 | | } [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop2` [INFO] [stderr] --> src/diff.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | / 'loop2: loop { [INFO] [stderr] 133 | | if !(i < start + len) { [INFO] [stderr] 134 | | break; [INFO] [stderr] 135 | | } [INFO] [stderr] ... | [INFO] [stderr] 142 | | i = i + 1isize; [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop9` [INFO] [stderr] --> src/diff.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | / 'loop9: loop { [INFO] [stderr] 185 | | if !(i < kk - jj) { [INFO] [stderr] 186 | | break; [INFO] [stderr] 187 | | } [INFO] [stderr] 188 | | *V.offset(*I.offset(jj + i)) = kk - 1isize; [INFO] [stderr] 189 | | i = i + 1isize; [INFO] [stderr] 190 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop34` [INFO] [stderr] --> src/diff.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | / 'loop34: loop { [INFO] [stderr] 99 | | if !(k + i < start + len) { [INFO] [stderr] 100 | | break; [INFO] [stderr] 101 | | } [INFO] [stderr] ... | [INFO] [stderr] 112 | | i = i + 1isize; [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop36` [INFO] [stderr] --> src/diff.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | / 'loop36: loop { [INFO] [stderr] 116 | | if !(i < j) { [INFO] [stderr] 117 | | break; [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | *V.offset(*I.offset(k + i)) = k + j - 1isize; [INFO] [stderr] 120 | | i = i + 1isize; [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop4` [INFO] [stderr] --> src/diff.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | / 'loop4: loop { [INFO] [stderr] 150 | | if !(i < jj) { [INFO] [stderr] 151 | | break; [INFO] [stderr] 152 | | } [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop31` [INFO] [stderr] --> src/diff.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / 'loop31: loop { [INFO] [stderr] 92 | | if !(k < start + len) { [INFO] [stderr] 93 | | break; [INFO] [stderr] 94 | | } [INFO] [stderr] ... | [INFO] [stderr] 125 | | k = k + j; [INFO] [stderr] 126 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:110:21 [INFO] [stderr] | [INFO] [stderr] 110 | j = j + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | k = k + j; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `k += j` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | jj = jj + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `jj += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | kk = kk + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `kk += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | jj = jj + start; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `jj += start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | kk = kk + jj; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `kk += jj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | j = j + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | k = k + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `k += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | j = j + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | k = k + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `k += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:207:12 [INFO] [stderr] | [INFO] [stderr] 207 | if !(i < 256isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i >= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:215:12 [INFO] [stderr] | [INFO] [stderr] 215 | if !(i < oldsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= oldsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:225:12 [INFO] [stderr] | [INFO] [stderr] 225 | if !(i < 256isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i >= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:235:12 [INFO] [stderr] | [INFO] [stderr] 235 | if !(i > 0isize) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i <= 0isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:244:12 [INFO] [stderr] | [INFO] [stderr] 244 | if !(i < oldsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= oldsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:258:12 [INFO] [stderr] | [INFO] [stderr] 258 | if !(i < oldsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= oldsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:267:12 [INFO] [stderr] | [INFO] [stderr] 267 | if !(i < 256isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i >= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:278:12 [INFO] [stderr] | [INFO] [stderr] 278 | if !(*I.offset(0isize) != -(oldsize + 1isize)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*I.offset(0isize) == -(oldsize + 1isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:284:16 [INFO] [stderr] | [INFO] [stderr] 284 | if !(i < oldsize + 1isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i >= oldsize + 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:307:12 [INFO] [stderr] | [INFO] [stderr] 307 | if !(i < oldsize + 1isize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i >= oldsize + 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop17` [INFO] [stderr] --> src/diff.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | / 'loop17: loop { [INFO] [stderr] 307 | | if !(i < oldsize + 1isize) { [INFO] [stderr] 308 | | break; [INFO] [stderr] 309 | | } [INFO] [stderr] 310 | | *I.offset(*V.offset(i)) = i; [INFO] [stderr] 311 | | i = i + 1isize; [INFO] [stderr] 312 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop11` [INFO] [stderr] --> src/diff.rs:257:5 [INFO] [stderr] | [INFO] [stderr] 257 | / 'loop11: loop { [INFO] [stderr] 258 | | if !(i < oldsize) { [INFO] [stderr] 259 | | break; [INFO] [stderr] 260 | | } [INFO] [stderr] 261 | | *V.offset(i) = buckets[*old.offset(i) as (usize)]; [INFO] [stderr] 262 | | i = i + 1isize; [INFO] [stderr] 263 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop5` [INFO] [stderr] --> src/diff.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | / 'loop5: loop { [INFO] [stderr] 225 | | if !(i < 256isize) { [INFO] [stderr] 226 | | break; [INFO] [stderr] 227 | | } [INFO] [stderr] ... | [INFO] [stderr] 231 | | i = i + 1isize; [INFO] [stderr] 232 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop7` [INFO] [stderr] --> src/diff.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | / 'loop7: loop { [INFO] [stderr] 235 | | if !(i > 0isize) { [INFO] [stderr] 236 | | break; [INFO] [stderr] 237 | | } [INFO] [stderr] 238 | | buckets[i as (usize)] = buckets[(i - 1isize) as (usize)]; [INFO] [stderr] 239 | | i = i - 1isize; [INFO] [stderr] 240 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop15` [INFO] [stderr] --> src/diff.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | / 'loop15: loop { [INFO] [stderr] 278 | | if !(*I.offset(0isize) != -(oldsize + 1isize)) { [INFO] [stderr] 279 | | break; [INFO] [stderr] 280 | | } [INFO] [stderr] ... | [INFO] [stderr] 303 | | h = h + h; [INFO] [stderr] 304 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop13` [INFO] [stderr] --> src/diff.rs:266:5 [INFO] [stderr] | [INFO] [stderr] 266 | / 'loop13: loop { [INFO] [stderr] 267 | | if !(i < 256isize) { [INFO] [stderr] 268 | | break; [INFO] [stderr] 269 | | } [INFO] [stderr] ... | [INFO] [stderr] 273 | | i = i + 1isize; [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop9` [INFO] [stderr] --> src/diff.rs:243:5 [INFO] [stderr] | [INFO] [stderr] 243 | / 'loop9: loop { [INFO] [stderr] 244 | | if !(i < oldsize) { [INFO] [stderr] 245 | | break; [INFO] [stderr] 246 | | } [INFO] [stderr] ... | [INFO] [stderr] 253 | | i = i + 1isize; [INFO] [stderr] 254 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop1` [INFO] [stderr] --> src/diff.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | / 'loop1: loop { [INFO] [stderr] 207 | | if !(i < 256isize) { [INFO] [stderr] 208 | | break; [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | buckets[i as (usize)] = 0isize; [INFO] [stderr] 211 | | i = i + 1isize; [INFO] [stderr] 212 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop3` [INFO] [stderr] --> src/diff.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | / 'loop3: loop { [INFO] [stderr] 215 | | if !(i < oldsize) { [INFO] [stderr] 216 | | break; [INFO] [stderr] 217 | | } [INFO] [stderr] ... | [INFO] [stderr] 221 | | i = i + 1isize; [INFO] [stderr] 222 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop22` [INFO] [stderr] --> src/diff.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | / 'loop22: loop { [INFO] [stderr] 284 | | if !(i < oldsize + 1isize) { [INFO] [stderr] 285 | | break; [INFO] [stderr] 286 | | } [INFO] [stderr] ... | [INFO] [stderr] 298 | | } [INFO] [stderr] 299 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | *_lhs = *_lhs + _rhs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:239:9 [INFO] [stderr] | [INFO] [stderr] 239 | i = i - 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i -= 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:250:23 [INFO] [stderr] | [INFO] [stderr] 250 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:288:17 [INFO] [stderr] | [INFO] [stderr] 288 | len = len - *I.offset(i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `len -= *I.offset(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:296:17 [INFO] [stderr] | [INFO] [stderr] 296 | i = i + len; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `i += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop1` [INFO] [stderr] --> src/diff.rs:322:5 [INFO] [stderr] | [INFO] [stderr] 322 | / 'loop1: loop { [INFO] [stderr] 323 | | if !(i < oldsize && (i < newsize)) { [INFO] [stderr] 324 | | break; [INFO] [stderr] 325 | | } [INFO] [stderr] ... | [INFO] [stderr] 329 | | i = i + 1isize; [INFO] [stderr] 330 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:326:12 [INFO] [stderr] | [INFO] [stderr] 326 | if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*old.offset(i))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:326:39 [INFO] [stderr] | [INFO] [stderr] 326 | if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*new.offset(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/diff.rs:334:1 [INFO] [stderr] | [INFO] [stderr] 334 | / unsafe fn search(mut I: *const isize, [INFO] [stderr] 335 | | mut old: *const u8, [INFO] [stderr] 336 | | mut oldsize: isize, [INFO] [stderr] 337 | | mut new: *const u8, [INFO] [stderr] ... | [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/diff.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | / let mut y: isize; [INFO] [stderr] 379 | | if x < 0isize { [INFO] [stderr] 380 | | y = -x; [INFO] [stderr] 381 | | } else { [INFO] [stderr] 382 | | y = x; [INFO] [stderr] 383 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let y = if x < 0isize { -x } else { x };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:385:5 [INFO] [stderr] | [INFO] [stderr] 385 | y = y - *buf.offset(0isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(0isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:386:5 [INFO] [stderr] | [INFO] [stderr] 386 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:388:5 [INFO] [stderr] | [INFO] [stderr] 388 | y = y - *buf.offset(1isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(1isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:389:5 [INFO] [stderr] | [INFO] [stderr] 389 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:391:5 [INFO] [stderr] | [INFO] [stderr] 391 | y = y - *buf.offset(2isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(2isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:392:5 [INFO] [stderr] | [INFO] [stderr] 392 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:394:5 [INFO] [stderr] | [INFO] [stderr] 394 | y = y - *buf.offset(3isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(3isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:395:5 [INFO] [stderr] | [INFO] [stderr] 395 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:397:5 [INFO] [stderr] | [INFO] [stderr] 397 | y = y - *buf.offset(4isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(4isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:398:5 [INFO] [stderr] | [INFO] [stderr] 398 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:400:5 [INFO] [stderr] | [INFO] [stderr] 400 | y = y - *buf.offset(5isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(5isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:401:5 [INFO] [stderr] | [INFO] [stderr] 401 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:403:5 [INFO] [stderr] | [INFO] [stderr] 403 | y = y - *buf.offset(6isize) as (isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(6isize) as (isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:404:5 [INFO] [stderr] | [INFO] [stderr] 404 | y = y / 256isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:409:18 [INFO] [stderr] | [INFO] [stderr] 409 | *_lhs = (*_lhs as (i32) | _rhs) as (u8); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(*_lhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:472:12 [INFO] [stderr] | [INFO] [stderr] 472 | if !(scan < req.newsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `scan >= req.newsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:481:16 [INFO] [stderr] | [INFO] [stderr] 481 | if !(scan < req.newsize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `scan >= req.newsize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:493:20 [INFO] [stderr] | [INFO] [stderr] 493 | if !(scsc < scan + len) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `scsc >= scan + len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:527:16 [INFO] [stderr] | [INFO] [stderr] 527 | if !(s * 2isize - i > Sf * 2isize - lenf) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s * 2isize - i <= Sf * 2isize - lenf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:559:20 [INFO] [stderr] | [INFO] [stderr] 559 | if !(i < overlap) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i >= overlap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:589:16 [INFO] [stderr] | [INFO] [stderr] 589 | if !(i < lenf) { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i >= lenf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/diff.rs:600:16 [INFO] [stderr] | [INFO] [stderr] 600 | if !(i < scan - lenb - (lastscan + lenf)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i >= scan - lenb - (lastscan + lenf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop17` [INFO] [stderr] --> src/diff.rs:538:13 [INFO] [stderr] | [INFO] [stderr] 538 | / 'loop17: loop { [INFO] [stderr] 539 | | if !(scan >= lastscan + i && (pos >= i)) { [INFO] [stderr] 540 | | break; [INFO] [stderr] 541 | | } [INFO] [stderr] ... | [INFO] [stderr] 549 | | i = i + 1isize; [INFO] [stderr] 550 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop5` [INFO] [stderr] --> src/diff.rs:480:9 [INFO] [stderr] | [INFO] [stderr] 480 | / 'loop5: loop { [INFO] [stderr] 481 | | if !(scan < req.newsize) { [INFO] [stderr] 482 | | break; [INFO] [stderr] 483 | | } [INFO] [stderr] ... | [INFO] [stderr] 510 | | scan = scan + 1isize; [INFO] [stderr] 511 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop7` [INFO] [stderr] --> src/diff.rs:492:13 [INFO] [stderr] | [INFO] [stderr] 492 | / 'loop7: loop { [INFO] [stderr] 493 | | if !(scsc < scan + len) { [INFO] [stderr] 494 | | break; [INFO] [stderr] 495 | | } [INFO] [stderr] ... | [INFO] [stderr] 501 | | scsc = scsc + 1isize; [INFO] [stderr] 502 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop20` [INFO] [stderr] --> src/diff.rs:558:13 [INFO] [stderr] | [INFO] [stderr] 558 | / 'loop20: loop { [INFO] [stderr] 559 | | if !(i < overlap) { [INFO] [stderr] 560 | | break; [INFO] [stderr] 561 | | } [INFO] [stderr] ... | [INFO] [stderr] 574 | | i = i + 1isize; [INFO] [stderr] 575 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop2` [INFO] [stderr] --> src/diff.rs:471:5 [INFO] [stderr] | [INFO] [stderr] 471 | / 'loop2: loop { [INFO] [stderr] 472 | | if !(scan < req.newsize) { [INFO] [stderr] 473 | | break; [INFO] [stderr] 474 | | } [INFO] [stderr] ... | [INFO] [stderr] 612 | | lastoffset = pos - scan; [INFO] [stderr] 613 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop27` [INFO] [stderr] --> src/diff.rs:599:9 [INFO] [stderr] | [INFO] [stderr] 599 | / 'loop27: loop { [INFO] [stderr] 600 | | if !(i < scan - lenb - (lastscan + lenf)) { [INFO] [stderr] 601 | | break; [INFO] [stderr] 602 | | } [INFO] [stderr] 603 | | *buffer.offset(i) = *req.new.offset(lastscan + lenf + i); [INFO] [stderr] 604 | | i = i + 1isize; [INFO] [stderr] 605 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop14` [INFO] [stderr] --> src/diff.rs:519:9 [INFO] [stderr] | [INFO] [stderr] 519 | / 'loop14: loop { [INFO] [stderr] 520 | | if !(lastscan + i < scan && (lastpos + i < req.oldsize)) { [INFO] [stderr] 521 | | break; [INFO] [stderr] 522 | | } [INFO] [stderr] ... | [INFO] [stderr] 531 | | lenf = i; [INFO] [stderr] 532 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'loop24` [INFO] [stderr] --> src/diff.rs:588:9 [INFO] [stderr] | [INFO] [stderr] 588 | / 'loop24: loop { [INFO] [stderr] 589 | | if !(i < lenf) { [INFO] [stderr] 590 | | break; [INFO] [stderr] 591 | | } [INFO] [stderr] ... | [INFO] [stderr] 595 | | i = i + 1isize; [INFO] [stderr] 596 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/diff.rs:458:8 [INFO] [stderr] | [INFO] [stderr] 458 | if V == ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:477:13 [INFO] [stderr] | [INFO] [stderr] 477 | scan = scan + len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `scan += len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:497:22 [INFO] [stderr] | [INFO] [stderr] 497 | (*req.old.offset(scsc + lastoffset) as (i32) == [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(scsc + lastoffset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:498:21 [INFO] [stderr] | [INFO] [stderr] 498 | *req.new.offset(scsc) as (i32)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scsc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:499:21 [INFO] [stderr] | [INFO] [stderr] 499 | oldscore = oldscore + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oldscore += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:501:17 [INFO] [stderr] | [INFO] [stderr] 501 | scsc = scsc + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scsc += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:507:18 [INFO] [stderr] | [INFO] [stderr] 507 | (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(scan + lastoffset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:507:65 [INFO] [stderr] | [INFO] [stderr] 507 | (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scan))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:508:17 [INFO] [stderr] | [INFO] [stderr] 508 | oldscore = oldscore - 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oldscore -= 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:510:13 [INFO] [stderr] | [INFO] [stderr] 510 | scan = scan + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scan += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:523:16 [INFO] [stderr] | [INFO] [stderr] 523 | if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(lastpos + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:523:57 [INFO] [stderr] | [INFO] [stderr] 523 | if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(lastscan + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:524:17 [INFO] [stderr] | [INFO] [stderr] 524 | s = s + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:526:13 [INFO] [stderr] | [INFO] [stderr] 526 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:542:20 [INFO] [stderr] | [INFO] [stderr] 542 | if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(pos - i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:542:57 [INFO] [stderr] | [INFO] [stderr] 542 | if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scan - i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:543:21 [INFO] [stderr] | [INFO] [stderr] 543 | s = s + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:549:17 [INFO] [stderr] | [INFO] [stderr] 549 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:562:20 [INFO] [stderr] | [INFO] [stderr] 562 | if *req.new.offset(lastscan + lenf - overlap + i) as (i32) == [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(lastscan + lenf - overlap + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:563:21 [INFO] [stderr] | [INFO] [stderr] 563 | *req.old.offset(lastpos + lenf - overlap + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(lastpos + lenf - overlap + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:564:21 [INFO] [stderr] | [INFO] [stderr] 564 | s = s + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:566:20 [INFO] [stderr] | [INFO] [stderr] 566 | if *req.new.offset(scan - lenb + i) as (i32) == [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(scan - lenb + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:567:21 [INFO] [stderr] | [INFO] [stderr] 567 | *req.old.offset(pos - lenb + i) as (i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(pos - lenb + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:568:21 [INFO] [stderr] | [INFO] [stderr] 568 | s = s - 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s -= 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:574:17 [INFO] [stderr] | [INFO] [stderr] 574 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | lenf = lenf + (lens - overlap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lenf += (lens - overlap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:577:13 [INFO] [stderr] | [INFO] [stderr] 577 | lenb = lenb - lens; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lenb -= lens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:592:34 [INFO] [stderr] | [INFO] [stderr] 592 | *buffer.offset(i) = (*req.new.offset(lastscan + i) as (i32) - [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.new.offset(lastscan + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/diff.rs:593:37 [INFO] [stderr] | [INFO] [stderr] 593 | *req.old.offset(lastpos + i) as (i32)) as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*req.old.offset(lastpos + i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:595:13 [INFO] [stderr] | [INFO] [stderr] 595 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diff.rs:604:13 [INFO] [stderr] | [INFO] [stderr] 604 | i = i + 1isize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `ctrl`. [INFO] [stderr] --> src/patch.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 46 | for in &mut ctrl { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buf[7] as (i32) & 0x7Fi32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:91:10 [INFO] [stderr] | [INFO] [stderr] 91 | y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | y = y + buf[6] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[6] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | y = y + buf[6] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | y = y + buf[5] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[5] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | y = y + buf[5] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | y = y + buf[4] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[4] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | y = y + buf[4] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | y = y + buf[3] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[3] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | y = y + buf[3] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | y = y + buf[2] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[2] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | y = y + buf[2] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | y = y + buf[1] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[1] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | y = y + buf[1] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | y = y * 256; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/patch.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | y = y + buf[0] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[0] as (i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | y = y + buf[0] as (i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/patch.rs:106:8 [INFO] [stderr] | [INFO] [stderr] 106 | if buf[7] as (i32) & 0x80i32 != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.49s [INFO] running `"docker" "inspect" "d90e53d658aa1be16ee6a5244067df7341ebe0d68548dec314f9f9e7f301521e"` [INFO] running `"docker" "rm" "-f" "d90e53d658aa1be16ee6a5244067df7341ebe0d68548dec314f9f9e7f301521e"` [INFO] [stdout] d90e53d658aa1be16ee6a5244067df7341ebe0d68548dec314f9f9e7f301521e