[INFO] updating cached repository Ophirr33/calculator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Ophirr33/calculator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Ophirr33/calculator" "work/ex/clippy-test-run/sources/stable/gh/Ophirr33/calculator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ophirr33/calculator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Ophirr33/calculator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ophirr33/calculator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ophirr33/calculator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a96cecf31fc1971434e095189cce477e24633101 [INFO] sha for GitHub repo Ophirr33/calculator: a96cecf31fc1971434e095189cce477e24633101 [INFO] validating manifest of Ophirr33/calculator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Ophirr33/calculator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Ophirr33/calculator [INFO] finished frobbing Ophirr33/calculator [INFO] frobbed toml for Ophirr33/calculator written to work/ex/clippy-test-run/sources/stable/gh/Ophirr33/calculator/Cargo.toml [INFO] started frobbing Ophirr33/calculator [INFO] finished frobbing Ophirr33/calculator [INFO] frobbed toml for Ophirr33/calculator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ophirr33/calculator/Cargo.toml [INFO] crate Ophirr33/calculator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Ophirr33/calculator against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ophirr33/calculator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f0964a1c19478a73bc94af15e3d6e66d1a8877861a349397894291ccf8a449ad [INFO] running `"docker" "start" "-a" "f0964a1c19478a73bc94af15e3d6e66d1a8877861a349397894291ccf8a449ad"` [INFO] [stderr] Checking calculator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / match token { [INFO] [stderr] 22 | | &Token::Num(_) => 0, [INFO] [stderr] 23 | | &Token::Add | &Token::Sub => 1, [INFO] [stderr] 24 | | &Token::Mul | &Token::Div | &Token::Mod => 2, [INFO] [stderr] 25 | | &Token::Exp | &Token::Log => 3, [INFO] [stderr] 26 | | &Token::Left | &Token::Right => 4 [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *token { [INFO] [stderr] 22 | Token::Num(_) => 0, [INFO] [stderr] 23 | Token::Add | Token::Sub => 1, [INFO] [stderr] 24 | Token::Mul | Token::Div | Token::Mod => 2, [INFO] [stderr] 25 | Token::Exp | Token::Log => 3, [INFO] [stderr] 26 | Token::Left | Token::Right => 4 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | / match io::stdout().flush() { [INFO] [stderr] 185 | | Err(e) => println!("{}", e), [INFO] [stderr] 186 | | _ => () [INFO] [stderr] 187 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = io::stdout().flush() { println!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / match token { [INFO] [stderr] 22 | | &Token::Num(_) => 0, [INFO] [stderr] 23 | | &Token::Add | &Token::Sub => 1, [INFO] [stderr] 24 | | &Token::Mul | &Token::Div | &Token::Mod => 2, [INFO] [stderr] 25 | | &Token::Exp | &Token::Log => 3, [INFO] [stderr] 26 | | &Token::Left | &Token::Right => 4 [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *token { [INFO] [stderr] 22 | Token::Num(_) => 0, [INFO] [stderr] 23 | Token::Add | Token::Sub => 1, [INFO] [stderr] 24 | Token::Mul | Token::Div | Token::Mod => 2, [INFO] [stderr] 25 | Token::Exp | Token::Log => 3, [INFO] [stderr] 26 | Token::Left | Token::Right => 4 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | / match io::stdout().flush() { [INFO] [stderr] 185 | | Err(e) => println!("{}", e), [INFO] [stderr] 186 | | _ => () [INFO] [stderr] 187 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = io::stdout().flush() { println!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.46s [INFO] running `"docker" "inspect" "f0964a1c19478a73bc94af15e3d6e66d1a8877861a349397894291ccf8a449ad"` [INFO] running `"docker" "rm" "-f" "f0964a1c19478a73bc94af15e3d6e66d1a8877861a349397894291ccf8a449ad"` [INFO] [stdout] f0964a1c19478a73bc94af15e3d6e66d1a8877861a349397894291ccf8a449ad