[INFO] updating cached repository OneMoreByte/qm-method-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/OneMoreByte/qm-method-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/OneMoreByte/qm-method-rs" "work/ex/clippy-test-run/sources/stable/gh/OneMoreByte/qm-method-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/OneMoreByte/qm-method-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/OneMoreByte/qm-method-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OneMoreByte/qm-method-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OneMoreByte/qm-method-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 98cd5beb1ecafb8650baa5d23f2390813c6e505d [INFO] sha for GitHub repo OneMoreByte/qm-method-rs: 98cd5beb1ecafb8650baa5d23f2390813c6e505d [INFO] validating manifest of OneMoreByte/qm-method-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of OneMoreByte/qm-method-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing OneMoreByte/qm-method-rs [INFO] finished frobbing OneMoreByte/qm-method-rs [INFO] frobbed toml for OneMoreByte/qm-method-rs written to work/ex/clippy-test-run/sources/stable/gh/OneMoreByte/qm-method-rs/Cargo.toml [INFO] started frobbing OneMoreByte/qm-method-rs [INFO] finished frobbing OneMoreByte/qm-method-rs [INFO] frobbed toml for OneMoreByte/qm-method-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OneMoreByte/qm-method-rs/Cargo.toml [INFO] crate OneMoreByte/qm-method-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting OneMoreByte/qm-method-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/OneMoreByte/qm-method-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 435beb98297a79d5cc93ed9736304aa66db31e4c0eaf24407750d7a499e719b0 [INFO] running `"docker" "start" "-a" "435beb98297a79d5cc93ed9736304aa66db31e4c0eaf24407750d7a499e719b0"` [INFO] [stderr] Checking qm-method-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | let (x, y) = current_term.unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:430:5 [INFO] [stderr] | [INFO] [stderr] 430 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | let (x, y) = current_term.unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:430:5 [INFO] [stderr] | [INFO] [stderr] 430 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | z.binary_eqv.push((((m / (t.pow(x as u32))) % 2) as i8)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | z.binary_eqv.push((((m / (t.pow(x as u32))) % 2) as i8)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | z.binary_eqv.push((((m / (t.pow(x as u32))) % 2) as i8)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | z.binary_eqv.push((((m / (t.pow(x as u32))) % 2) as i8)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:258:16 [INFO] [stderr] | [INFO] [stderr] 258 | fn place_mterm(mut bin: &mut Vec>, m: u64, n: i8) { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:270:15 [INFO] [stderr] | [INFO] [stderr] 270 | for _x in 0..(n_terms + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=n_terms` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:301:22 [INFO] [stderr] | [INFO] [stderr] 301 | fn find_factors(bin: &Vec>, n: i8) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:326:14 [INFO] [stderr] | [INFO] [stderr] 326 | for x in 1..(n + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the variable `pos` is used as a loop counter. Consider using `for (pos, item) in graph.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:399:14 [INFO] [stderr] | [INFO] [stderr] 399 | for g in graph { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:407:12 [INFO] [stderr] | [INFO] [stderr] 407 | if g.len() > 0 && !matches { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!g.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:258:16 [INFO] [stderr] | [INFO] [stderr] 258 | fn place_mterm(mut bin: &mut Vec>, m: u64, n: i8) { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:270:15 [INFO] [stderr] | [INFO] [stderr] 270 | for _x in 0..(n_terms + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=n_terms` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:301:22 [INFO] [stderr] | [INFO] [stderr] 301 | fn find_factors(bin: &Vec>, n: i8) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:326:14 [INFO] [stderr] | [INFO] [stderr] 326 | for x in 1..(n + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the variable `pos` is used as a loop counter. Consider using `for (pos, item) in graph.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:399:14 [INFO] [stderr] | [INFO] [stderr] 399 | for g in graph { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:407:12 [INFO] [stderr] | [INFO] [stderr] 407 | if g.len() > 0 && !matches { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!g.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.90s [INFO] running `"docker" "inspect" "435beb98297a79d5cc93ed9736304aa66db31e4c0eaf24407750d7a499e719b0"` [INFO] running `"docker" "rm" "-f" "435beb98297a79d5cc93ed9736304aa66db31e4c0eaf24407750d7a499e719b0"` [INFO] [stdout] 435beb98297a79d5cc93ed9736304aa66db31e4c0eaf24407750d7a499e719b0