[INFO] updating cached repository Noxime/luze [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Noxime/luze [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Noxime/luze" "work/ex/clippy-test-run/sources/stable/gh/Noxime/luze"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Noxime/luze'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Noxime/luze" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Noxime/luze"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Noxime/luze'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7bbc55389895949b06c05ba2608b1dc94fb717a4 [INFO] sha for GitHub repo Noxime/luze: 7bbc55389895949b06c05ba2608b1dc94fb717a4 [INFO] validating manifest of Noxime/luze on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Noxime/luze on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Noxime/luze [INFO] finished frobbing Noxime/luze [INFO] frobbed toml for Noxime/luze written to work/ex/clippy-test-run/sources/stable/gh/Noxime/luze/Cargo.toml [INFO] started frobbing Noxime/luze [INFO] finished frobbing Noxime/luze [INFO] frobbed toml for Noxime/luze written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Noxime/luze/Cargo.toml [INFO] crate Noxime/luze has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Noxime/luze against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Noxime/luze:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d7fe150d8e4d6ba1a140229802633f31d69cf2012c7c414ec8ee55a81e407ab5 [INFO] running `"docker" "start" "-a" "d7fe150d8e4d6ba1a140229802633f31d69cf2012c7c414ec8ee55a81e407ab5"` [INFO] [stderr] Checking luze v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::fmt::Debug` [INFO] [stderr] --> src/tokens.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt::Debug; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tokens.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 40 | | if c == '"' { [INFO] [stderr] 41 | | quotes = true; [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 39 | } else if c == '"' { [INFO] [stderr] 40 | quotes = true; [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Debug` [INFO] [stderr] --> src/tokens.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt::Debug; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tokens.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 40 | | if c == '"' { [INFO] [stderr] 41 | | quotes = true; [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 39 | } else if c == '"' { [INFO] [stderr] 40 | quotes = true; [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tokens.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | if buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tokens.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | if buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/tokens.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | if v.chars().next() == Some('"') && v.chars().last() == Some('"') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `v.starts_with('"')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/tokens.rs:98:53 [INFO] [stderr] | [INFO] [stderr] 98 | if v.chars().next() == Some('"') && v.chars().last() == Some('"') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `v.ends_with('"')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tokens.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | if buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tokens.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | if buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/tokens.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | if v.chars().next() == Some('"') && v.chars().last() == Some('"') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `v.starts_with('"')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/tokens.rs:98:53 [INFO] [stderr] | [INFO] [stderr] 98 | if v.chars().next() == Some('"') && v.chars().last() == Some('"') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `v.ends_with('"')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "d7fe150d8e4d6ba1a140229802633f31d69cf2012c7c414ec8ee55a81e407ab5"` [INFO] running `"docker" "rm" "-f" "d7fe150d8e4d6ba1a140229802633f31d69cf2012c7c414ec8ee55a81e407ab5"` [INFO] [stdout] d7fe150d8e4d6ba1a140229802633f31d69cf2012c7c414ec8ee55a81e407ab5