[INFO] updating cached repository Noskcaj19/brainrust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Noskcaj19/brainrust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Noskcaj19/brainrust" "work/ex/clippy-test-run/sources/stable/gh/Noskcaj19/brainrust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Noskcaj19/brainrust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Noskcaj19/brainrust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Noskcaj19/brainrust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Noskcaj19/brainrust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 273f0b066022f51ef7ff01005cfbd8faa87c33fe [INFO] sha for GitHub repo Noskcaj19/brainrust: 273f0b066022f51ef7ff01005cfbd8faa87c33fe [INFO] validating manifest of Noskcaj19/brainrust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Noskcaj19/brainrust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Noskcaj19/brainrust [INFO] finished frobbing Noskcaj19/brainrust [INFO] frobbed toml for Noskcaj19/brainrust written to work/ex/clippy-test-run/sources/stable/gh/Noskcaj19/brainrust/Cargo.toml [INFO] started frobbing Noskcaj19/brainrust [INFO] finished frobbing Noskcaj19/brainrust [INFO] frobbed toml for Noskcaj19/brainrust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Noskcaj19/brainrust/Cargo.toml [INFO] crate Noskcaj19/brainrust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Noskcaj19/brainrust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Noskcaj19/brainrust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fa38224b05ed3babad83fd128d183808388c448db924242427a21d3dc937956b [INFO] running `"docker" "start" "-a" "fa38224b05ed3babad83fd128d183808388c448db924242427a21d3dc937956b"` [INFO] [stderr] Checking bf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `Write`, `stdout` [INFO] [stderr] --> src/main.rs:1:22 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{stdin, stdout, Write}; [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Write`, `stdout` [INFO] [stderr] --> src/main.rs:1:22 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{stdin, stdout, Write}; [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | fn validate(program: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[BrainCommand]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:19:88 [INFO] [stderr] | [INFO] [stderr] 19 | BrainCommand::JumpBackward(pos) | BrainCommand::JumpForward(pos) => if let None = pos { [INFO] [stderr] | _________________________________________________________________________________- ^^^^ [INFO] [stderr] 20 | | return false; [INFO] [stderr] 21 | | }, [INFO] [stderr] | |_____________- help: try this: `if pos.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:33:8 [INFO] [stderr] | [INFO] [stderr] 33 | if str_commands.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `str_commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the variable `pc` is used as a loop counter. Consider using `for (pc, item) in &str_commands.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | for command in &str_commands { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | fn interpret(program: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[BrainCommand]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:93:33 [INFO] [stderr] | [INFO] [stderr] 93 | .map(|byte| byte as i32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | fn validate(program: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[BrainCommand]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:19:88 [INFO] [stderr] | [INFO] [stderr] 19 | BrainCommand::JumpBackward(pos) | BrainCommand::JumpForward(pos) => if let None = pos { [INFO] [stderr] | _________________________________________________________________________________- ^^^^ [INFO] [stderr] 20 | | return false; [INFO] [stderr] 21 | | }, [INFO] [stderr] | |_____________- help: try this: `if pos.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:33:8 [INFO] [stderr] | [INFO] [stderr] 33 | if str_commands.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `str_commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the variable `pc` is used as a loop counter. Consider using `for (pc, item) in &str_commands.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | for command in &str_commands { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | fn interpret(program: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[BrainCommand]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:93:33 [INFO] [stderr] | [INFO] [stderr] 93 | .map(|byte| byte as i32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.59s [INFO] running `"docker" "inspect" "fa38224b05ed3babad83fd128d183808388c448db924242427a21d3dc937956b"` [INFO] running `"docker" "rm" "-f" "fa38224b05ed3babad83fd128d183808388c448db924242427a21d3dc937956b"` [INFO] [stdout] fa38224b05ed3babad83fd128d183808388c448db924242427a21d3dc937956b