[INFO] updating cached repository NishanthSpShetty/Stack-VM [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/NishanthSpShetty/Stack-VM [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/NishanthSpShetty/Stack-VM" "work/ex/clippy-test-run/sources/stable/gh/NishanthSpShetty/Stack-VM"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NishanthSpShetty/Stack-VM'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/NishanthSpShetty/Stack-VM" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NishanthSpShetty/Stack-VM"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NishanthSpShetty/Stack-VM'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 171b03b1ab3655798c0f969124f58efb1f4cb425 [INFO] sha for GitHub repo NishanthSpShetty/Stack-VM: 171b03b1ab3655798c0f969124f58efb1f4cb425 [INFO] validating manifest of NishanthSpShetty/Stack-VM on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of NishanthSpShetty/Stack-VM on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing NishanthSpShetty/Stack-VM [INFO] finished frobbing NishanthSpShetty/Stack-VM [INFO] frobbed toml for NishanthSpShetty/Stack-VM written to work/ex/clippy-test-run/sources/stable/gh/NishanthSpShetty/Stack-VM/Cargo.toml [INFO] started frobbing NishanthSpShetty/Stack-VM [INFO] finished frobbing NishanthSpShetty/Stack-VM [INFO] frobbed toml for NishanthSpShetty/Stack-VM written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NishanthSpShetty/Stack-VM/Cargo.toml [INFO] crate NishanthSpShetty/Stack-VM has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting NishanthSpShetty/Stack-VM against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NishanthSpShetty/Stack-VM:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b65d00933ce62d93a17dbdb637fbbccbe4aa8760ed7431c626fc06c162ca9b56 [INFO] running `"docker" "start" "-a" "b65d00933ce62d93a17dbdb637fbbccbe4aa8760ed7431c626fc06c162ca9b56"` [INFO] [stderr] Checking stack-vm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib/stack/mod.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | (instruction & 0xC0000000)>>30//2 msb [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib/stack/mod.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | instruction & 0x3fffffff [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/main.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return(); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib/stack/mod.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | (instruction & 0xC0000000)>>30//2 msb [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib/stack/mod.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | instruction & 0x3fffffff [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/main.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return(); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/stack/mod.rs:33:37 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn load_program(&mut self,prog:&Vec){ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: literal out of range for i32 [INFO] [stderr] --> src/lib/stack/mod.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | (instruction & 0xC0000000)>>30//2 msb [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(overflowing_literals)] on by default [INFO] [stderr] = note: the literal `0xC0000000` (decimal `3221225472`) does not fit into an `i32` and will become `-1073741824i32` [INFO] [stderr] = help: consider using `u32` instead [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/stack/mod.rs:33:37 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn load_program(&mut self,prog:&Vec){ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: literal out of range for i32 [INFO] [stderr] --> src/lib/stack/mod.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | (instruction & 0xC0000000)>>30//2 msb [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(overflowing_literals)] on by default [INFO] [stderr] = note: the literal `0xC0000000` (decimal `3221225472`) does not fit into an `i32` and will become `-1073741824i32` [INFO] [stderr] = help: consider using `u32` instead [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "b65d00933ce62d93a17dbdb637fbbccbe4aa8760ed7431c626fc06c162ca9b56"` [INFO] running `"docker" "rm" "-f" "b65d00933ce62d93a17dbdb637fbbccbe4aa8760ed7431c626fc06c162ca9b56"` [INFO] [stdout] b65d00933ce62d93a17dbdb637fbbccbe4aa8760ed7431c626fc06c162ca9b56