[INFO] updating cached repository NikitaSmall/rust_rpn [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/NikitaSmall/rust_rpn [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/NikitaSmall/rust_rpn" "work/ex/clippy-test-run/sources/stable/gh/NikitaSmall/rust_rpn"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NikitaSmall/rust_rpn'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/NikitaSmall/rust_rpn" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NikitaSmall/rust_rpn"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NikitaSmall/rust_rpn'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 34a83739d911b80bb25319db4149fbd4084660a3 [INFO] sha for GitHub repo NikitaSmall/rust_rpn: 34a83739d911b80bb25319db4149fbd4084660a3 [INFO] validating manifest of NikitaSmall/rust_rpn on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of NikitaSmall/rust_rpn on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing NikitaSmall/rust_rpn [INFO] finished frobbing NikitaSmall/rust_rpn [INFO] frobbed toml for NikitaSmall/rust_rpn written to work/ex/clippy-test-run/sources/stable/gh/NikitaSmall/rust_rpn/Cargo.toml [INFO] started frobbing NikitaSmall/rust_rpn [INFO] finished frobbing NikitaSmall/rust_rpn [INFO] frobbed toml for NikitaSmall/rust_rpn written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NikitaSmall/rust_rpn/Cargo.toml [INFO] crate NikitaSmall/rust_rpn has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting NikitaSmall/rust_rpn against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NikitaSmall/rust_rpn:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ed36bd7ef6b0641dfbc35e539ee9924debef01475874b24a9e73bcbf74027f26 [INFO] running `"docker" "start" "-a" "ed36bd7ef6b0641dfbc35e539ee9924debef01475874b24a9e73bcbf74027f26"` [INFO] [stderr] Checking rpn v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/converter.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | raw: raw, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/converter.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | prededence: prededence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prededence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/converter.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | raw: raw, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/converter.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | prededence: prededence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prededence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: field is never used: `raw` [INFO] [stderr] --> src/converter.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | raw: String, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `prededence` [INFO] [stderr] --> src/converter.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | prededence: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `convert` [INFO] [stderr] --> src/converter.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn convert(raw: String) -> Converter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `process` [INFO] [stderr] --> src/converter.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | fn process(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/converter.rs:42:27 [INFO] [stderr] | [INFO] [stderr] 42 | while (s.len() > 0) && [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/converter.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | while s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/converter.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | .map(|el| match el { [INFO] [stderr] | _______________________^ [INFO] [stderr] 59 | | &Stackable::Value(num) => num.to_string(), [INFO] [stderr] 60 | | &Stackable::Operation(op) => op.to_string(), [INFO] [stderr] 61 | | }) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 58 | .map(|el| match *el { [INFO] [stderr] 59 | Stackable::Value(num) => num.to_string(), [INFO] [stderr] 60 | Stackable::Operation(op) => op.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / match value { [INFO] [stderr] 23 | | &Stackable::Value(num) => self.stack.push(num), [INFO] [stderr] 24 | | &Stackable::Operation(operation) => { [INFO] [stderr] 25 | | let value_one = self.stack.pop().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *value { [INFO] [stderr] 23 | Stackable::Value(num) => self.stack.push(num), [INFO] [stderr] 24 | Stackable::Operation(operation) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/converter.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | let mut converter = Converter::convert(example_string); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/converter.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | let mut converter = Converter::convert(example_string); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/converter.rs:42:27 [INFO] [stderr] | [INFO] [stderr] 42 | while (s.len() > 0) && [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/converter.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | while s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/converter.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | .map(|el| match el { [INFO] [stderr] | _______________________^ [INFO] [stderr] 59 | | &Stackable::Value(num) => num.to_string(), [INFO] [stderr] 60 | | &Stackable::Operation(op) => op.to_string(), [INFO] [stderr] 61 | | }) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 58 | .map(|el| match *el { [INFO] [stderr] 59 | Stackable::Value(num) => num.to_string(), [INFO] [stderr] 60 | Stackable::Operation(op) => op.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / match value { [INFO] [stderr] 23 | | &Stackable::Value(num) => self.stack.push(num), [INFO] [stderr] 24 | | &Stackable::Operation(operation) => { [INFO] [stderr] 25 | | let value_one = self.stack.pop().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *value { [INFO] [stderr] 23 | Stackable::Value(num) => self.stack.push(num), [INFO] [stderr] 24 | Stackable::Operation(operation) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.04s [INFO] running `"docker" "inspect" "ed36bd7ef6b0641dfbc35e539ee9924debef01475874b24a9e73bcbf74027f26"` [INFO] running `"docker" "rm" "-f" "ed36bd7ef6b0641dfbc35e539ee9924debef01475874b24a9e73bcbf74027f26"` [INFO] [stdout] ed36bd7ef6b0641dfbc35e539ee9924debef01475874b24a9e73bcbf74027f26