[INFO] updating cached repository NicBonetto/rusty-hangman
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/NicBonetto/rusty-hangman
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/NicBonetto/rusty-hangman" "work/ex/clippy-test-run/sources/stable/gh/NicBonetto/rusty-hangman"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/NicBonetto/rusty-hangman'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/NicBonetto/rusty-hangman" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NicBonetto/rusty-hangman"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NicBonetto/rusty-hangman'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9a3145a39cf86c014e59de9f91faf64e96b30278
[INFO] sha for GitHub repo NicBonetto/rusty-hangman: 9a3145a39cf86c014e59de9f91faf64e96b30278
[INFO] validating manifest of NicBonetto/rusty-hangman on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of NicBonetto/rusty-hangman on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing NicBonetto/rusty-hangman
[INFO] finished frobbing NicBonetto/rusty-hangman
[INFO] frobbed toml for NicBonetto/rusty-hangman written to work/ex/clippy-test-run/sources/stable/gh/NicBonetto/rusty-hangman/Cargo.toml
[INFO] started frobbing NicBonetto/rusty-hangman
[INFO] finished frobbing NicBonetto/rusty-hangman
[INFO] frobbed toml for NicBonetto/rusty-hangman written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NicBonetto/rusty-hangman/Cargo.toml
[INFO] crate NicBonetto/rusty-hangman has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting NicBonetto/rusty-hangman against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/NicBonetto/rusty-hangman:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2937ebea199a7955eb2ffb2eec023442c26fac218da02b79e3834245689781a0
[INFO] running `"docker" "start" "-a" "2937ebea199a7955eb2ffb2eec023442c26fac218da02b79e3834245689781a0"`
[INFO] [stderr]     Checking hangman v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 |     return String::from(word_vec[rand_idx]);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(word_vec[rand_idx])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 |     return letters;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `letters`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:112:30
[INFO] [stderr]     |
[INFO] [stderr] 112 |                 Some(c) => { return c; }
[INFO] [stderr]     |                              ^^^^^^^^^ help: remove `return` as shown: `c`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:113:27
[INFO] [stderr]     |
[INFO] [stderr] 113 |                 None => { return '*'; }
[INFO] [stderr]     |                           ^^^^^^^^^^^ help: remove `return` as shown: `'*'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:116:21
[INFO] [stderr]     |
[INFO] [stderr] 116 |         Err(_) => { return '*'; }
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: remove `return` as shown: `'*'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 |     return String::from(word_vec[rand_idx]);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(word_vec[rand_idx])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 |     return letters;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `letters`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:112:30
[INFO] [stderr]     |
[INFO] [stderr] 112 |                 Some(c) => { return c; }
[INFO] [stderr]     |                              ^^^^^^^^^ help: remove `return` as shown: `c`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:113:27
[INFO] [stderr]     |
[INFO] [stderr] 113 |                 None => { return '*'; }
[INFO] [stderr]     |                           ^^^^^^^^^^^ help: remove `return` as shown: `'*'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:116:21
[INFO] [stderr]     |
[INFO] [stderr] 116 |         Err(_) => { return '*'; }
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: remove `return` as shown: `'*'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:75:25
[INFO] [stderr]    |
[INFO] [stderr] 75 | fn create_letters(word: &String) -> Vec<Letter> {
[INFO] [stderr]    |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:88:30
[INFO] [stderr]    |
[INFO] [stderr] 88 | fn display_progress(letters: &Vec<Letter>) {
[INFO] [stderr]    |                              ^^^^^^^^^^^^ help: change this to: `&[Letter]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:75:25
[INFO] [stderr]    |
[INFO] [stderr] 75 | fn create_letters(word: &String) -> Vec<Letter> {
[INFO] [stderr]    |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:88:30
[INFO] [stderr]    |
[INFO] [stderr] 88 | fn display_progress(letters: &Vec<Letter>) {
[INFO] [stderr]    |                              ^^^^^^^^^^^^ help: change this to: `&[Letter]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.79s
[INFO] running `"docker" "inspect" "2937ebea199a7955eb2ffb2eec023442c26fac218da02b79e3834245689781a0"`
[INFO] running `"docker" "rm" "-f" "2937ebea199a7955eb2ffb2eec023442c26fac218da02b79e3834245689781a0"`
[INFO] [stdout] 2937ebea199a7955eb2ffb2eec023442c26fac218da02b79e3834245689781a0