[INFO] updating cached repository Nemin32/rust_langton [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Nemin32/rust_langton [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Nemin32/rust_langton" "work/ex/clippy-test-run/sources/stable/gh/Nemin32/rust_langton"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Nemin32/rust_langton'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Nemin32/rust_langton" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nemin32/rust_langton"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nemin32/rust_langton'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e3a14b38d1a3fccef4542880d2674324a08f2b60 [INFO] sha for GitHub repo Nemin32/rust_langton: e3a14b38d1a3fccef4542880d2674324a08f2b60 [INFO] validating manifest of Nemin32/rust_langton on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Nemin32/rust_langton on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Nemin32/rust_langton [INFO] finished frobbing Nemin32/rust_langton [INFO] frobbed toml for Nemin32/rust_langton written to work/ex/clippy-test-run/sources/stable/gh/Nemin32/rust_langton/Cargo.toml [INFO] started frobbing Nemin32/rust_langton [INFO] finished frobbing Nemin32/rust_langton [INFO] frobbed toml for Nemin32/rust_langton written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nemin32/rust_langton/Cargo.toml [INFO] crate Nemin32/rust_langton has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Nemin32/rust_langton against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nemin32/rust_langton:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd8c2091441737e1f8b802cf714d86e64f0c3f243570997c9d5c999d26de50c0 [INFO] running `"docker" "start" "-a" "bd8c2091441737e1f8b802cf714d86e64f0c3f243570997c9d5c999d26de50c0"` [INFO] [stderr] Checking rust_langton v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | println!(""); //Print one more newline character, else it would look ugly [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | println!(""); //Print one more newline character, else it would look ugly [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 32 | | if self.dir -1 < 0 { [INFO] [stderr] 33 | | self.dir = 3; [INFO] [stderr] 34 | | } else { [INFO] [stderr] 35 | | self.dir -= 1; [INFO] [stderr] 36 | | } //Turn the ant left [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 31 | } else if self.dir -1 < 0 { [INFO] [stderr] 32 | self.dir = 3; [INFO] [stderr] 33 | } else { [INFO] [stderr] 34 | self.dir -= 1; [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 32 | | if self.dir -1 < 0 { [INFO] [stderr] 33 | | self.dir = 3; [INFO] [stderr] 34 | | } else { [INFO] [stderr] 35 | | self.dir -= 1; [INFO] [stderr] 36 | | } //Turn the ant left [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 31 | } else if self.dir -1 < 0 { [INFO] [stderr] 32 | self.dir = 3; [INFO] [stderr] 33 | } else { [INFO] [stderr] 34 | self.dir -= 1; [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is only used to index `arr`. [INFO] [stderr] --> src/main.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | for y in 0..SCALE { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 44 | for in arr.iter().take(SCALE) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is only used to index `arr`. [INFO] [stderr] --> src/main.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | for y in 0..SCALE { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 44 | for in arr.iter().take(SCALE) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.48s [INFO] running `"docker" "inspect" "bd8c2091441737e1f8b802cf714d86e64f0c3f243570997c9d5c999d26de50c0"` [INFO] running `"docker" "rm" "-f" "bd8c2091441737e1f8b802cf714d86e64f0c3f243570997c9d5c999d26de50c0"` [INFO] [stdout] bd8c2091441737e1f8b802cf714d86e64f0c3f243570997c9d5c999d26de50c0