[INFO] updating cached repository Nasafato/rusty-tree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Nasafato/rusty-tree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Nasafato/rusty-tree" "work/ex/clippy-test-run/sources/stable/gh/Nasafato/rusty-tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Nasafato/rusty-tree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Nasafato/rusty-tree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nasafato/rusty-tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nasafato/rusty-tree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9b3c625756e182af34632215240bc932209fe9e8 [INFO] sha for GitHub repo Nasafato/rusty-tree: 9b3c625756e182af34632215240bc932209fe9e8 [INFO] validating manifest of Nasafato/rusty-tree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Nasafato/rusty-tree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Nasafato/rusty-tree [INFO] finished frobbing Nasafato/rusty-tree [INFO] frobbed toml for Nasafato/rusty-tree written to work/ex/clippy-test-run/sources/stable/gh/Nasafato/rusty-tree/Cargo.toml [INFO] started frobbing Nasafato/rusty-tree [INFO] finished frobbing Nasafato/rusty-tree [INFO] frobbed toml for Nasafato/rusty-tree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nasafato/rusty-tree/Cargo.toml [INFO] crate Nasafato/rusty-tree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Nasafato/rusty-tree against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Nasafato/rusty-tree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5933279efe2ca5897d760eeb51f91e55f8ae77dd710339a798d40eee84559cea [INFO] running `"docker" "start" "-a" "5933279efe2ca5897d760eeb51f91e55f8ae77dd710339a798d40eee84559cea"` [INFO] [stderr] Checking tree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / let mut max_depth = 2; [INFO] [stderr] 29 | | [INFO] [stderr] 30 | | if args.len() == 3 { [INFO] [stderr] 31 | | max_depth = args[2].parse::().unwrap(); [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let max_depth = if args.len() == 3 { args[2].parse::().unwrap() } else { 2 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / writeln!(std::io::stderr(), [INFO] [stderr] 17 | | "Usage: tree PATH") [INFO] [stderr] 18 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / writeln!(std::io::stderr(), [INFO] [stderr] 20 | | "Example: {} path/to/folder [:depth]", [INFO] [stderr] 21 | | args[0]) [INFO] [stderr] 22 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / let mut max_depth = 2; [INFO] [stderr] 29 | | [INFO] [stderr] 30 | | if args.len() == 3 { [INFO] [stderr] 31 | | max_depth = args[2].parse::().unwrap(); [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let max_depth = if args.len() == 3 { args[2].parse::().unwrap() } else { 2 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / writeln!(std::io::stderr(), [INFO] [stderr] 17 | | "Usage: tree PATH") [INFO] [stderr] 18 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / writeln!(std::io::stderr(), [INFO] [stderr] 20 | | "Example: {} path/to/folder [:depth]", [INFO] [stderr] 21 | | args[0]) [INFO] [stderr] 22 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s [INFO] running `"docker" "inspect" "5933279efe2ca5897d760eeb51f91e55f8ae77dd710339a798d40eee84559cea"` [INFO] running `"docker" "rm" "-f" "5933279efe2ca5897d760eeb51f91e55f8ae77dd710339a798d40eee84559cea"` [INFO] [stdout] 5933279efe2ca5897d760eeb51f91e55f8ae77dd710339a798d40eee84559cea