[INFO] updating cached repository Naalunth/lightriders-starterbot-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Naalunth/lightriders-starterbot-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Naalunth/lightriders-starterbot-rust" "work/ex/clippy-test-run/sources/stable/gh/Naalunth/lightriders-starterbot-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Naalunth/lightriders-starterbot-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Naalunth/lightriders-starterbot-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Naalunth/lightriders-starterbot-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Naalunth/lightriders-starterbot-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ec47553b8d3601f843b7fc5872e4b232ec4b1589
[INFO] sha for GitHub repo Naalunth/lightriders-starterbot-rust: ec47553b8d3601f843b7fc5872e4b232ec4b1589
[INFO] validating manifest of Naalunth/lightriders-starterbot-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Naalunth/lightriders-starterbot-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Naalunth/lightriders-starterbot-rust
[INFO] finished frobbing Naalunth/lightriders-starterbot-rust
[INFO] frobbed toml for Naalunth/lightriders-starterbot-rust written to work/ex/clippy-test-run/sources/stable/gh/Naalunth/lightriders-starterbot-rust/Cargo.toml
[INFO] started frobbing Naalunth/lightriders-starterbot-rust
[INFO] finished frobbing Naalunth/lightriders-starterbot-rust
[INFO] frobbed toml for Naalunth/lightriders-starterbot-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Naalunth/lightriders-starterbot-rust/Cargo.toml
[INFO] crate Naalunth/lightriders-starterbot-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Naalunth/lightriders-starterbot-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Naalunth/lightriders-starterbot-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1124f8532e208790bedabdf33912ea5ded93c35d2520b066914709e935109836
[INFO] running `"docker" "start" "-a" "1124f8532e208790bedabdf33912ea5ded93c35d2520b066914709e935109836"`
[INFO] [stderr]     Checking lightriders-starterbot-rust v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/board.rs:40:4
[INFO] [stderr]    |
[INFO] [stderr] 40 |             b: b,
[INFO] [stderr]    |             ^^^^ help: replace it with: `b`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/board.rs:41:4
[INFO] [stderr]    |
[INFO] [stderr] 41 |             player_position: player_position
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player_position`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:71:4
[INFO] [stderr]    |
[INFO] [stderr] 71 |             bot: bot
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `bot`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/board.rs:40:4
[INFO] [stderr]    |
[INFO] [stderr] 40 |             b: b,
[INFO] [stderr]    |             ^^^^ help: replace it with: `b`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/board.rs:41:4
[INFO] [stderr]    |
[INFO] [stderr] 41 |             player_position: player_position
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player_position`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:71:4
[INFO] [stderr]    |
[INFO] [stderr] 71 |             bot: bot
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `bot`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/starter_bot.rs:26:21
[INFO] [stderr]    |
[INFO] [stderr] 26 |         self.rng_state = (1664525 * self.rng_state + 1013904223) % 4294967296;
[INFO] [stderr]    |                           ^^^^^^^ help: consider: `1_664_525`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/starter_bot.rs:26:48
[INFO] [stderr]    |
[INFO] [stderr] 26 |         self.rng_state = (1664525 * self.rng_state + 1013904223) % 4294967296;
[INFO] [stderr]    |                                                      ^^^^^^^^^^ help: consider: `1_013_904_223`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/starter_bot.rs:26:62
[INFO] [stderr]    |
[INFO] [stderr] 26 |         self.rng_state = (1664525 * self.rng_state + 1013904223) % 4294967296;
[INFO] [stderr]    |                                                                    ^^^^^^^^^^ help: consider: `4_294_967_296`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/starter_bot.rs:26:21
[INFO] [stderr]    |
[INFO] [stderr] 26 |         self.rng_state = (1664525 * self.rng_state + 1013904223) % 4294967296;
[INFO] [stderr]    |                           ^^^^^^^ help: consider: `1_664_525`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/starter_bot.rs:26:48
[INFO] [stderr]    |
[INFO] [stderr] 26 |         self.rng_state = (1664525 * self.rng_state + 1013904223) % 4294967296;
[INFO] [stderr]    |                                                      ^^^^^^^^^^ help: consider: `1_013_904_223`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/starter_bot.rs:26:62
[INFO] [stderr]    |
[INFO] [stderr] 26 |         self.rng_state = (1664525 * self.rng_state + 1013904223) % 4294967296;
[INFO] [stderr]    |                                                                    ^^^^^^^^^^ help: consider: `4_294_967_296`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:33:39
[INFO] [stderr]    |
[INFO] [stderr] 33 |     fn handle_action(&mut self, command: &Vec<&str>) {
[INFO] [stderr]    |                                          ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:40:39
[INFO] [stderr]    |
[INFO] [stderr] 40 |     fn handle_update(&mut self, command: &Vec<&str>) {
[INFO] [stderr]    |                                          ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:48:40
[INFO] [stderr]    |
[INFO] [stderr] 48 |     fn handle_setting(&mut self, command: &Vec<&str>) {
[INFO] [stderr]    |                                           ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/parser.rs:76:17
[INFO] [stderr]    |
[INFO] [stderr] 76 | fn send_move(m: &Move) {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `Move`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/starter_bot.rs:32:6
[INFO] [stderr]    |
[INFO] [stderr] 32 |         if moves.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!moves.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/starter_bot.rs:33:61
[INFO] [stderr]    |
[INFO] [stderr] 33 |             moves.get(self.rng_state as usize % moves.len()).map(|m| (*m).clone()).unwrap()
[INFO] [stderr]    |                                                                      ^^^^^^^^^^^^ help: try removing the `clone` call: `(*m)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/starter_bot.rs:48:3
[INFO] [stderr]    |
[INFO] [stderr] 48 |           match setting {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 49 | |             Setting::BotId(id) => self.id = id,
[INFO] [stderr] 50 | |             _ => {}
[INFO] [stderr] 51 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Setting::BotId(id) = setting { self.id = id }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:33:39
[INFO] [stderr]    |
[INFO] [stderr] 33 |     fn handle_action(&mut self, command: &Vec<&str>) {
[INFO] [stderr]    |                                          ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:40:39
[INFO] [stderr]    |
[INFO] [stderr] 40 |     fn handle_update(&mut self, command: &Vec<&str>) {
[INFO] [stderr]    |                                          ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:48:40
[INFO] [stderr]    |
[INFO] [stderr] 48 |     fn handle_setting(&mut self, command: &Vec<&str>) {
[INFO] [stderr]    |                                           ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/parser.rs:76:17
[INFO] [stderr]    |
[INFO] [stderr] 76 | fn send_move(m: &Move) {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `Move`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/starter_bot.rs:32:6
[INFO] [stderr]    |
[INFO] [stderr] 32 |         if moves.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!moves.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/starter_bot.rs:33:61
[INFO] [stderr]    |
[INFO] [stderr] 33 |             moves.get(self.rng_state as usize % moves.len()).map(|m| (*m).clone()).unwrap()
[INFO] [stderr]    |                                                                      ^^^^^^^^^^^^ help: try removing the `clone` call: `(*m)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/starter_bot.rs:48:3
[INFO] [stderr]    |
[INFO] [stderr] 48 |           match setting {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 49 | |             Setting::BotId(id) => self.id = id,
[INFO] [stderr] 50 | |             _ => {}
[INFO] [stderr] 51 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Setting::BotId(id) = setting { self.id = id }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.88s
[INFO] running `"docker" "inspect" "1124f8532e208790bedabdf33912ea5ded93c35d2520b066914709e935109836"`
[INFO] running `"docker" "rm" "-f" "1124f8532e208790bedabdf33912ea5ded93c35d2520b066914709e935109836"`
[INFO] [stdout] 1124f8532e208790bedabdf33912ea5ded93c35d2520b066914709e935109836