[INFO] updating cached repository Mouaijin/bouzu [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Mouaijin/bouzu [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Mouaijin/bouzu" "work/ex/clippy-test-run/sources/stable/gh/Mouaijin/bouzu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Mouaijin/bouzu'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Mouaijin/bouzu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mouaijin/bouzu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mouaijin/bouzu'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 18e7510d68b822227bfe20dd014f9b91b16f95c4 [INFO] sha for GitHub repo Mouaijin/bouzu: 18e7510d68b822227bfe20dd014f9b91b16f95c4 [INFO] validating manifest of Mouaijin/bouzu on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Mouaijin/bouzu on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Mouaijin/bouzu [INFO] finished frobbing Mouaijin/bouzu [INFO] frobbed toml for Mouaijin/bouzu written to work/ex/clippy-test-run/sources/stable/gh/Mouaijin/bouzu/Cargo.toml [INFO] started frobbing Mouaijin/bouzu [INFO] finished frobbing Mouaijin/bouzu [INFO] frobbed toml for Mouaijin/bouzu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mouaijin/bouzu/Cargo.toml [INFO] crate Mouaijin/bouzu has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Mouaijin/bouzu against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Mouaijin/bouzu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a4a27edb423b49487e462ac9aeeec30097462e9478cfecbc7716959e9c92bfbc [INFO] running `"docker" "start" "-a" "a4a27edb423b49487e462ac9aeeec30097462e9478cfecbc7716959e9c92bfbc"` [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking bouzu v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | logo: logo, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `logo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | japanese: japanese, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `japanese` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | checksum: checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmu.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | rom: rom, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | logo: logo, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `logo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | japanese: japanese, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `japanese` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | checksum: checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmu.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | rom: rom, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shared.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | (val & 0b11110000) >> 4 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shared.rs:31:11 [INFO] [stderr] | [INFO] [stderr] 31 | val & 0b00001111 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rom.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / return Ok(CartridgeHeader { [INFO] [stderr] 121 | | title: title, [INFO] [stderr] 122 | | color: color, [INFO] [stderr] 123 | | model: model, [INFO] [stderr] ... | [INFO] [stderr] 130 | | checksum: checksum, [INFO] [stderr] 131 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shared.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | (val & 0b11110000) >> 4 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shared.rs:31:11 [INFO] [stderr] | [INFO] [stderr] 31 | val & 0b00001111 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 120 | Ok(CartridgeHeader { [INFO] [stderr] 121 | title: title, [INFO] [stderr] 122 | color: color, [INFO] [stderr] 123 | model: model, [INFO] [stderr] 124 | logo: logo, [INFO] [stderr] 125 | rom_size_kb: romsize, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rom.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/rom.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::*` [INFO] [stderr] --> src/cpu.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::rc::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::*` [INFO] [stderr] --> src/cpu.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::cell::*; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::boxed::Box` [INFO] [stderr] --> src/cpu.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::boxed::Box; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `log` [INFO] [stderr] --> src/cpu.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use log; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:345:28 [INFO] [stderr] | [INFO] [stderr] 345 | let mask = *byte & 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:357:26 [INFO] [stderr] | [INFO] [stderr] 357 | let mask = old & 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:417:28 [INFO] [stderr] | [INFO] [stderr] 417 | let mut mask: u8 = 0b11111110; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:424:28 [INFO] [stderr] | [INFO] [stderr] 424 | let mut mask: u8 = 0b11111110; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `register` [INFO] [stderr] --> src/mmu.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use register; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:87:37 [INFO] [stderr] | [INFO] [stderr] 87 | BitFlag::Z => self.f |= 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:88:37 [INFO] [stderr] | [INFO] [stderr] 88 | BitFlag::N => self.f |= 0b01000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:89:37 [INFO] [stderr] | [INFO] [stderr] 89 | BitFlag::H => self.f |= 0b00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:90:37 [INFO] [stderr] | [INFO] [stderr] 90 | BitFlag::C => self.f |= 0b00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:95:37 [INFO] [stderr] | [INFO] [stderr] 95 | BitFlag::Z => self.f &= 0b01111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:96:37 [INFO] [stderr] | [INFO] [stderr] 96 | BitFlag::N => self.f &= 0b10111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:97:37 [INFO] [stderr] | [INFO] [stderr] 97 | BitFlag::H => self.f &= 0b11011111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1101_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:98:37 [INFO] [stderr] | [INFO] [stderr] 98 | BitFlag::C => self.f &= 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:103:36 [INFO] [stderr] | [INFO] [stderr] 103 | BitFlag::Z => self.f & 0b10000000 >> 7 == 1, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:104:37 [INFO] [stderr] | [INFO] [stderr] 104 | BitFlag::N => (self.f & 0b01000000) >> 6 == 1, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:105:37 [INFO] [stderr] | [INFO] [stderr] 105 | BitFlag::H => (self.f & 0b00100000) >> 5 == 1, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:106:37 [INFO] [stderr] | [INFO] [stderr] 106 | BitFlag::C => (self.f & 0b00010000) >> 4 == 1, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rom.rs:120:5 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] 120 | / return Ok(CartridgeHeader { [INFO] [stderr] 121 | | title: title, [INFO] [stderr] 122 | | color: color, [INFO] [stderr] 123 | | model: model, [INFO] [stderr] ... | [INFO] [stderr] 130 | | checksum: checksum, [INFO] [stderr] 131 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 120 | Ok(CartridgeHeader { [INFO] [stderr] 121 | title: title, [INFO] [stderr] 122 | color: color, [INFO] [stderr] 123 | model: model, [INFO] [stderr] 124 | logo: logo, [INFO] [stderr] 125 | rom_size_kb: romsize, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rom.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/rom.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::*` [INFO] [stderr] --> src/cpu.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::rc::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::*` [INFO] [stderr] --> src/cpu.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::cell::*; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::boxed::Box` [INFO] [stderr] --> src/cpu.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::boxed::Box; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `log` [INFO] [stderr] --> src/cpu.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use log; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:345:28 [INFO] [stderr] | [INFO] [stderr] 345 | let mask = *byte & 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:357:26 [INFO] [stderr] | [INFO] [stderr] 357 | let mask = old & 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:417:28 [INFO] [stderr] | [INFO] [stderr] 417 | let mut mask: u8 = 0b11111110; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:424:28 [INFO] [stderr] | [INFO] [stderr] 424 | let mut mask: u8 = 0b11111110; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `register` [INFO] [stderr] --> src/mmu.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use register; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:87:37 [INFO] [stderr] | [INFO] [stderr] 87 | BitFlag::Z => self.f |= 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:88:37 [INFO] [stderr] | [INFO] [stderr] 88 | BitFlag::N => self.f |= 0b01000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:89:37 [INFO] [stderr] | [INFO] [stderr] 89 | BitFlag::H => self.f |= 0b00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:90:37 [INFO] [stderr] | [INFO] [stderr] 90 | BitFlag::C => self.f |= 0b00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:95:37 [INFO] [stderr] | [INFO] [stderr] 95 | BitFlag::Z => self.f &= 0b01111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:96:37 [INFO] [stderr] | [INFO] [stderr] 96 | BitFlag::N => self.f &= 0b10111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:97:37 [INFO] [stderr] | [INFO] [stderr] 97 | BitFlag::H => self.f &= 0b11011111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1101_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:98:37 [INFO] [stderr] | [INFO] [stderr] 98 | BitFlag::C => self.f &= 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:103:36 [INFO] [stderr] | [INFO] [stderr] 103 | BitFlag::Z => self.f & 0b10000000 >> 7 == 1, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:104:37 [INFO] [stderr] | [INFO] [stderr] 104 | BitFlag::N => (self.f & 0b01000000) >> 6 == 1, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:105:37 [INFO] [stderr] | [INFO] [stderr] 105 | BitFlag::H => (self.f & 0b00100000) >> 5 == 1, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/register.rs:106:37 [INFO] [stderr] | [INFO] [stderr] 106 | BitFlag::C => (self.f & 0b00010000) >> 4 == 1, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu.rs:417:13 [INFO] [stderr] | [INFO] [stderr] 417 | let mut mask: u8 = 0b11111110; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | let mut mask: u8 = 0b11111110; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu.rs:417:13 [INFO] [stderr] | [INFO] [stderr] 417 | let mut mask: u8 = 0b11111110; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | let mut mask: u8 = 0b11111110; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_rom` [INFO] [stderr] --> src/rom.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn print_rom(path: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PC` [INFO] [stderr] --> src/register.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | PC, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_hl` [INFO] [stderr] --> src/register.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | pub fn get_hl(&self) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `inc_reg8` [INFO] [stderr] --> src/register.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | pub fn inc_reg8(&mut self, reg: Reg8Name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dec_reg8` [INFO] [stderr] --> src/register.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | pub fn dec_reg8(&mut self, reg: Reg8Name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:9:6 [INFO] [stderr] | [INFO] [stderr] 9 | ((hi as u16) << 8) | (lo as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | ((hi as u16) << 8) | (lo as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:46:15 [INFO] [stderr] | [INFO] [stderr] 46 | let sum = u0 as u32 + u1 as u32 + c as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(u0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:46:27 [INFO] [stderr] | [INFO] [stderr] 46 | let sum = u0 as u32 + u1 as u32 + c as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(u1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | let sum = u0 as u32 + u1 as u32 + c as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(u0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | let sum = u0 as u32 + u1 as u32 + c as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(u1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:59:29 [INFO] [stderr] | [INFO] [stderr] 59 | let half = nth_bit16(7, hi as u16 + lo as u16 + c as u16); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:59:41 [INFO] [stderr] | [INFO] [stderr] 59 | let half = nth_bit16(7, hi as u16 + lo as u16 + c as u16); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:65:15 [INFO] [stderr] | [INFO] [stderr] 65 | let sub = u0 as i16 - u1 as i16 - c as i16; [INFO] [stderr] | ^^^^^^^^^ help: try: `i16::from(u0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:65:27 [INFO] [stderr] | [INFO] [stderr] 65 | let sub = u0 as i16 - u1 as i16 - c as i16; [INFO] [stderr] | ^^^^^^^^^ help: try: `i16::from(u1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | let half = (low_nibble(u0) as i16 - low_nibble(u1) as i16 - c as i16) < 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(low_nibble(u0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:67:41 [INFO] [stderr] | [INFO] [stderr] 67 | let half = (low_nibble(u0) as i16 - low_nibble(u1) as i16 - c as i16) < 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(low_nibble(u1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: function is never used: `print_rom` [INFO] [stderr] --> src/rom.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn print_rom(path: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PC` [INFO] [stderr] --> src/register.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | PC, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_hl` [INFO] [stderr] --> src/register.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | pub fn get_hl(&self) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `inc_reg8` [INFO] [stderr] --> src/register.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | pub fn inc_reg8(&mut self, reg: Reg8Name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dec_reg8` [INFO] [stderr] --> src/register.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | pub fn dec_reg8(&mut self, reg: Reg8Name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:9:6 [INFO] [stderr] | [INFO] [stderr] 9 | ((hi as u16) << 8) | (lo as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | ((hi as u16) << 8) | (lo as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:46:15 [INFO] [stderr] | [INFO] [stderr] 46 | let sum = u0 as u32 + u1 as u32 + c as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(u0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:46:27 [INFO] [stderr] | [INFO] [stderr] 46 | let sum = u0 as u32 + u1 as u32 + c as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(u1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | let sum = u0 as u32 + u1 as u32 + c as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(u0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | let sum = u0 as u32 + u1 as u32 + c as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(u1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:59:29 [INFO] [stderr] | [INFO] [stderr] 59 | let half = nth_bit16(7, hi as u16 + lo as u16 + c as u16); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:59:41 [INFO] [stderr] | [INFO] [stderr] 59 | let half = nth_bit16(7, hi as u16 + lo as u16 + c as u16); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:65:15 [INFO] [stderr] | [INFO] [stderr] 65 | let sub = u0 as i16 - u1 as i16 - c as i16; [INFO] [stderr] | ^^^^^^^^^ help: try: `i16::from(u0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:65:27 [INFO] [stderr] | [INFO] [stderr] 65 | let sub = u0 as i16 - u1 as i16 - c as i16; [INFO] [stderr] | ^^^^^^^^^ help: try: `i16::from(u1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | let half = (low_nibble(u0) as i16 - low_nibble(u1) as i16 - c as i16) < 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(low_nibble(u0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/shared.rs:67:41 [INFO] [stderr] | [INFO] [stderr] 67 | let half = (low_nibble(u0) as i16 - low_nibble(u1) as i16 - c as i16) < 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(low_nibble(u1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/rom.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | .map(|x| x.clone() as char) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/rom.rs:113:25 [INFO] [stderr] | [INFO] [stderr] 113 | let logo: Vec = dat[0x104..0x0133].iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/rom.rs:146:37 [INFO] [stderr] | [INFO] [stderr] 146 | let mut temp: Vec = dat[offset..end_address].iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/rom.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | .map(|x| x.clone() as char) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/rom.rs:113:25 [INFO] [stderr] | [INFO] [stderr] 113 | let logo: Vec = dat[0x104..0x0133].iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/rom.rs:146:37 [INFO] [stderr] | [INFO] [stderr] 146 | let mut temp: Vec = dat[offset..end_address].iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | let val = match byte.clone() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | let val = match byte.clone() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:161:19 [INFO] [stderr] | [INFO] [stderr] 161 | let val = self.register.get_reg16(reg.clone()) as u32 + imm as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.register.get_reg16(reg.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:161:65 [INFO] [stderr] | [INFO] [stderr] 161 | let val = self.register.get_reg16(reg.clone()) as u32 + imm as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:189:32 [INFO] [stderr] | [INFO] [stderr] 189 | let newcarry = nth_bit(self.register.a.clone(), 7); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | let val = match byte.clone() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:200:45 [INFO] [stderr] | [INFO] [stderr] 200 | .set_flag_b(BitFlag::C, nth_bit(byte.clone(), 7)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:209:19 [INFO] [stderr] | [INFO] [stderr] 209 | let old = self.register.get_reg8(reg.clone()).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.get_reg8(reg.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:210:19 [INFO] [stderr] | [INFO] [stderr] 210 | let new = old.clone().rotate_left(1); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `old` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:220:32 [INFO] [stderr] | [INFO] [stderr] 220 | let newcarry = nth_bit(self.register.a.clone(), 7); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | let val = match byte.clone() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:233:45 [INFO] [stderr] | [INFO] [stderr] 233 | .set_flag_b(BitFlag::C, nth_bit(byte.clone(), 7)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:245:19 [INFO] [stderr] | [INFO] [stderr] 245 | let new = old.clone() << 1 | carry; [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `old` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:248:45 [INFO] [stderr] | [INFO] [stderr] 248 | .set_flag_b(BitFlag::C, nth_bit(old.clone(), 7)); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `old` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:257:32 [INFO] [stderr] | [INFO] [stderr] 257 | let newcarry = nth_bit(self.register.a.clone(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:268:45 [INFO] [stderr] | [INFO] [stderr] 268 | .set_flag_b(BitFlag::C, nth_bit(byte.clone(), 0)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:290:32 [INFO] [stderr] | [INFO] [stderr] 290 | let newcarry = nth_bit(self.register.a.clone(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:303:45 [INFO] [stderr] | [INFO] [stderr] 303 | .set_flag_b(BitFlag::C, nth_bit(byte.clone(), 0)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:325:45 [INFO] [stderr] | [INFO] [stderr] 325 | .set_flag_b(BitFlag::C, nth_bit(byte.clone(), 7)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | *byte = *byte << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `*byte <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:161:19 [INFO] [stderr] | [INFO] [stderr] 161 | let val = self.register.get_reg16(reg.clone()) as u32 + imm as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.register.get_reg16(reg.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:161:65 [INFO] [stderr] | [INFO] [stderr] 161 | let val = self.register.get_reg16(reg.clone()) as u32 + imm as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:347:45 [INFO] [stderr] | [INFO] [stderr] 347 | .set_flag_b(BitFlag::C, nth_bit(byte.clone(), 0)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:370:45 [INFO] [stderr] | [INFO] [stderr] 370 | .set_flag_b(BitFlag::C, nth_bit(byte.clone(), 0)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | *byte = *byte >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `*byte >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:189:32 [INFO] [stderr] | [INFO] [stderr] 189 | let newcarry = nth_bit(self.register.a.clone(), 7); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:200:45 [INFO] [stderr] | [INFO] [stderr] 200 | .set_flag_b(BitFlag::C, nth_bit(byte.clone(), 7)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:209:19 [INFO] [stderr] | [INFO] [stderr] 209 | let old = self.register.get_reg8(reg.clone()).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.get_reg8(reg.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:210:19 [INFO] [stderr] | [INFO] [stderr] 210 | let new = old.clone().rotate_left(1); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `old` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:220:32 [INFO] [stderr] | [INFO] [stderr] 220 | let newcarry = nth_bit(self.register.a.clone(), 7); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:233:45 [INFO] [stderr] | [INFO] [stderr] 233 | .set_flag_b(BitFlag::C, nth_bit(byte.clone(), 7)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:418:26 [INFO] [stderr] | [INFO] [stderr] 418 | mask.rotate_left(b as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:245:19 [INFO] [stderr] | [INFO] [stderr] 245 | let new = old.clone() << 1 | carry; [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `old` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:248:45 [INFO] [stderr] | [INFO] [stderr] 248 | .set_flag_b(BitFlag::C, nth_bit(old.clone(), 7)); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `old` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:425:26 [INFO] [stderr] | [INFO] [stderr] 425 | mask.rotate_left(b as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:257:32 [INFO] [stderr] | [INFO] [stderr] 257 | let newcarry = nth_bit(self.register.a.clone(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:442:33 [INFO] [stderr] | [INFO] [stderr] 442 | self.register.pc += ins.clone().get_size() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(ins.clone().get_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:509:46 [INFO] [stderr] | [INFO] [stderr] 509 | let val = mmu.read8(0xff00 | from_lo as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(from_lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:514:37 [INFO] [stderr] | [INFO] [stderr] 514 | mmu.write8(0xff00 | to_lo as u16, val); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(to_lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:517:37 [INFO] [stderr] | [INFO] [stderr] 517 | let addr = 0xff00 | self.register.get_reg8(to_lo_reg) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register.get_reg8(to_lo_reg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:522:27 [INFO] [stderr] | [INFO] [stderr] 522 | let new = self.register [INFO] [stderr] | ___________________________^ [INFO] [stderr] 523 | | .get_reg16(from) [INFO] [stderr] 524 | | .clone() [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try removing the `clone` call [INFO] [stderr] | [INFO] [stderr] 522 | let new = self.register [INFO] [stderr] 523 | .get_reg16(from) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:531:28 [INFO] [stderr] | [INFO] [stderr] 531 | let addr = self.register.get_reg16(reg).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.get_reg16(reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:268:45 [INFO] [stderr] | [INFO] [stderr] 268 | .set_flag_b(BitFlag::C, nth_bit(byte.clone(), 0)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:290:32 [INFO] [stderr] | [INFO] [stderr] 290 | let newcarry = nth_bit(self.register.a.clone(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:303:45 [INFO] [stderr] | [INFO] [stderr] 303 | .set_flag_b(BitFlag::C, nth_bit(byte.clone(), 0)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:325:45 [INFO] [stderr] | [INFO] [stderr] 325 | .set_flag_b(BitFlag::C, nth_bit(byte.clone(), 7)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | *byte = *byte << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `*byte <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:347:45 [INFO] [stderr] | [INFO] [stderr] 347 | .set_flag_b(BitFlag::C, nth_bit(byte.clone(), 0)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:370:45 [INFO] [stderr] | [INFO] [stderr] 370 | .set_flag_b(BitFlag::C, nth_bit(byte.clone(), 0)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:539:28 [INFO] [stderr] | [INFO] [stderr] 539 | let addr = self.register.get_reg16(reg).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.get_reg16(reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:570:17 [INFO] [stderr] | [INFO] [stderr] 570 | self.register.a = self.register.a ^ 0xff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.register.a ^= 0xff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:579:41 [INFO] [stderr] | [INFO] [stderr] 579 | let mut val = mmu.read8(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:586:41 [INFO] [stderr] | [INFO] [stderr] 586 | let mut val = mmu.read8(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:593:41 [INFO] [stderr] | [INFO] [stderr] 593 | let mut val = mmu.read8(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:600:41 [INFO] [stderr] | [INFO] [stderr] 600 | let mut val = mmu.read8(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:607:41 [INFO] [stderr] | [INFO] [stderr] 607 | let mut val = mmu.read8(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:614:41 [INFO] [stderr] | [INFO] [stderr] 614 | let mut val = mmu.read8(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:621:41 [INFO] [stderr] | [INFO] [stderr] 621 | let mut val = mmu.read8(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:647:66 [INFO] [stderr] | [INFO] [stderr] 647 | let val = (self.register.sp as i16).wrapping_add(offset as i16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:653:70 [INFO] [stderr] | [INFO] [stderr] 653 | let val = (self.register.sp as i16).wrapping_add(offset as i16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:660:70 [INFO] [stderr] | [INFO] [stderr] 660 | let val = (self.register.sp as i16).wrapping_add(offset as i16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:742:27 [INFO] [stderr] | [INFO] [stderr] 742 | let val = self.register.get_reg8(from).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.get_reg8(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:752:27 [INFO] [stderr] | [INFO] [stderr] 752 | let val = self.register.get_reg8(reg.clone()) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register.get_reg8(reg.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | *byte = *byte >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `*byte >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:418:26 [INFO] [stderr] | [INFO] [stderr] 418 | mask.rotate_left(b as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:425:26 [INFO] [stderr] | [INFO] [stderr] 425 | mask.rotate_left(b as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:442:33 [INFO] [stderr] | [INFO] [stderr] 442 | self.register.pc += ins.clone().get_size() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(ins.clone().get_size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:509:46 [INFO] [stderr] | [INFO] [stderr] 509 | let val = mmu.read8(0xff00 | from_lo as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(from_lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:514:37 [INFO] [stderr] | [INFO] [stderr] 514 | mmu.write8(0xff00 | to_lo as u16, val); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(to_lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:517:37 [INFO] [stderr] | [INFO] [stderr] 517 | let addr = 0xff00 | self.register.get_reg8(to_lo_reg) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register.get_reg8(to_lo_reg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:522:27 [INFO] [stderr] | [INFO] [stderr] 522 | let new = self.register [INFO] [stderr] | ___________________________^ [INFO] [stderr] 523 | | .get_reg16(from) [INFO] [stderr] 524 | | .clone() [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try removing the `clone` call [INFO] [stderr] | [INFO] [stderr] 522 | let new = self.register [INFO] [stderr] 523 | .get_reg16(from) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:531:28 [INFO] [stderr] | [INFO] [stderr] 531 | let addr = self.register.get_reg16(reg).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.get_reg16(reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:539:28 [INFO] [stderr] | [INFO] [stderr] 539 | let addr = self.register.get_reg16(reg).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.get_reg16(reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:570:17 [INFO] [stderr] | [INFO] [stderr] 570 | self.register.a = self.register.a ^ 0xff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.register.a ^= 0xff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:579:41 [INFO] [stderr] | [INFO] [stderr] 579 | let mut val = mmu.read8(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:586:41 [INFO] [stderr] | [INFO] [stderr] 586 | let mut val = mmu.read8(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:593:41 [INFO] [stderr] | [INFO] [stderr] 593 | let mut val = mmu.read8(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:600:41 [INFO] [stderr] | [INFO] [stderr] 600 | let mut val = mmu.read8(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:607:41 [INFO] [stderr] | [INFO] [stderr] 607 | let mut val = mmu.read8(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:614:41 [INFO] [stderr] | [INFO] [stderr] 614 | let mut val = mmu.read8(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:621:41 [INFO] [stderr] | [INFO] [stderr] 621 | let mut val = mmu.read8(addr.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:647:66 [INFO] [stderr] | [INFO] [stderr] 647 | let val = (self.register.sp as i16).wrapping_add(offset as i16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:653:70 [INFO] [stderr] | [INFO] [stderr] 653 | let val = (self.register.sp as i16).wrapping_add(offset as i16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:660:70 [INFO] [stderr] | [INFO] [stderr] 660 | let val = (self.register.sp as i16).wrapping_add(offset as i16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cpu.rs:742:27 [INFO] [stderr] | [INFO] [stderr] 742 | let val = self.register.get_reg8(from).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.register.get_reg8(from)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:752:27 [INFO] [stderr] | [INFO] [stderr] 752 | let val = self.register.get_reg8(reg.clone()) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register.get_reg8(reg.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.50s [INFO] running `"docker" "inspect" "a4a27edb423b49487e462ac9aeeec30097462e9478cfecbc7716959e9c92bfbc"` [INFO] running `"docker" "rm" "-f" "a4a27edb423b49487e462ac9aeeec30097462e9478cfecbc7716959e9c92bfbc"` [INFO] [stdout] a4a27edb423b49487e462ac9aeeec30097462e9478cfecbc7716959e9c92bfbc