[INFO] updating cached repository Morindhal/apendo_test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Morindhal/apendo_test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Morindhal/apendo_test" "work/ex/clippy-test-run/sources/stable/gh/Morindhal/apendo_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Morindhal/apendo_test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Morindhal/apendo_test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Morindhal/apendo_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Morindhal/apendo_test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b3584fa14c1d609b7dc2ce7c0a63dacfacc91963 [INFO] sha for GitHub repo Morindhal/apendo_test: b3584fa14c1d609b7dc2ce7c0a63dacfacc91963 [INFO] validating manifest of Morindhal/apendo_test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Morindhal/apendo_test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Morindhal/apendo_test [INFO] finished frobbing Morindhal/apendo_test [INFO] frobbed toml for Morindhal/apendo_test written to work/ex/clippy-test-run/sources/stable/gh/Morindhal/apendo_test/Cargo.toml [INFO] started frobbing Morindhal/apendo_test [INFO] finished frobbing Morindhal/apendo_test [INFO] frobbed toml for Morindhal/apendo_test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Morindhal/apendo_test/Cargo.toml [INFO] crate Morindhal/apendo_test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Morindhal/apendo_test against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Morindhal/apendo_test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ac7e81ae1b79a5a5a9d22957f06bf5b80bdeff487b5cecba46ec9e8568432e12 [INFO] running `"docker" "start" "-a" "ac7e81ae1b79a5a5a9d22957f06bf5b80bdeff487b5cecba46ec9e8568432e12"` [INFO] [stderr] Checking apendo_test v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:29:7 [INFO] [stderr] | [INFO] [stderr] 29 | / let mut reverse = false; [INFO] [stderr] 30 | | if bound.0>bound.1 [INFO] [stderr] 31 | | { [INFO] [stderr] 32 | | std::mem::swap(&mut bound.0, &mut bound.1); [INFO] [stderr] 33 | | reverse = true; [INFO] [stderr] 34 | | } [INFO] [stderr] | |_______^ help: it is more idiomatic to write: `let reverse = if bound.0>bound.1 { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | let range = bound.0..(bound.1+1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `bound.0..=bound.1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:49:7 [INFO] [stderr] | [INFO] [stderr] 49 | / let mut reverse = false; [INFO] [stderr] 50 | | if bound.0>bound.1 [INFO] [stderr] 51 | | { [INFO] [stderr] 52 | | std::mem::swap(&mut bound.0, &mut bound.1); [INFO] [stderr] 53 | | reverse = true; [INFO] [stderr] 54 | | } [INFO] [stderr] | |_______^ help: it is more idiomatic to write: `let reverse = if bound.0>bound.1 { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:55:19 [INFO] [stderr] | [INFO] [stderr] 55 | let range = bound.0..(bound.1+1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `bound.0..=bound.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:29:7 [INFO] [stderr] | [INFO] [stderr] 29 | / let mut reverse = false; [INFO] [stderr] 30 | | if bound.0>bound.1 [INFO] [stderr] 31 | | { [INFO] [stderr] 32 | | std::mem::swap(&mut bound.0, &mut bound.1); [INFO] [stderr] 33 | | reverse = true; [INFO] [stderr] 34 | | } [INFO] [stderr] | |_______^ help: it is more idiomatic to write: `let reverse = if bound.0>bound.1 { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | let range = bound.0..(bound.1+1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `bound.0..=bound.1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:49:7 [INFO] [stderr] | [INFO] [stderr] 49 | / let mut reverse = false; [INFO] [stderr] 50 | | if bound.0>bound.1 [INFO] [stderr] 51 | | { [INFO] [stderr] 52 | | std::mem::swap(&mut bound.0, &mut bound.1); [INFO] [stderr] 53 | | reverse = true; [INFO] [stderr] 54 | | } [INFO] [stderr] | |_______^ help: it is more idiomatic to write: `let reverse = if bound.0>bound.1 { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:55:19 [INFO] [stderr] | [INFO] [stderr] 55 | let range = bound.0..(bound.1+1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `bound.0..=bound.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.42s [INFO] running `"docker" "inspect" "ac7e81ae1b79a5a5a9d22957f06bf5b80bdeff487b5cecba46ec9e8568432e12"` [INFO] running `"docker" "rm" "-f" "ac7e81ae1b79a5a5a9d22957f06bf5b80bdeff487b5cecba46ec9e8568432e12"` [INFO] [stdout] ac7e81ae1b79a5a5a9d22957f06bf5b80bdeff487b5cecba46ec9e8568432e12