[INFO] updating cached repository MichaelBlume/crypto-pals
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/MichaelBlume/crypto-pals
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/MichaelBlume/crypto-pals" "work/ex/clippy-test-run/sources/stable/gh/MichaelBlume/crypto-pals"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MichaelBlume/crypto-pals'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/MichaelBlume/crypto-pals" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MichaelBlume/crypto-pals"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MichaelBlume/crypto-pals'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 82c8c0ceb710c01dfbe3fe0b21eeb58bb355ff0b
[INFO] sha for GitHub repo MichaelBlume/crypto-pals: 82c8c0ceb710c01dfbe3fe0b21eeb58bb355ff0b
[INFO] validating manifest of MichaelBlume/crypto-pals on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of MichaelBlume/crypto-pals on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing MichaelBlume/crypto-pals
[INFO] finished frobbing MichaelBlume/crypto-pals
[INFO] frobbed toml for MichaelBlume/crypto-pals written to work/ex/clippy-test-run/sources/stable/gh/MichaelBlume/crypto-pals/Cargo.toml
[INFO] started frobbing MichaelBlume/crypto-pals
[INFO] finished frobbing MichaelBlume/crypto-pals
[INFO] frobbed toml for MichaelBlume/crypto-pals written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MichaelBlume/crypto-pals/Cargo.toml
[INFO] crate MichaelBlume/crypto-pals has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting MichaelBlume/crypto-pals against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MichaelBlume/crypto-pals:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ba9d12a2559a6ee75f9774fa08fa933684751ee12f84a1dc8ad3510979ec1664
[INFO] running `"docker" "start" "-a" "ba9d12a2559a6ee75f9774fa08fa933684751ee12f84a1dc8ad3510979ec1664"`
[INFO] [stderr]     Checking crypto-pals v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: function is never used: `xor_buffers`
[INFO] [stderr]   --> src/main.rs:64:1
[INFO] [stderr]    |
[INFO] [stderr] 64 | fn xor_buffers(s1: &[u8], s2: &[u8], out_buffer: &mut [u8]) {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `hex_byte_to_nibble`
[INFO] [stderr]   --> src/main.rs:73:1
[INFO] [stderr]    |
[INFO] [stderr] 73 | fn hex_byte_to_nibble(b: u8) -> u8 {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `hex_to_bytestring`
[INFO] [stderr]   --> src/main.rs:77:1
[INFO] [stderr]    |
[INFO] [stderr] 77 | fn hex_to_bytestring(s: &[u8]) -> Vec<u8> {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `create_scoring_table`
[INFO] [stderr]   --> src/main.rs:86:1
[INFO] [stderr]    |
[INFO] [stderr] 86 | fn create_scoring_table() -> [u8; 256] {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `score_string_with_key`
[INFO] [stderr]    --> src/main.rs:113:1
[INFO] [stderr]     |
[INFO] [stderr] 113 | fn score_string_with_key(cipher_string: &Vec<u8>, key: u8, score_table: &[u8]) -> i32 {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `decode_string_with_key`
[INFO] [stderr]    --> src/main.rs:123:1
[INFO] [stderr]     |
[INFO] [stderr] 123 | fn decode_string_with_key(cipher_string: &mut Vec<u8>, key: u8) {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `decode_hex_cipher`
[INFO] [stderr]    --> src/main.rs:130:1
[INFO] [stderr]     |
[INFO] [stderr] 130 | fn decode_hex_cipher(s: &[u8]) -> Vec<u8> {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]  --> src/main.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/".as_bytes()
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/"`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/main.rs:25:21
[INFO] [stderr]    |
[INFO] [stderr] 25 |                     io::stdout().write(&out_buffer[0..out_len]).expect("write to stdout");
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             x = x << 4;
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `x <<= 4`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:113:41
[INFO] [stderr]     |
[INFO] [stderr] 113 | fn score_string_with_key(cipher_string: &Vec<u8>, key: u8, score_table: &[u8]) -> i32 {
[INFO] [stderr]     |                                         ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `cipher_string`.
[INFO] [stderr]    --> src/main.rs:115:14
[INFO] [stderr]     |
[INFO] [stderr] 115 |     for i in 0..cipher_string.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 115 |     for <item> in &cipher_string {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:117:26
[INFO] [stderr]     |
[INFO] [stderr] 117 |         let char_score = score_table[char_ind] as i32;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(score_table[char_ind])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `cipher_string`.
[INFO] [stderr]    --> src/main.rs:124:14
[INFO] [stderr]     |
[INFO] [stderr] 124 |     for i in 0..cipher_string.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 124 |     for <item> in &mut cipher_string {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `crypto-pals`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]  --> src/main.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/".as_bytes()
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/"`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/main.rs:25:21
[INFO] [stderr]    |
[INFO] [stderr] 25 |                     io::stdout().write(&out_buffer[0..out_len]).expect("write to stdout");
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             x = x << 4;
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `x <<= 4`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:113:41
[INFO] [stderr]     |
[INFO] [stderr] 113 | fn score_string_with_key(cipher_string: &Vec<u8>, key: u8, score_table: &[u8]) -> i32 {
[INFO] [stderr]     |                                         ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `cipher_string`.
[INFO] [stderr]    --> src/main.rs:115:14
[INFO] [stderr]     |
[INFO] [stderr] 115 |     for i in 0..cipher_string.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 115 |     for <item> in &cipher_string {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:117:26
[INFO] [stderr]     |
[INFO] [stderr] 117 |         let char_score = score_table[char_ind] as i32;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(score_table[char_ind])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `cipher_string`.
[INFO] [stderr]    --> src/main.rs:124:14
[INFO] [stderr]     |
[INFO] [stderr] 124 |     for i in 0..cipher_string.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 124 |     for <item> in &mut cipher_string {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/main.rs:176:40
[INFO] [stderr]     |
[INFO] [stderr] 176 |         let result = decode_hex_cipher("1b37373331363f78151b7f2b783431333d78397828372d363c78373e783a393b3736".as_bytes());
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1b37373331363f78151b7f2b783431333d78397828372d363c78373e783a393b3736"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `crypto-pals`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "ba9d12a2559a6ee75f9774fa08fa933684751ee12f84a1dc8ad3510979ec1664"`
[INFO] running `"docker" "rm" "-f" "ba9d12a2559a6ee75f9774fa08fa933684751ee12f84a1dc8ad3510979ec1664"`
[INFO] [stdout] ba9d12a2559a6ee75f9774fa08fa933684751ee12f84a1dc8ad3510979ec1664