[INFO] updating cached repository MaiaVictor/absal-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/MaiaVictor/absal-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/MaiaVictor/absal-rs" "work/ex/clippy-test-run/sources/stable/gh/MaiaVictor/absal-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/MaiaVictor/absal-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/MaiaVictor/absal-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MaiaVictor/absal-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MaiaVictor/absal-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a48dcff050460c6c98058c6a40b23253219787b9
[INFO] sha for GitHub repo MaiaVictor/absal-rs: a48dcff050460c6c98058c6a40b23253219787b9
[INFO] validating manifest of MaiaVictor/absal-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of MaiaVictor/absal-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing MaiaVictor/absal-rs
[INFO] finished frobbing MaiaVictor/absal-rs
[INFO] frobbed toml for MaiaVictor/absal-rs written to work/ex/clippy-test-run/sources/stable/gh/MaiaVictor/absal-rs/Cargo.toml
[INFO] started frobbing MaiaVictor/absal-rs
[INFO] finished frobbing MaiaVictor/absal-rs
[INFO] frobbed toml for MaiaVictor/absal-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MaiaVictor/absal-rs/Cargo.toml
[INFO] crate MaiaVictor/absal-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting MaiaVictor/absal-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/MaiaVictor/absal-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] babc0b5a4a59bae0fd2032a9c47dac4379e2fb66925acba46d2145adae46985f
[INFO] running `"docker" "start" "-a" "babc0b5a4a59bae0fd2032a9c47dac4379e2fb66925acba46d2145adae46985f"`
[INFO] [stderr]     Checking absal v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/net.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |         let b = new_node(net, t);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/net.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |         let b = new_node(net, t);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/term.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     return name;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/term.rs:149:5
[INFO] [stderr]     |
[INFO] [stderr] 149 |     return code;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `code`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/net.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     return node;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `node`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/term.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     return name;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/term.rs:149:5
[INFO] [stderr]     |
[INFO] [stderr] 149 |     return code;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `code`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/net.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     return node;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `node`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/term.rs:100:17
[INFO] [stderr]     |
[INFO] [stderr] 100 |                 idx = idx + (match &ctx[i].1 { &Some(ref _t) => 0, &None => 1});
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `idx += (match &ctx[i].1 { &Some(ref _t) => 0, &None => 1})`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/term.rs:100:29
[INFO] [stderr]     |
[INFO] [stderr] 100 |                 idx = idx + (match &ctx[i].1 { &Some(ref _t) => 0, &None => 1});
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 100 |                 idx = idx + (match ctx[i].1 { Some(ref _t) => 0, None => 1});
[INFO] [stderr]     |                                    ^^^^^^^^   ^^^^^^^^^^^^       ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/term.rs:108:1
[INFO] [stderr]     |
[INFO] [stderr] 108 | / pub fn from_string<'a>(code : &'a Str) -> Term {
[INFO] [stderr] 109 | |     let mut ctx = Vec::new();
[INFO] [stderr] 110 | |     let (_code, term) = parse_term(code, &mut ctx);
[INFO] [stderr] 111 | |     term
[INFO] [stderr] 112 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/term.rs:119:9
[INFO] [stderr]     |
[INFO] [stderr] 119 |         idx = idx - 1;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: replace it with: `idx -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/term.rs:121:9
[INFO] [stderr]     |
[INFO] [stderr] 121 |         idx = idx / 26;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: replace it with: `idx /= 26`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/term.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 | /         match term {
[INFO] [stderr] 130 | |             &App{ref fun, ref arg} => {
[INFO] [stderr] 131 | |                 code.extend_from_slice(b"/");
[INFO] [stderr] 132 | |                 build(code, &fun, dph);
[INFO] [stderr] ...   |
[INFO] [stderr] 144 | |             },
[INFO] [stderr] 145 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 129 |         match *term {
[INFO] [stderr] 130 |             App{ref fun, ref arg} => {
[INFO] [stderr] 131 |                 code.extend_from_slice(b"/");
[INFO] [stderr] 132 |                 build(code, &fun, dph);
[INFO] [stderr] 133 |                 code.extend_from_slice(b" ");
[INFO] [stderr] 134 |                 build(code, &arg, dph);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/term.rs:198:9
[INFO] [stderr]     |
[INFO] [stderr] 198 | /         match term {
[INFO] [stderr] 199 | |             &App{ref fun, ref arg} => {
[INFO] [stderr] 200 | |                 let app = new_node(net, 1);
[INFO] [stderr] 201 | |                 let fun = encode(net, _kind, scope, fun);
[INFO] [stderr] ...   |
[INFO] [stderr] 231 | |             }
[INFO] [stderr] 232 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 198 |         match *term {
[INFO] [stderr] 199 |             App{ref fun, ref arg} => {
[INFO] [stderr] 200 |                 let app = new_node(net, 1);
[INFO] [stderr] 201 |                 let fun = encode(net, _kind, scope, fun);
[INFO] [stderr] 202 |                 link(net, port(app, 0), fun);
[INFO] [stderr] 203 |                 let arg = encode(net, _kind, scope, arg);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/net.rs:68:25
[INFO] [stderr]    |
[INFO] [stderr] 68 |     while (next > 0) || (warp.len() > 0) {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!warp.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/term.rs:100:17
[INFO] [stderr]     |
[INFO] [stderr] 100 |                 idx = idx + (match &ctx[i].1 { &Some(ref _t) => 0, &None => 1});
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `idx += (match &ctx[i].1 { &Some(ref _t) => 0, &None => 1})`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/term.rs:100:29
[INFO] [stderr]     |
[INFO] [stderr] 100 |                 idx = idx + (match &ctx[i].1 { &Some(ref _t) => 0, &None => 1});
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 100 |                 idx = idx + (match ctx[i].1 { Some(ref _t) => 0, None => 1});
[INFO] [stderr]     |                                    ^^^^^^^^   ^^^^^^^^^^^^       ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/term.rs:108:1
[INFO] [stderr]     |
[INFO] [stderr] 108 | / pub fn from_string<'a>(code : &'a Str) -> Term {
[INFO] [stderr] 109 | |     let mut ctx = Vec::new();
[INFO] [stderr] 110 | |     let (_code, term) = parse_term(code, &mut ctx);
[INFO] [stderr] 111 | |     term
[INFO] [stderr] 112 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/term.rs:119:9
[INFO] [stderr]     |
[INFO] [stderr] 119 |         idx = idx - 1;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: replace it with: `idx -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/term.rs:121:9
[INFO] [stderr]     |
[INFO] [stderr] 121 |         idx = idx / 26;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: replace it with: `idx /= 26`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/term.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 | /         match term {
[INFO] [stderr] 130 | |             &App{ref fun, ref arg} => {
[INFO] [stderr] 131 | |                 code.extend_from_slice(b"/");
[INFO] [stderr] 132 | |                 build(code, &fun, dph);
[INFO] [stderr] ...   |
[INFO] [stderr] 144 | |             },
[INFO] [stderr] 145 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 129 |         match *term {
[INFO] [stderr] 130 |             App{ref fun, ref arg} => {
[INFO] [stderr] 131 |                 code.extend_from_slice(b"/");
[INFO] [stderr] 132 |                 build(code, &fun, dph);
[INFO] [stderr] 133 |                 code.extend_from_slice(b" ");
[INFO] [stderr] 134 |                 build(code, &arg, dph);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/term.rs:198:9
[INFO] [stderr]     |
[INFO] [stderr] 198 | /         match term {
[INFO] [stderr] 199 | |             &App{ref fun, ref arg} => {
[INFO] [stderr] 200 | |                 let app = new_node(net, 1);
[INFO] [stderr] 201 | |                 let fun = encode(net, _kind, scope, fun);
[INFO] [stderr] ...   |
[INFO] [stderr] 231 | |             }
[INFO] [stderr] 232 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 198 |         match *term {
[INFO] [stderr] 199 |             App{ref fun, ref arg} => {
[INFO] [stderr] 200 |                 let app = new_node(net, 1);
[INFO] [stderr] 201 |                 let fun = encode(net, _kind, scope, fun);
[INFO] [stderr] 202 |                 link(net, port(app, 0), fun);
[INFO] [stderr] 203 |                 let arg = encode(net, _kind, scope, arg);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/net.rs:68:25
[INFO] [stderr]    |
[INFO] [stderr] 68 |     while (next > 0) || (warp.len() > 0) {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!warp.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.04s
[INFO] running `"docker" "inspect" "babc0b5a4a59bae0fd2032a9c47dac4379e2fb66925acba46d2145adae46985f"`
[INFO] running `"docker" "rm" "-f" "babc0b5a4a59bae0fd2032a9c47dac4379e2fb66925acba46d2145adae46985f"`
[INFO] [stdout] babc0b5a4a59bae0fd2032a9c47dac4379e2fb66925acba46d2145adae46985f