[INFO] updating cached repository LukeEuler/zombin [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LukeEuler/zombin [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LukeEuler/zombin" "work/ex/clippy-test-run/sources/stable/gh/LukeEuler/zombin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LukeEuler/zombin'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LukeEuler/zombin" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LukeEuler/zombin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LukeEuler/zombin'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d9f3a1e7ba4db8bc39bec57ea8e1bfdae574e694 [INFO] sha for GitHub repo LukeEuler/zombin: d9f3a1e7ba4db8bc39bec57ea8e1bfdae574e694 [INFO] validating manifest of LukeEuler/zombin on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LukeEuler/zombin on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LukeEuler/zombin [INFO] finished frobbing LukeEuler/zombin [INFO] frobbed toml for LukeEuler/zombin written to work/ex/clippy-test-run/sources/stable/gh/LukeEuler/zombin/Cargo.toml [INFO] started frobbing LukeEuler/zombin [INFO] finished frobbing LukeEuler/zombin [INFO] frobbed toml for LukeEuler/zombin written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LukeEuler/zombin/Cargo.toml [INFO] crate LukeEuler/zombin has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LukeEuler/zombin against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LukeEuler/zombin:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fc13a4274f25018e8ca371dc85ab55c049f5b225b4a7c64781f3af7700bb7426 [INFO] running `"docker" "start" "-a" "fc13a4274f25018e8ca371dc85ab55c049f5b225b4a7c64781f3af7700bb7426"` [INFO] [stderr] Checking zombin v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/handler.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | / let mut actual_min = min; [INFO] [stderr] 4 | | if max < min { [INFO] [stderr] 5 | | actual_max = min; [INFO] [stderr] 6 | | actual_min = max; [INFO] [stderr] 7 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let actual_min = if max < min { ..; max } else { min };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/handler.rs:37:8 [INFO] [stderr] | [INFO] [stderr] 37 | if value == 0 as f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(value - 0 as f32).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/handler.rs:37:8 [INFO] [stderr] | [INFO] [stderr] 37 | if value == 0 as f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/handler.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | / let mut actual_min = min; [INFO] [stderr] 4 | | if max < min { [INFO] [stderr] 5 | | actual_max = min; [INFO] [stderr] 6 | | actual_min = max; [INFO] [stderr] 7 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let actual_min = if max < min { ..; max } else { min };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/handler.rs:37:8 [INFO] [stderr] | [INFO] [stderr] 37 | if value == 0 as f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(value - 0 as f32).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/handler.rs:37:8 [INFO] [stderr] | [INFO] [stderr] 37 | if value == 0 as f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `zombin`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `zombin`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fc13a4274f25018e8ca371dc85ab55c049f5b225b4a7c64781f3af7700bb7426"` [INFO] running `"docker" "rm" "-f" "fc13a4274f25018e8ca371dc85ab55c049f5b225b4a7c64781f3af7700bb7426"` [INFO] [stdout] fc13a4274f25018e8ca371dc85ab55c049f5b225b4a7c64781f3af7700bb7426