[INFO] updating cached repository Luke-Draper/DailyProgrammingChallenges [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Luke-Draper/DailyProgrammingChallenges [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Luke-Draper/DailyProgrammingChallenges" "work/ex/clippy-test-run/sources/stable/gh/Luke-Draper/DailyProgrammingChallenges"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Luke-Draper/DailyProgrammingChallenges'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Luke-Draper/DailyProgrammingChallenges" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Luke-Draper/DailyProgrammingChallenges"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Luke-Draper/DailyProgrammingChallenges'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 883a5c904c57401420474106330864c69ecdd570 [INFO] sha for GitHub repo Luke-Draper/DailyProgrammingChallenges: 883a5c904c57401420474106330864c69ecdd570 [INFO] validating manifest of Luke-Draper/DailyProgrammingChallenges on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Luke-Draper/DailyProgrammingChallenges on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Luke-Draper/DailyProgrammingChallenges [INFO] finished frobbing Luke-Draper/DailyProgrammingChallenges [INFO] frobbed toml for Luke-Draper/DailyProgrammingChallenges written to work/ex/clippy-test-run/sources/stable/gh/Luke-Draper/DailyProgrammingChallenges/Cargo.toml [INFO] started frobbing Luke-Draper/DailyProgrammingChallenges [INFO] finished frobbing Luke-Draper/DailyProgrammingChallenges [INFO] frobbed toml for Luke-Draper/DailyProgrammingChallenges written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Luke-Draper/DailyProgrammingChallenges/Cargo.toml [INFO] crate Luke-Draper/DailyProgrammingChallenges has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Luke-Draper/DailyProgrammingChallenges against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Luke-Draper/DailyProgrammingChallenges:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e7ff61b2a831c7c1776eef7b2b0da647e8893c8881283886d4117d5e8023e988 [INFO] running `"docker" "start" "-a" "e7ff61b2a831c7c1776eef7b2b0da647e8893c8881283886d4117d5e8023e988"` [INFO] [stderr] Checking daily_programming_challenges v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/11_11_18.rs:74:2 [INFO] [stderr] | [INFO] [stderr] 74 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `arr2`. [INFO] [stderr] --> src/bin/11_11_18.rs:38:12 [INFO] [stderr] | [INFO] [stderr] 38 | for j in 0..10 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 38 | for in &mut arr2 { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/bin/11_11_18.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | if frequency.get(key).unwrap() > &1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/11_11_18.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | if frequency.get(key).unwrap() > &1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&frequency[key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/11_11_18.rs:74:2 [INFO] [stderr] | [INFO] [stderr] 74 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `arr2`. [INFO] [stderr] --> src/bin/11_11_18.rs:38:12 [INFO] [stderr] | [INFO] [stderr] 38 | for j in 0..10 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 38 | for in &mut arr2 { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/bin/11_11_18.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | if frequency.get(key).unwrap() > &1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/11_11_18.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | if frequency.get(key).unwrap() > &1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&frequency[key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.02s [INFO] running `"docker" "inspect" "e7ff61b2a831c7c1776eef7b2b0da647e8893c8881283886d4117d5e8023e988"` [INFO] running `"docker" "rm" "-f" "e7ff61b2a831c7c1776eef7b2b0da647e8893c8881283886d4117d5e8023e988"` [INFO] [stdout] e7ff61b2a831c7c1776eef7b2b0da647e8893c8881283886d4117d5e8023e988