[INFO] updating cached repository LukasKalbertodt/sort-bench [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LukasKalbertodt/sort-bench [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LukasKalbertodt/sort-bench" "work/ex/clippy-test-run/sources/stable/gh/LukasKalbertodt/sort-bench"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LukasKalbertodt/sort-bench'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LukasKalbertodt/sort-bench" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LukasKalbertodt/sort-bench"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LukasKalbertodt/sort-bench'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 68ceb1210c10e4e9f1a34cf8322ab7ee36269aed [INFO] sha for GitHub repo LukasKalbertodt/sort-bench: 68ceb1210c10e4e9f1a34cf8322ab7ee36269aed [INFO] validating manifest of LukasKalbertodt/sort-bench on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LukasKalbertodt/sort-bench on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LukasKalbertodt/sort-bench [INFO] finished frobbing LukasKalbertodt/sort-bench [INFO] frobbed toml for LukasKalbertodt/sort-bench written to work/ex/clippy-test-run/sources/stable/gh/LukasKalbertodt/sort-bench/Cargo.toml [INFO] started frobbing LukasKalbertodt/sort-bench [INFO] finished frobbing LukasKalbertodt/sort-bench [INFO] frobbed toml for LukasKalbertodt/sort-bench written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LukasKalbertodt/sort-bench/Cargo.toml [INFO] crate LukasKalbertodt/sort-bench has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LukasKalbertodt/sort-bench against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LukasKalbertodt/sort-bench:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eef67587d0248dc51182acfa259df148e6f8934ac8199d35571982f3e48afb8f [INFO] running `"docker" "start" "-a" "eef67587d0248dc51182acfa259df148e6f8934ac8199d35571982f3e48afb8f"` [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking quickcheck v0.6.0 [INFO] [stderr] Checking sort-bench v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `one_element` [INFO] [stderr] --> src/gen.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn one_element(count: usize, elem: T) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `simple_increasing` [INFO] [stderr] --> src/gen.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn simple_increasing(count: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `simple_decreasing` [INFO] [stderr] --> src/gen.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn simple_decreasing(count: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `quick_sort_hoare_center` [INFO] [stderr] --> src/impls/quick.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn $fn_name(arr: &mut [T]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 25 | gen_quick_sort!(quick_sort_hoare_center, partition_hoare, pivot_center); [INFO] [stderr] | ------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `quick_sort_lomuto_center` [INFO] [stderr] --> src/impls/quick.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn $fn_name(arr: &mut [T]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 26 | gen_quick_sort!(quick_sort_lomuto_center, partition_lomuto, pivot_center); [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `pivot_center` [INFO] [stderr] --> src/impls/quick.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | fn pivot_center(arr: &[T]) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `partition_hoare` [INFO] [stderr] --> src/impls/quick.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | fn partition_hoare(arr: &mut [T], pivot_idx: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `partition_lomuto` [INFO] [stderr] --> src/impls/quick.rs:87:1 [INFO] [stderr] | [INFO] [stderr] 87 | fn partition_lomuto(arr: &mut [T], pivot_idx: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bench/mod.rs:46:55 [INFO] [stderr] | [INFO] [stderr] 46 | let ns = duration.as_secs() * 1_000_000_000 + duration.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/impls/quick.rs:55:36 [INFO] [stderr] | [INFO] [stderr] 55 | while l < arr.len() - 1 && &arr[l] <= &arr[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 55 | while l < arr.len() - 1 && arr[l] <= arr[0] { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/impls/quick.rs:61:15 [INFO] [stderr] | [INFO] [stderr] 61 | while &arr[r] > &arr[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 61 | while arr[r] > arr[0] { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/impls/quick.rs:115:12 [INFO] [stderr] | [INFO] [stderr] 115 | if &arr[start_rest] <= &arr[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 115 | if arr[start_rest] <= arr[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bench/mod.rs:46:55 [INFO] [stderr] | [INFO] [stderr] 46 | let ns = duration.as_secs() * 1_000_000_000 + duration.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/impls/quick.rs:55:36 [INFO] [stderr] | [INFO] [stderr] 55 | while l < arr.len() - 1 && &arr[l] <= &arr[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 55 | while l < arr.len() - 1 && arr[l] <= arr[0] { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/impls/quick.rs:61:15 [INFO] [stderr] | [INFO] [stderr] 61 | while &arr[r] > &arr[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 61 | while arr[r] > arr[0] { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/impls/quick.rs:115:12 [INFO] [stderr] | [INFO] [stderr] 115 | if &arr[start_rest] <= &arr[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 115 | if arr[start_rest] <= arr[0] { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.69s [INFO] running `"docker" "inspect" "eef67587d0248dc51182acfa259df148e6f8934ac8199d35571982f3e48afb8f"` [INFO] running `"docker" "rm" "-f" "eef67587d0248dc51182acfa259df148e6f8934ac8199d35571982f3e48afb8f"` [INFO] [stdout] eef67587d0248dc51182acfa259df148e6f8934ac8199d35571982f3e48afb8f