[INFO] updating cached repository LiamClark/rust-cmdline-flag-utillity [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LiamClark/rust-cmdline-flag-utillity [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LiamClark/rust-cmdline-flag-utillity" "work/ex/clippy-test-run/sources/stable/gh/LiamClark/rust-cmdline-flag-utillity"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LiamClark/rust-cmdline-flag-utillity'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LiamClark/rust-cmdline-flag-utillity" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LiamClark/rust-cmdline-flag-utillity"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LiamClark/rust-cmdline-flag-utillity'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2efbba61f670003406a7bbb071a1f8e567099c1e [INFO] sha for GitHub repo LiamClark/rust-cmdline-flag-utillity: 2efbba61f670003406a7bbb071a1f8e567099c1e [INFO] validating manifest of LiamClark/rust-cmdline-flag-utillity on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LiamClark/rust-cmdline-flag-utillity on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LiamClark/rust-cmdline-flag-utillity [INFO] finished frobbing LiamClark/rust-cmdline-flag-utillity [INFO] frobbed toml for LiamClark/rust-cmdline-flag-utillity written to work/ex/clippy-test-run/sources/stable/gh/LiamClark/rust-cmdline-flag-utillity/Cargo.toml [INFO] started frobbing LiamClark/rust-cmdline-flag-utillity [INFO] finished frobbing LiamClark/rust-cmdline-flag-utillity [INFO] frobbed toml for LiamClark/rust-cmdline-flag-utillity written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LiamClark/rust-cmdline-flag-utillity/Cargo.toml [INFO] crate LiamClark/rust-cmdline-flag-utillity has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LiamClark/rust-cmdline-flag-utillity against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LiamClark/rust-cmdline-flag-utillity:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 968bc02600a51a0f85d0ca74ca1ef9ff58dea642932087ff863b5f234094fadc [INFO] running `"docker" "start" "-a" "968bc02600a51a0f85d0ca74ca1ef9ff58dea642932087ff863b5f234094fadc"` [INFO] [stderr] Checking cmdflags v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | let mut map = ArgMap{bools : bools, ints: ints, strings: strings}; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `bools` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:47:45 [INFO] [stderr] | [INFO] [stderr] 47 | let mut map = ArgMap{bools : bools, ints: ints, strings: strings}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ints` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:47:57 [INFO] [stderr] | [INFO] [stderr] 47 | let mut map = ArgMap{bools : bools, ints: ints, strings: strings}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `strings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:157:20 [INFO] [stderr] | [INFO] [stderr] 157 | FlagFormat{bools: bools, ints: ints, strings: strings} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bools` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:157:34 [INFO] [stderr] | [INFO] [stderr] 157 | FlagFormat{bools: bools, ints: ints, strings: strings} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ints` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:157:46 [INFO] [stderr] | [INFO] [stderr] 157 | FlagFormat{bools: bools, ints: ints, strings: strings} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `strings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | let mut map = ArgMap{bools : bools, ints: ints, strings: strings}; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `bools` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:47:45 [INFO] [stderr] | [INFO] [stderr] 47 | let mut map = ArgMap{bools : bools, ints: ints, strings: strings}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ints` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:47:57 [INFO] [stderr] | [INFO] [stderr] 47 | let mut map = ArgMap{bools : bools, ints: ints, strings: strings}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `strings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:157:20 [INFO] [stderr] | [INFO] [stderr] 157 | FlagFormat{bools: bools, ints: ints, strings: strings} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bools` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:157:34 [INFO] [stderr] | [INFO] [stderr] 157 | FlagFormat{bools: bools, ints: ints, strings: strings} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ints` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:157:46 [INFO] [stderr] | [INFO] [stderr] 157 | FlagFormat{bools: bools, ints: ints, strings: strings} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `strings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `FlagFormat` [INFO] [stderr] --> src/tests.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use FlagFormat; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ArgMap` [INFO] [stderr] --> src/tests.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use ArgMap; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `main` [INFO] [stderr] --> src/lib.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | fn main() { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:182:21 [INFO] [stderr] | [INFO] [stderr] 182 | fn is_arg(args: &Vec, s: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/lib.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | args.iter().find(|name| name.trim() == s).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|name| name.trim() == s).is_some()` with `any(|name| name.trim() == s)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:182:21 [INFO] [stderr] | [INFO] [stderr] 182 | fn is_arg(args: &Vec, s: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/lib.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | args.iter().find(|name| name.trim() == s).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|name| name.trim() == s).is_some()` with `any(|name| name.trim() == s)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.91s [INFO] running `"docker" "inspect" "968bc02600a51a0f85d0ca74ca1ef9ff58dea642932087ff863b5f234094fadc"` [INFO] running `"docker" "rm" "-f" "968bc02600a51a0f85d0ca74ca1ef9ff58dea642932087ff863b5f234094fadc"` [INFO] [stdout] 968bc02600a51a0f85d0ca74ca1ef9ff58dea642932087ff863b5f234094fadc