[INFO] updating cached repository Lenkhar/encrypted_chat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Lenkhar/encrypted_chat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Lenkhar/encrypted_chat" "work/ex/clippy-test-run/sources/stable/gh/Lenkhar/encrypted_chat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Lenkhar/encrypted_chat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Lenkhar/encrypted_chat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lenkhar/encrypted_chat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lenkhar/encrypted_chat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aebf00cabbd594832fc608ab3d9882caa17ebd6b [INFO] sha for GitHub repo Lenkhar/encrypted_chat: aebf00cabbd594832fc608ab3d9882caa17ebd6b [INFO] validating manifest of Lenkhar/encrypted_chat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Lenkhar/encrypted_chat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Lenkhar/encrypted_chat [INFO] finished frobbing Lenkhar/encrypted_chat [INFO] frobbed toml for Lenkhar/encrypted_chat written to work/ex/clippy-test-run/sources/stable/gh/Lenkhar/encrypted_chat/Cargo.toml [INFO] started frobbing Lenkhar/encrypted_chat [INFO] finished frobbing Lenkhar/encrypted_chat [INFO] frobbed toml for Lenkhar/encrypted_chat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lenkhar/encrypted_chat/Cargo.toml [INFO] crate Lenkhar/encrypted_chat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Lenkhar/encrypted_chat against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lenkhar/encrypted_chat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 45f7a5bbfa040886ba60ccc2f20165da10ae9629cc5164584649548c3f5792fb [INFO] running `"docker" "start" "-a" "45f7a5bbfa040886ba60ccc2f20165da10ae9629cc5164584649548c3f5792fb"` [INFO] [stderr] Checking num-complex v0.1.39 [INFO] [stderr] Checking num-bigint v0.1.40 [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking encrypted_chat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/small_primes.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | let mut x = power_modulo(a, d, n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/small_primes.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | let mut y: u64 = 0; [INFO] [stderr] | ^ [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/small_primes.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | let mut x = power_modulo(a, d, n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/small_primes.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | let mut y: u64 = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_op.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let mut v: T = zero(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_op.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let q = &r / &rr; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rsa.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let (_, d, _) = big_op::euclide(s_e, s_phi.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/big_op.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let mut v: T = zero(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/big_op.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let q = &r / &rr; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rsa.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let (_, d, _) = big_op::euclide(s_e, s_phi.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/small_primes.rs:56:26 [INFO] [stderr] | [INFO] [stderr] 56 | witness(n, s, d, 1662803) [INFO] [stderr] | ^^^^^^^ help: consider: `1_662_803` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | return candidate; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `candidate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_op.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return (r, u, v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(r, u, v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/small_primes.rs:56:26 [INFO] [stderr] | [INFO] [stderr] 56 | witness(n, s, d, 1662803) [INFO] [stderr] | ^^^^^^^ help: consider: `1_662_803` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_primes.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | return candidate; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `candidate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/big_op.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return (r, u, v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(r, u, v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/small_primes.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | s = s - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `primes`. [INFO] [stderr] --> src/big_primes.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | for i in 0..primes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 14 | for in &mut primes { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/big_primes.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if candidate <= &x { [INFO] [stderr] | ^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/big_primes.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | r = r + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `r += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | io::stdout().flush().ok().expect("Could not flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | io::stdout().flush().ok().expect("Could not flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/small_primes.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | s = s - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `primes`. [INFO] [stderr] --> src/big_primes.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | for i in 0..primes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 14 | for in &mut primes { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/big_primes.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if candidate <= &x { [INFO] [stderr] | ^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/big_primes.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | r = r + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `r += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | io::stdout().flush().ok().expect("Could not flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | io::stdout().flush().ok().expect("Could not flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.10s [INFO] running `"docker" "inspect" "45f7a5bbfa040886ba60ccc2f20165da10ae9629cc5164584649548c3f5792fb"` [INFO] running `"docker" "rm" "-f" "45f7a5bbfa040886ba60ccc2f20165da10ae9629cc5164584649548c3f5792fb"` [INFO] [stdout] 45f7a5bbfa040886ba60ccc2f20165da10ae9629cc5164584649548c3f5792fb