[INFO] updating cached repository Lait-au-Cafe/simulate_automaton [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Lait-au-Cafe/simulate_automaton [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Lait-au-Cafe/simulate_automaton" "work/ex/clippy-test-run/sources/stable/gh/Lait-au-Cafe/simulate_automaton"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Lait-au-Cafe/simulate_automaton'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Lait-au-Cafe/simulate_automaton" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/simulate_automaton"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/simulate_automaton'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a8d06b9c466a9e59f754365a5a323f1f2fbe586c [INFO] sha for GitHub repo Lait-au-Cafe/simulate_automaton: a8d06b9c466a9e59f754365a5a323f1f2fbe586c [INFO] validating manifest of Lait-au-Cafe/simulate_automaton on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Lait-au-Cafe/simulate_automaton on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Lait-au-Cafe/simulate_automaton [INFO] finished frobbing Lait-au-Cafe/simulate_automaton [INFO] frobbed toml for Lait-au-Cafe/simulate_automaton written to work/ex/clippy-test-run/sources/stable/gh/Lait-au-Cafe/simulate_automaton/Cargo.toml [INFO] started frobbing Lait-au-Cafe/simulate_automaton [INFO] finished frobbing Lait-au-Cafe/simulate_automaton [INFO] frobbed toml for Lait-au-Cafe/simulate_automaton written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/simulate_automaton/Cargo.toml [INFO] crate Lait-au-Cafe/simulate_automaton has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Lait-au-Cafe/simulate_automaton against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/simulate_automaton:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 45e6cfa6773952c8413d41d357231d3c6a43becab6a0940ed3693f428d882eeb [INFO] running `"docker" "start" "-a" "45e6cfa6773952c8413d41d357231d3c6a43becab6a0940ed3693f428d882eeb"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking simulate_automaton v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return Node{state: s, path: HashMap::new()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node{state: s, path: HashMap::new()}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return self.path.get(&s).and_then(|i| Some(*i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.path.get(&s).and_then(|i| Some(*i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return Node{state: s, path: HashMap::new()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Node{state: s, path: HashMap::new()}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return self.path.get(&s).and_then(|i| Some(*i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.path.get(&s).and_then(|i| Some(*i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/node.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | .unwrap_or("?".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/node.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | .unwrap_or("?".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:72:35 [INFO] [stderr] | [INFO] [stderr] 72 | let log = log_list.iter() [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 73 | | .filter(|x| (x.node_num == node_ptr) && (x.condition == data.input)) [INFO] [stderr] 74 | | .next(); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|x| (x.node_num == node_ptr) && (x.condition == data.input)).next()` with `find(|x| (x.node_num == node_ptr) && (x.condition == data.input))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/node.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | .unwrap_or("?".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/node.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | .unwrap_or("?".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "?".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:72:35 [INFO] [stderr] | [INFO] [stderr] 72 | let log = log_list.iter() [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 73 | | .filter(|x| (x.node_num == node_ptr) && (x.condition == data.input)) [INFO] [stderr] 74 | | .next(); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|x| (x.node_num == node_ptr) && (x.condition == data.input)).next()` with `find(|x| (x.node_num == node_ptr) && (x.condition == data.input))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.32s [INFO] running `"docker" "inspect" "45e6cfa6773952c8413d41d357231d3c6a43becab6a0940ed3693f428d882eeb"` [INFO] running `"docker" "rm" "-f" "45e6cfa6773952c8413d41d357231d3c6a43becab6a0940ed3693f428d882eeb"` [INFO] [stdout] 45e6cfa6773952c8413d41d357231d3c6a43becab6a0940ed3693f428d882eeb