[INFO] updating cached repository Lait-au-Cafe/search_evil [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Lait-au-Cafe/search_evil [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Lait-au-Cafe/search_evil" "work/ex/clippy-test-run/sources/stable/gh/Lait-au-Cafe/search_evil"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Lait-au-Cafe/search_evil'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Lait-au-Cafe/search_evil" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/search_evil"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/search_evil'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8c610f8a18eccf365b48af3577923c89f005cc58 [INFO] sha for GitHub repo Lait-au-Cafe/search_evil: 8c610f8a18eccf365b48af3577923c89f005cc58 [INFO] validating manifest of Lait-au-Cafe/search_evil on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Lait-au-Cafe/search_evil on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Lait-au-Cafe/search_evil [INFO] finished frobbing Lait-au-Cafe/search_evil [INFO] frobbed toml for Lait-au-Cafe/search_evil written to work/ex/clippy-test-run/sources/stable/gh/Lait-au-Cafe/search_evil/Cargo.toml [INFO] started frobbing Lait-au-Cafe/search_evil [INFO] finished frobbing Lait-au-Cafe/search_evil [INFO] frobbed toml for Lait-au-Cafe/search_evil written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/search_evil/Cargo.toml [INFO] crate Lait-au-Cafe/search_evil has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Lait-au-Cafe/search_evil against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/search_evil:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9e5606fab6243670846e307d383ba421219f2fa40d944807a01724cbec9b09c2 [INFO] running `"docker" "start" "-a" "9e5606fab6243670846e307d383ba421219f2fa40d944807a01724cbec9b09c2"` [INFO] [stderr] Checking list_automata v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node/mod.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | paths: paths [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `paths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | heads: heads}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `heads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node/mod.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | paths: paths [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `paths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | heads: heads}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `heads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node/mod.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | / return Node{ [INFO] [stderr] 11 | | state: self.state, [INFO] [stderr] 12 | | route: self.route.clone()}; [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 10 | Node{ [INFO] [stderr] 11 | state: self.state, [INFO] [stderr] 12 | route: self.route.clone()} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node/mod.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return Path{ [INFO] [stderr] 31 | | from: self.from, [INFO] [stderr] 32 | | to: self.to, [INFO] [stderr] 33 | | condition: self.condition}; [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | Path{ [INFO] [stderr] 31 | from: self.from, [INFO] [stderr] 32 | to: self.to, [INFO] [stderr] 33 | condition: self.condition} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node/mod.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / return Head { [INFO] [stderr] 65 | | node: 0, [INFO] [stderr] 66 | | branch: None, [INFO] [stderr] 67 | | paths: paths [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | Head { [INFO] [stderr] 65 | node: 0, [INFO] [stderr] 66 | branch: None, [INFO] [stderr] 67 | paths: paths [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node/mod.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / return self.paths.iter() [INFO] [stderr] 77 | | .filter(|p| p.from == from && p.condition == cond) [INFO] [stderr] 78 | | .next() [INFO] [stderr] 79 | | .and_then(|n| Some(n.clone())); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 76 | self.paths.iter() [INFO] [stderr] 77 | .filter(|p| p.from == from && p.condition == cond) [INFO] [stderr] 78 | .next() [INFO] [stderr] 79 | .and_then(|n| Some(n.clone())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node/mod.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:31:4 [INFO] [stderr] | [INFO] [stderr] 31 | return (sub_automaton.clone(), count - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(sub_automaton.clone(), count - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:94:4 [INFO] [stderr] | [INFO] [stderr] 94 | return (result, count); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result, count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:121:4 [INFO] [stderr] | [INFO] [stderr] 121 | return count - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `count - 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:160:4 [INFO] [stderr] | [INFO] [stderr] 160 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node/mod.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | / return Node{ [INFO] [stderr] 11 | | state: self.state, [INFO] [stderr] 12 | | route: self.route.clone()}; [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 10 | Node{ [INFO] [stderr] 11 | state: self.state, [INFO] [stderr] 12 | route: self.route.clone()} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node/mod.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return Path{ [INFO] [stderr] 31 | | from: self.from, [INFO] [stderr] 32 | | to: self.to, [INFO] [stderr] 33 | | condition: self.condition}; [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | Path{ [INFO] [stderr] 31 | from: self.from, [INFO] [stderr] 32 | to: self.to, [INFO] [stderr] 33 | condition: self.condition} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node/mod.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / return Head { [INFO] [stderr] 65 | | node: 0, [INFO] [stderr] 66 | | branch: None, [INFO] [stderr] 67 | | paths: paths [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | Head { [INFO] [stderr] 65 | node: 0, [INFO] [stderr] 66 | branch: None, [INFO] [stderr] 67 | paths: paths [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node/mod.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / return self.paths.iter() [INFO] [stderr] 77 | | .filter(|p| p.from == from && p.condition == cond) [INFO] [stderr] 78 | | .next() [INFO] [stderr] 79 | | .and_then(|n| Some(n.clone())); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 76 | self.paths.iter() [INFO] [stderr] 77 | .filter(|p| p.from == from && p.condition == cond) [INFO] [stderr] 78 | .next() [INFO] [stderr] 79 | .and_then(|n| Some(n.clone())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node/mod.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:31:4 [INFO] [stderr] | [INFO] [stderr] 31 | return (sub_automaton.clone(), count - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(sub_automaton.clone(), count - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:94:4 [INFO] [stderr] | [INFO] [stderr] 94 | return (result, count); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result, count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:121:4 [INFO] [stderr] | [INFO] [stderr] 121 | return count - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `count - 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:160:4 [INFO] [stderr] | [INFO] [stderr] 160 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/node/mod.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | return self.paths.iter() [INFO] [stderr] | ________________^ [INFO] [stderr] 77 | | .filter(|p| p.from == from && p.condition == cond) [INFO] [stderr] 78 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|p| p.from == from && p.condition == cond).next()` with `find(|p| p.from == from && p.condition == cond)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/node/mod.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | / match self.get_path(self.node, data.input) { [INFO] [stderr] 124 | | Some(path) => { [INFO] [stderr] 125 | | // 矛盾チェック [INFO] [stderr] 126 | | if node_list[path.to as usize].state != data.output { [INFO] [stderr] ... | [INFO] [stderr] 141 | | } [INFO] [stderr] 142 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | if let Some(path) = self.get_path(self.node, data.input) { [INFO] [stderr] 124 | // 矛盾チェック [INFO] [stderr] 125 | if node_list[path.to as usize].state != data.output { [INFO] [stderr] 126 | // 矛盾 -> headを削除 [INFO] [stderr] 127 | // eprint!("CONTRADICT "); [INFO] [stderr] 128 | return res; // 空のまま返却 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/node/mod.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | let paths = path_list.iter() [INFO] [stderr] | _____________________^ [INFO] [stderr] 150 | | .filter(|p| p.from == self.node [INFO] [stderr] 151 | | && p.condition == data.input [INFO] [stderr] 152 | | && node_list[p.to as usize].state == data.output) [INFO] [stderr] 153 | | .map(|p| p.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 149 | let paths = path_list.iter() [INFO] [stderr] 150 | .filter(|p| p.from == self.node [INFO] [stderr] 151 | && p.condition == data.input [INFO] [stderr] 152 | && node_list[p.to as usize].state == data.output).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node/mod.rs:156:12 [INFO] [stderr] | [INFO] [stderr] 156 | if paths.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/node/mod.rs:177:3 [INFO] [stderr] | [INFO] [stderr] 177 | match self.branch { [INFO] [stderr] | _________^ [INFO] [stderr] 178 | | Some(ref b) => { [INFO] [stderr] 179 | | if !stable_paths.contains(b) { [INFO] [stderr] 180 | | stable_paths.push(b.clone()); [INFO] [stderr] ... | [INFO] [stderr] 184 | | }, [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 177 | if let Some(ref b) = self.branch { [INFO] [stderr] 178 | if !stable_paths.contains(b) { [INFO] [stderr] 179 | stable_paths.push(b.clone()); [INFO] [stderr] 180 | } [INFO] [stderr] 181 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | if count <= 0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using count == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | node_list: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[node::Node]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | if count <= 0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using count == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `data_list` [INFO] [stderr] --> src/main.rs:222:26 [INFO] [stderr] | [INFO] [stderr] 222 | for i in 0..data_size { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 222 | for (i, ) in data_list.iter().enumerate().take(data_size) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | match head.branch { [INFO] [stderr] | _________________^ [INFO] [stderr] 283 | | Some(ref b) => { [INFO] [stderr] 284 | | if !valid_paths.contains(b) [INFO] [stderr] 285 | | && !stable_paths.contains(b) { [INFO] [stderr] ... | [INFO] [stderr] 289 | | None => {}, [INFO] [stderr] 290 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 282 | if let Some(ref b) = head.branch { [INFO] [stderr] 283 | if !valid_paths.contains(b) [INFO] [stderr] 284 | && !stable_paths.contains(b) { [INFO] [stderr] 285 | valid_paths.push(b.clone()); [INFO] [stderr] 286 | } [INFO] [stderr] 287 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `list_automata`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/node/mod.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | return self.paths.iter() [INFO] [stderr] | ________________^ [INFO] [stderr] 77 | | .filter(|p| p.from == from && p.condition == cond) [INFO] [stderr] 78 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|p| p.from == from && p.condition == cond).next()` with `find(|p| p.from == from && p.condition == cond)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/node/mod.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | / match self.get_path(self.node, data.input) { [INFO] [stderr] 124 | | Some(path) => { [INFO] [stderr] 125 | | // 矛盾チェック [INFO] [stderr] 126 | | if node_list[path.to as usize].state != data.output { [INFO] [stderr] ... | [INFO] [stderr] 141 | | } [INFO] [stderr] 142 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | if let Some(path) = self.get_path(self.node, data.input) { [INFO] [stderr] 124 | // 矛盾チェック [INFO] [stderr] 125 | if node_list[path.to as usize].state != data.output { [INFO] [stderr] 126 | // 矛盾 -> headを削除 [INFO] [stderr] 127 | // eprint!("CONTRADICT "); [INFO] [stderr] 128 | return res; // 空のまま返却 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/node/mod.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | let paths = path_list.iter() [INFO] [stderr] | _____________________^ [INFO] [stderr] 150 | | .filter(|p| p.from == self.node [INFO] [stderr] 151 | | && p.condition == data.input [INFO] [stderr] 152 | | && node_list[p.to as usize].state == data.output) [INFO] [stderr] 153 | | .map(|p| p.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 149 | let paths = path_list.iter() [INFO] [stderr] 150 | .filter(|p| p.from == self.node [INFO] [stderr] 151 | && p.condition == data.input [INFO] [stderr] 152 | && node_list[p.to as usize].state == data.output).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node/mod.rs:156:12 [INFO] [stderr] | [INFO] [stderr] 156 | if paths.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/node/mod.rs:177:3 [INFO] [stderr] | [INFO] [stderr] 177 | match self.branch { [INFO] [stderr] | _________^ [INFO] [stderr] 178 | | Some(ref b) => { [INFO] [stderr] 179 | | if !stable_paths.contains(b) { [INFO] [stderr] 180 | | stable_paths.push(b.clone()); [INFO] [stderr] ... | [INFO] [stderr] 184 | | }, [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 177 | if let Some(ref b) = self.branch { [INFO] [stderr] 178 | if !stable_paths.contains(b) { [INFO] [stderr] 179 | stable_paths.push(b.clone()); [INFO] [stderr] 180 | } [INFO] [stderr] 181 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | if count <= 0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using count == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | node_list: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[node::Node]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | if count <= 0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using count == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `data_list` [INFO] [stderr] --> src/main.rs:222:26 [INFO] [stderr] | [INFO] [stderr] 222 | for i in 0..data_size { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 222 | for (i, ) in data_list.iter().enumerate().take(data_size) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | match head.branch { [INFO] [stderr] | _________________^ [INFO] [stderr] 283 | | Some(ref b) => { [INFO] [stderr] 284 | | if !valid_paths.contains(b) [INFO] [stderr] 285 | | && !stable_paths.contains(b) { [INFO] [stderr] ... | [INFO] [stderr] 289 | | None => {}, [INFO] [stderr] 290 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 282 | if let Some(ref b) = head.branch { [INFO] [stderr] 283 | if !valid_paths.contains(b) [INFO] [stderr] 284 | && !stable_paths.contains(b) { [INFO] [stderr] 285 | valid_paths.push(b.clone()); [INFO] [stderr] 286 | } [INFO] [stderr] 287 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `list_automata`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9e5606fab6243670846e307d383ba421219f2fa40d944807a01724cbec9b09c2"` [INFO] running `"docker" "rm" "-f" "9e5606fab6243670846e307d383ba421219f2fa40d944807a01724cbec9b09c2"` [INFO] [stdout] 9e5606fab6243670846e307d383ba421219f2fa40d944807a01724cbec9b09c2