[INFO] updating cached repository Lait-au-Cafe/rabin_karp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Lait-au-Cafe/rabin_karp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Lait-au-Cafe/rabin_karp" "work/ex/clippy-test-run/sources/stable/gh/Lait-au-Cafe/rabin_karp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Lait-au-Cafe/rabin_karp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Lait-au-Cafe/rabin_karp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/rabin_karp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/rabin_karp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 60ee350b7a85bc404bb99629b56d9822b13150e2 [INFO] sha for GitHub repo Lait-au-Cafe/rabin_karp: 60ee350b7a85bc404bb99629b56d9822b13150e2 [INFO] validating manifest of Lait-au-Cafe/rabin_karp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Lait-au-Cafe/rabin_karp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Lait-au-Cafe/rabin_karp [INFO] finished frobbing Lait-au-Cafe/rabin_karp [INFO] frobbed toml for Lait-au-Cafe/rabin_karp written to work/ex/clippy-test-run/sources/stable/gh/Lait-au-Cafe/rabin_karp/Cargo.toml [INFO] started frobbing Lait-au-Cafe/rabin_karp [INFO] finished frobbing Lait-au-Cafe/rabin_karp [INFO] frobbed toml for Lait-au-Cafe/rabin_karp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/rabin_karp/Cargo.toml [INFO] crate Lait-au-Cafe/rabin_karp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Lait-au-Cafe/rabin_karp against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/rabin_karp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] abe8e0e66c0e00a5fca33d077ac6dd330b6c806da9e5b0d71a4e5dad6f10361f [INFO] running `"docker" "start" "-a" "abe8e0e66c0e00a5fca33d077ac6dd330b6c806da9e5b0d71a4e5dad6f10361f"` [INFO] [stderr] Checking num-bigint v0.1.40 [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking rabin_karp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | let mut v = Vec::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | let mut v = Vec::new(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | let m = patt_list.into_iter().map(|arr| arr.len()).max().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | if m != patt_list.into_iter().map(|arr| arr.len()).min().unwrap() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `text` [INFO] [stderr] --> src/main.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | for i in 0..m { // O(m) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 29 | for (i, ) in text.iter().enumerate().take(m) { // O(m) [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | ht = ht * BASE + (text[i] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(text[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | for (i, arr) in patt_list.into_iter().enumerate() { // O(l) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | let h = arr.into_iter().scan(0, |state, &x| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:38 [INFO] [stderr] | [INFO] [stderr] 37 | *state = *state * BASE + (x as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:61:14 [INFO] [stderr] | [INFO] [stderr] 61 | for i in 0..n-m+1 { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=n-m` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match hp_list.get(&ht) { // O(n-m) [INFO] [stderr] 64 | | Some(v) => { [INFO] [stderr] 65 | | for &j in v { [INFO] [stderr] 66 | | let mut flag = true; [INFO] [stderr] ... | [INFO] [stderr] 78 | | None => {} [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | if let Some(v) = hp_list.get(&ht) { [INFO] [stderr] 64 | for &j in v { [INFO] [stderr] 65 | let mut flag = true; [INFO] [stderr] 66 | let patt: &[u8] = patt_list[j]; [INFO] [stderr] 67 | for k in 0..m { // O((n-m)m) [INFO] [stderr] 68 | debug_assert!(i+k < n); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | flag = flag & (text[i+k] == (patt[k] as u8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flag &= (text[i+k] == (patt[k] as u8))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | ht = (ht - (text[i] as u64) * pad) * BASE + (text[i+m] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(text[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:53 [INFO] [stderr] | [INFO] [stderr] 87 | ht = (ht - (text[i] as u64) * pad) * BASE + (text[i+m] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(text[i+m])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:112:30 [INFO] [stderr] | [INFO] [stderr] 112 | let patt_list = patterns.into_iter().map(|s| s.as_bytes()).collect::>(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | let m = patt_list.into_iter().map(|arr| arr.len()).max().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | if m != patt_list.into_iter().map(|arr| arr.len()).min().unwrap() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `text` [INFO] [stderr] --> src/main.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | for i in 0..m { // O(m) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 29 | for (i, ) in text.iter().enumerate().take(m) { // O(m) [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | ht = ht * BASE + (text[i] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(text[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | for (i, arr) in patt_list.into_iter().enumerate() { // O(l) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | let h = arr.into_iter().scan(0, |state, &x| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:38 [INFO] [stderr] | [INFO] [stderr] 37 | *state = *state * BASE + (x as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:61:14 [INFO] [stderr] | [INFO] [stderr] 61 | for i in 0..n-m+1 { [INFO] [stderr] | ^^^^^^^^ help: use: `0..=n-m` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match hp_list.get(&ht) { // O(n-m) [INFO] [stderr] 64 | | Some(v) => { [INFO] [stderr] 65 | | for &j in v { [INFO] [stderr] 66 | | let mut flag = true; [INFO] [stderr] ... | [INFO] [stderr] 78 | | None => {} [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | if let Some(v) = hp_list.get(&ht) { [INFO] [stderr] 64 | for &j in v { [INFO] [stderr] 65 | let mut flag = true; [INFO] [stderr] 66 | let patt: &[u8] = patt_list[j]; [INFO] [stderr] 67 | for k in 0..m { // O((n-m)m) [INFO] [stderr] 68 | debug_assert!(i+k < n); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | flag = flag & (text[i+k] == (patt[k] as u8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flag &= (text[i+k] == (patt[k] as u8))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | ht = (ht - (text[i] as u64) * pad) * BASE + (text[i+m] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(text[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:53 [INFO] [stderr] | [INFO] [stderr] 87 | ht = (ht - (text[i] as u64) * pad) * BASE + (text[i+m] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(text[i+m])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:112:30 [INFO] [stderr] | [INFO] [stderr] 112 | let patt_list = patterns.into_iter().map(|s| s.as_bytes()).collect::>(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.46s [INFO] running `"docker" "inspect" "abe8e0e66c0e00a5fca33d077ac6dd330b6c806da9e5b0d71a4e5dad6f10361f"` [INFO] running `"docker" "rm" "-f" "abe8e0e66c0e00a5fca33d077ac6dd330b6c806da9e5b0d71a4e5dad6f10361f"` [INFO] [stdout] abe8e0e66c0e00a5fca33d077ac6dd330b6c806da9e5b0d71a4e5dad6f10361f