[INFO] updating cached repository Lait-au-Cafe/boyer_moore [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Lait-au-Cafe/boyer_moore [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Lait-au-Cafe/boyer_moore" "work/ex/clippy-test-run/sources/stable/gh/Lait-au-Cafe/boyer_moore"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Lait-au-Cafe/boyer_moore'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Lait-au-Cafe/boyer_moore" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/boyer_moore"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/boyer_moore'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4874af39421446b34fa8a5c9b51f46f63b487695 [INFO] sha for GitHub repo Lait-au-Cafe/boyer_moore: 4874af39421446b34fa8a5c9b51f46f63b487695 [INFO] validating manifest of Lait-au-Cafe/boyer_moore on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Lait-au-Cafe/boyer_moore on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Lait-au-Cafe/boyer_moore [INFO] finished frobbing Lait-au-Cafe/boyer_moore [INFO] frobbed toml for Lait-au-Cafe/boyer_moore written to work/ex/clippy-test-run/sources/stable/gh/Lait-au-Cafe/boyer_moore/Cargo.toml [INFO] started frobbing Lait-au-Cafe/boyer_moore [INFO] finished frobbing Lait-au-Cafe/boyer_moore [INFO] frobbed toml for Lait-au-Cafe/boyer_moore written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/boyer_moore/Cargo.toml [INFO] crate Lait-au-Cafe/boyer_moore has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Lait-au-Cafe/boyer_moore against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Lait-au-Cafe/boyer_moore:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f09f88919ccc27f4b8c65b6571c316f1ca2ace2274a111494e2ee2752193e640 [INFO] running `"docker" "start" "-a" "f09f88919ccc27f4b8c65b6571c316f1ca2ace2274a111494e2ee2752193e640"` [INFO] [stderr] Checking boyer_moore v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | let m = patt_list.into_iter().map(|arr| arr.len()).max().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | if m != patt_list.into_iter().map(|arr| arr.len()).min().unwrap() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `tab` [INFO] [stderr] --> src/main.rs:60:26 [INFO] [stderr] | [INFO] [stderr] 60 | for k in 0..disp { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 60 | for (k, ) in tab.iter_mut().enumerate().take(disp) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:82:32 [INFO] [stderr] | [INFO] [stderr] 82 | for (k, patt) in patt_list.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | sub = sub+1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `sub += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | pos = pos+1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:129:30 [INFO] [stderr] | [INFO] [stderr] 129 | let patt_list = patterns.into_iter().map(|s| s.as_bytes()).collect::>(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | let m = patt_list.into_iter().map(|arr| arr.len()).max().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | if m != patt_list.into_iter().map(|arr| arr.len()).min().unwrap() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `tab` [INFO] [stderr] --> src/main.rs:60:26 [INFO] [stderr] | [INFO] [stderr] 60 | for k in 0..disp { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 60 | for (k, ) in tab.iter_mut().enumerate().take(disp) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:82:32 [INFO] [stderr] | [INFO] [stderr] 82 | for (k, patt) in patt_list.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | sub = sub+1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `sub += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | pos = pos+1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:129:30 [INFO] [stderr] | [INFO] [stderr] 129 | let patt_list = patterns.into_iter().map(|s| s.as_bytes()).collect::>(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.52s [INFO] running `"docker" "inspect" "f09f88919ccc27f4b8c65b6571c316f1ca2ace2274a111494e2ee2752193e640"` [INFO] running `"docker" "rm" "-f" "f09f88919ccc27f4b8c65b6571c316f1ca2ace2274a111494e2ee2752193e640"` [INFO] [stdout] f09f88919ccc27f4b8c65b6571c316f1ca2ace2274a111494e2ee2752193e640