[INFO] updating cached repository LLBlumire/mimir [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/LLBlumire/mimir [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/LLBlumire/mimir" "work/ex/clippy-test-run/sources/stable/gh/LLBlumire/mimir"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/LLBlumire/mimir'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/LLBlumire/mimir" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LLBlumire/mimir"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LLBlumire/mimir'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8a51aa355d89fcfc0fbe131df0783c0358f8570d [INFO] sha for GitHub repo LLBlumire/mimir: 8a51aa355d89fcfc0fbe131df0783c0358f8570d [INFO] validating manifest of LLBlumire/mimir on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of LLBlumire/mimir on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing LLBlumire/mimir [INFO] finished frobbing LLBlumire/mimir [INFO] frobbed toml for LLBlumire/mimir written to work/ex/clippy-test-run/sources/stable/gh/LLBlumire/mimir/Cargo.toml [INFO] started frobbing LLBlumire/mimir [INFO] finished frobbing LLBlumire/mimir [INFO] frobbed toml for LLBlumire/mimir written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LLBlumire/mimir/Cargo.toml [INFO] crate LLBlumire/mimir has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting LLBlumire/mimir against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/LLBlumire/mimir:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aee2146fc0065ec2e4ee9baa480312f1ba31fb6f4843f6aa859cce96c78e2645 [INFO] running `"docker" "start" "-a" "aee2146fc0065ec2e4ee9baa480312f1ba31fb6f4843f6aa859cce96c78e2645"` [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking mimir v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::io::Read; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/token.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | return !(n == '"'); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!(n == '"')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/token.rs:80:25 [INFO] [stderr] | [INFO] [stderr] 80 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/object.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::io::Read; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/token.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | return !(n == '"'); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!(n == '"')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/token.rs:80:25 [INFO] [stderr] | [INFO] [stderr] 80 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/object.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/main.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | if let Some(matches) = matches.subcommand_matches("live") { [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/main.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | if let Some(matches) = matches.subcommand_matches("build") { [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `re_add` is never read [INFO] [stderr] --> src/mimir.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | let mut re_add = false; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Type` [INFO] [stderr] --> src/object.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Type(Type), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Void` [INFO] [stderr] --> src/object.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Void(Type), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `List` [INFO] [stderr] --> src/object.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | List(Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LocalFunction` [INFO] [stderr] --> src/object.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | LocalFunction(StackFrame), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_type` [INFO] [stderr] --> src/object.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | fn to_type(&self) -> Type { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Text` [INFO] [stderr] --> src/object.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | Text, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Float` [INFO] [stderr] --> src/object.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Float, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Number` [INFO] [stderr] --> src/object.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | Number, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Type` [INFO] [stderr] --> src/object.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | Type, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `List` [INFO] [stderr] --> src/object.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | List, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Function` [INFO] [stderr] --> src/object.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | Function, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Symbol` [INFO] [stderr] --> src/object.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | Symbol, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mimir.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | / match token { [INFO] [stderr] 36 | | &Token::Symbol(ref sym) => { [INFO] [stderr] 37 | | let mut symdup = None; [INFO] [stderr] 38 | | for pool in self.names.iter().rev() { [INFO] [stderr] ... | [INFO] [stderr] 74 | | _ => {} [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *token { [INFO] [stderr] 36 | Token::Symbol(ref sym) => { [INFO] [stderr] 37 | let mut symdup = None; [INFO] [stderr] 38 | for pool in self.names.iter().rev() { [INFO] [stderr] 39 | symdup = pool.get(sym); [INFO] [stderr] 40 | if symdup.is_some() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mimir.rs:62:33 [INFO] [stderr] | [INFO] [stderr] 62 | / if let &Object::Symbol(ref sym) = bind_name.deref() { [INFO] [stderr] 63 | | self.names.last_mut().expect("Unexepected stack error").insert(sym.clone(), val); [INFO] [stderr] 64 | | } else { [INFO] [stderr] 65 | | panic!("Cannot bind to non symbol"); [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | if let Object::Symbol(ref sym) = *bind_name.deref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mimir.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | / if let &mut Some(ref mut this_frame) = &mut this_frame { [INFO] [stderr] 83 | | if let &mut Some(ref mut last_frame) = &mut last_frame { [INFO] [stderr] 84 | | last_frame.append(this_frame) [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 82 | if let Some(ref mut this_frame) = *(&mut this_frame) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mimir.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | / if let &mut Some(ref mut last_frame) = &mut last_frame { [INFO] [stderr] 84 | | last_frame.append(this_frame) [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 83 | if let Some(ref mut last_frame) = *(&mut last_frame) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/token.rs:77:32 [INFO] [stderr] | [INFO] [stderr] 77 | return !(n == '"'); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `n != '"'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/token.rs:135:26 [INFO] [stderr] | [INFO] [stderr] 135 | fn is_reserved_symbol(c: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/object.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &Object::Text(_) => Type::Text, [INFO] [stderr] 23 | | &Object::Float(_) => Type::Float, [INFO] [stderr] 24 | | &Object::Number(_) => Type::Number, [INFO] [stderr] ... | [INFO] [stderr] 30 | | &Object::Symbol(_) => Type::Symbol, [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | Object::Text(_) => Type::Text, [INFO] [stderr] 23 | Object::Float(_) => Type::Float, [INFO] [stderr] 24 | Object::Number(_) => Type::Number, [INFO] [stderr] 25 | Object::Type(_) => Type::Type, [INFO] [stderr] 26 | Object::Void(t) => t, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | stdout.write(b">> "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | stdout.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/main.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | if let Some(matches) = matches.subcommand_matches("live") { [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/main.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | if let Some(matches) = matches.subcommand_matches("build") { [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `re_add` is never read [INFO] [stderr] --> src/mimir.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | let mut re_add = false; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Type` [INFO] [stderr] --> src/object.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Type(Type), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Void` [INFO] [stderr] --> src/object.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Void(Type), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `List` [INFO] [stderr] --> src/object.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | List(Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LocalFunction` [INFO] [stderr] --> src/object.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | LocalFunction(StackFrame), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_type` [INFO] [stderr] --> src/object.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | fn to_type(&self) -> Type { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Text` [INFO] [stderr] --> src/object.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | Text, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Float` [INFO] [stderr] --> src/object.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Float, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Number` [INFO] [stderr] --> src/object.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | Number, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Type` [INFO] [stderr] --> src/object.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | Type, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `List` [INFO] [stderr] --> src/object.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | List, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Function` [INFO] [stderr] --> src/object.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | Function, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Symbol` [INFO] [stderr] --> src/object.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | Symbol, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mimir.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | / match token { [INFO] [stderr] 36 | | &Token::Symbol(ref sym) => { [INFO] [stderr] 37 | | let mut symdup = None; [INFO] [stderr] 38 | | for pool in self.names.iter().rev() { [INFO] [stderr] ... | [INFO] [stderr] 74 | | _ => {} [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *token { [INFO] [stderr] 36 | Token::Symbol(ref sym) => { [INFO] [stderr] 37 | let mut symdup = None; [INFO] [stderr] 38 | for pool in self.names.iter().rev() { [INFO] [stderr] 39 | symdup = pool.get(sym); [INFO] [stderr] 40 | if symdup.is_some() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mimir.rs:62:33 [INFO] [stderr] | [INFO] [stderr] 62 | / if let &Object::Symbol(ref sym) = bind_name.deref() { [INFO] [stderr] 63 | | self.names.last_mut().expect("Unexepected stack error").insert(sym.clone(), val); [INFO] [stderr] 64 | | } else { [INFO] [stderr] 65 | | panic!("Cannot bind to non symbol"); [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | if let Object::Symbol(ref sym) = *bind_name.deref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mimir.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | / if let &mut Some(ref mut this_frame) = &mut this_frame { [INFO] [stderr] 83 | | if let &mut Some(ref mut last_frame) = &mut last_frame { [INFO] [stderr] 84 | | last_frame.append(this_frame) [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 82 | if let Some(ref mut this_frame) = *(&mut this_frame) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mimir.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | / if let &mut Some(ref mut last_frame) = &mut last_frame { [INFO] [stderr] 84 | | last_frame.append(this_frame) [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 83 | if let Some(ref mut last_frame) = *(&mut last_frame) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/token.rs:77:32 [INFO] [stderr] | [INFO] [stderr] 77 | return !(n == '"'); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `n != '"'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/token.rs:135:26 [INFO] [stderr] | [INFO] [stderr] 135 | fn is_reserved_symbol(c: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/object.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &Object::Text(_) => Type::Text, [INFO] [stderr] 23 | | &Object::Float(_) => Type::Float, [INFO] [stderr] 24 | | &Object::Number(_) => Type::Number, [INFO] [stderr] ... | [INFO] [stderr] 30 | | &Object::Symbol(_) => Type::Symbol, [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | Object::Text(_) => Type::Text, [INFO] [stderr] 23 | Object::Float(_) => Type::Float, [INFO] [stderr] 24 | Object::Number(_) => Type::Number, [INFO] [stderr] 25 | Object::Type(_) => Type::Type, [INFO] [stderr] 26 | Object::Void(t) => t, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | stdout.write(b">> "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | stdout.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.81s [INFO] running `"docker" "inspect" "aee2146fc0065ec2e4ee9baa480312f1ba31fb6f4843f6aa859cce96c78e2645"` [INFO] running `"docker" "rm" "-f" "aee2146fc0065ec2e4ee9baa480312f1ba31fb6f4843f6aa859cce96c78e2645"` [INFO] [stdout] aee2146fc0065ec2e4ee9baa480312f1ba31fb6f4843f6aa859cce96c78e2645