[INFO] updating cached repository KuabeM/working-time-calculator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/KuabeM/working-time-calculator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/KuabeM/working-time-calculator" "work/ex/clippy-test-run/sources/stable/gh/KuabeM/working-time-calculator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/KuabeM/working-time-calculator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/KuabeM/working-time-calculator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KuabeM/working-time-calculator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KuabeM/working-time-calculator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ae8e54c25caec34c3fbb549d8e2c321abe6004e0 [INFO] sha for GitHub repo KuabeM/working-time-calculator: ae8e54c25caec34c3fbb549d8e2c321abe6004e0 [INFO] validating manifest of KuabeM/working-time-calculator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of KuabeM/working-time-calculator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing KuabeM/working-time-calculator [INFO] finished frobbing KuabeM/working-time-calculator [INFO] frobbed toml for KuabeM/working-time-calculator written to work/ex/clippy-test-run/sources/stable/gh/KuabeM/working-time-calculator/Cargo.toml [INFO] started frobbing KuabeM/working-time-calculator [INFO] finished frobbing KuabeM/working-time-calculator [INFO] frobbed toml for KuabeM/working-time-calculator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KuabeM/working-time-calculator/Cargo.toml [INFO] crate KuabeM/working-time-calculator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting KuabeM/working-time-calculator against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KuabeM/working-time-calculator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4e5510d64b5daaad5d0d368b83eb9cddf02e1c751d901ad6f1fe8a7860878a2c [INFO] running `"docker" "start" "-a" "4e5510d64b5daaad5d0d368b83eb9cddf02e1c751d901ad6f1fe8a7860878a2c"` [INFO] [stderr] Checking working-time-calc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: value assigned to `content` is never read [INFO] [stderr] --> src/main.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | let mut content = String::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | let mut content_opt = match read_file_to_string( &file_name) { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `content` is never read [INFO] [stderr] --> src/main.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | let mut content = String::new(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:67:20 [INFO] [stderr] | [INFO] [stderr] 67 | let min = ((&self.duration - hour) * 60.0) as i32; [INFO] [stderr] | ^--------------^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `self.duration` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | let mut content_opt = match read_file_to_string( &file_name) { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / let mut content = String::new(); [INFO] [stderr] 118 | | if content_opt == None { [INFO] [stderr] 119 | | content = dat.to_string(); [INFO] [stderr] 120 | | } else { [INFO] [stderr] 121 | | content = format!("{}{}", content_opt.unwrap(), &dat.to_string() ); [INFO] [stderr] 122 | | content.push_str("\n"); [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let content = if content_opt == None { dat.to_string() } else { ..; String::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | storage.write( content.as_bytes()).expect("Write time fo file: Error"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:21 [INFO] [stderr] | [INFO] [stderr] 147 | res.duration = now.tm_hour as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.tm_hour)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:148:27 [INFO] [stderr] | [INFO] [stderr] 148 | + (now.tm_min as f64)/60.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.tm_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:192:25 [INFO] [stderr] | [INFO] [stderr] 192 | let starting_time = now.tm_hour as f64 + (now.tm_min as f64)/60.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.tm_hour)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:192:46 [INFO] [stderr] | [INFO] [stderr] 192 | let starting_time = now.tm_hour as f64 + (now.tm_min as f64)/60.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.tm_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | storage.write( content.as_bytes()).expect("Deleting start time: Could not write back."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:225:21 [INFO] [stderr] | [INFO] [stderr] 225 | fn get_td( content: &String ) -> TimeDuration { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:304:25 [INFO] [stderr] | [INFO] [stderr] 304 | fn get_months( line_td: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[TimeDuration]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:67:20 [INFO] [stderr] | [INFO] [stderr] 67 | let min = ((&self.duration - hour) * 60.0) as i32; [INFO] [stderr] | ^--------------^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `self.duration` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: Could not compile `working-time-calc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / let mut content = String::new(); [INFO] [stderr] 118 | | if content_opt == None { [INFO] [stderr] 119 | | content = dat.to_string(); [INFO] [stderr] 120 | | } else { [INFO] [stderr] 121 | | content = format!("{}{}", content_opt.unwrap(), &dat.to_string() ); [INFO] [stderr] 122 | | content.push_str("\n"); [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let content = if content_opt == None { dat.to_string() } else { ..; String::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | storage.write( content.as_bytes()).expect("Write time fo file: Error"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:21 [INFO] [stderr] | [INFO] [stderr] 147 | res.duration = now.tm_hour as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.tm_hour)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:148:27 [INFO] [stderr] | [INFO] [stderr] 148 | + (now.tm_min as f64)/60.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.tm_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:192:25 [INFO] [stderr] | [INFO] [stderr] 192 | let starting_time = now.tm_hour as f64 + (now.tm_min as f64)/60.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.tm_hour)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:192:46 [INFO] [stderr] | [INFO] [stderr] 192 | let starting_time = now.tm_hour as f64 + (now.tm_min as f64)/60.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.tm_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | storage.write( content.as_bytes()).expect("Deleting start time: Could not write back."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:225:21 [INFO] [stderr] | [INFO] [stderr] 225 | fn get_td( content: &String ) -> TimeDuration { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:304:25 [INFO] [stderr] | [INFO] [stderr] 304 | fn get_months( line_td: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[TimeDuration]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `working-time-calc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4e5510d64b5daaad5d0d368b83eb9cddf02e1c751d901ad6f1fe8a7860878a2c"` [INFO] running `"docker" "rm" "-f" "4e5510d64b5daaad5d0d368b83eb9cddf02e1c751d901ad6f1fe8a7860878a2c"` [INFO] [stdout] 4e5510d64b5daaad5d0d368b83eb9cddf02e1c751d901ad6f1fe8a7860878a2c