[INFO] updating cached repository KingOfThePirates/practice_game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/KingOfThePirates/practice_game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/KingOfThePirates/practice_game" "work/ex/clippy-test-run/sources/stable/gh/KingOfThePirates/practice_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/KingOfThePirates/practice_game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/KingOfThePirates/practice_game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KingOfThePirates/practice_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KingOfThePirates/practice_game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4f460f8f9e42423b1e963fadf212f64ddb56af8a [INFO] sha for GitHub repo KingOfThePirates/practice_game: 4f460f8f9e42423b1e963fadf212f64ddb56af8a [INFO] validating manifest of KingOfThePirates/practice_game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of KingOfThePirates/practice_game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing KingOfThePirates/practice_game [INFO] finished frobbing KingOfThePirates/practice_game [INFO] frobbed toml for KingOfThePirates/practice_game written to work/ex/clippy-test-run/sources/stable/gh/KingOfThePirates/practice_game/Cargo.toml [INFO] started frobbing KingOfThePirates/practice_game [INFO] finished frobbing KingOfThePirates/practice_game [INFO] frobbed toml for KingOfThePirates/practice_game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KingOfThePirates/practice_game/Cargo.toml [INFO] crate KingOfThePirates/practice_game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting KingOfThePirates/practice_game against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KingOfThePirates/practice_game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3893bbc85031479c4c602b7758c5a71baf1f5af13897b3433d283e7e8ef59db [INFO] running `"docker" "start" "-a" "c3893bbc85031479c4c602b7758c5a71baf1f5af13897b3433d283e7e8ef59db"` [INFO] [stderr] Checking practice_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | println!(""); } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | println!(""); } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | const GAME_NAME: &'static str = "Fighter"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | const GAME_NAME: &'static str = "Fighter"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | let ref enemy = in_game_data.enemy; [INFO] [stderr] | ----^^^^^^^^^---------------------- help: try: `let enemy = &in_game_data.enemy;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | let ref player = in_game_data.player; [INFO] [stderr] | ----^^^^^^^^^^----------------------- help: try: `let player = &in_game_data.player;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | let ref enemy = in_game_data.enemy; [INFO] [stderr] | ----^^^^^^^^^---------------------- help: try: `let enemy = &in_game_data.enemy;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | let ref player = in_game_data.player; [INFO] [stderr] | ----^^^^^^^^^^----------------------- help: try: `let player = &in_game_data.player;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | let ref enemy = in_game_data.realize_enemy(); [INFO] [stderr] | ----^^^^^^^^^-------------------------------- help: try: `let enemy = &in_game_data.realize_enemy();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | let ref player = in_game_data.realize_player(); [INFO] [stderr] | ----^^^^^^^^^^--------------------------------- help: try: `let player = &in_game_data.realize_player();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | let ref player = cloned_game_data.player; [INFO] [stderr] | ----^^^^^^^^^^--------------------------- help: try: `let player = &cloned_game_data.player;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | let ref mut enemy = in_game_data.enemy; [INFO] [stderr] | ----^^^^^^^^^^^^^---------------------- help: try: `let enemy = &mut in_game_data.enemy;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | let ref enemy = in_game_data.enemy; [INFO] [stderr] | ----^^^^^^^^^---------------------- help: try: `let enemy = &in_game_data.enemy;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | let ref player = in_game_data.player; [INFO] [stderr] | ----^^^^^^^^^^----------------------- help: try: `let player = &in_game_data.player;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | let ref enemy = in_game_data.enemy; [INFO] [stderr] | ----^^^^^^^^^---------------------- help: try: `let enemy = &in_game_data.enemy;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | let ref player = in_game_data.player; [INFO] [stderr] | ----^^^^^^^^^^----------------------- help: try: `let player = &in_game_data.player;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | let ref enemy = in_game_data.realize_enemy(); [INFO] [stderr] | ----^^^^^^^^^-------------------------------- help: try: `let enemy = &in_game_data.realize_enemy();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | let ref player = in_game_data.realize_player(); [INFO] [stderr] | ----^^^^^^^^^^--------------------------------- help: try: `let player = &in_game_data.realize_player();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | let ref player = cloned_game_data.player; [INFO] [stderr] | ----^^^^^^^^^^--------------------------- help: try: `let player = &cloned_game_data.player;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | let ref mut enemy = in_game_data.enemy; [INFO] [stderr] | ----^^^^^^^^^^^^^---------------------- help: try: `let enemy = &mut in_game_data.enemy;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.24s [INFO] running `"docker" "inspect" "c3893bbc85031479c4c602b7758c5a71baf1f5af13897b3433d283e7e8ef59db"` [INFO] running `"docker" "rm" "-f" "c3893bbc85031479c4c602b7758c5a71baf1f5af13897b3433d283e7e8ef59db"` [INFO] [stdout] c3893bbc85031479c4c602b7758c5a71baf1f5af13897b3433d283e7e8ef59db