[INFO] updating cached repository Keruspe/brainfuck.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Keruspe/brainfuck.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Keruspe/brainfuck.rs" "work/ex/clippy-test-run/sources/stable/gh/Keruspe/brainfuck.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Keruspe/brainfuck.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Keruspe/brainfuck.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Keruspe/brainfuck.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Keruspe/brainfuck.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bcb3b1bd6de134b68dc72cbed63fd7276a210ec7 [INFO] sha for GitHub repo Keruspe/brainfuck.rs: bcb3b1bd6de134b68dc72cbed63fd7276a210ec7 [INFO] validating manifest of Keruspe/brainfuck.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Keruspe/brainfuck.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Keruspe/brainfuck.rs [INFO] finished frobbing Keruspe/brainfuck.rs [INFO] frobbed toml for Keruspe/brainfuck.rs written to work/ex/clippy-test-run/sources/stable/gh/Keruspe/brainfuck.rs/Cargo.toml [INFO] started frobbing Keruspe/brainfuck.rs [INFO] finished frobbing Keruspe/brainfuck.rs [INFO] frobbed toml for Keruspe/brainfuck.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Keruspe/brainfuck.rs/Cargo.toml [INFO] crate Keruspe/brainfuck.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Keruspe/brainfuck.rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Keruspe/brainfuck.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f9cd073e7ffb9ae668e03accb2e8b4f37d1b07c7546f42e4a060f401bf56b9f5 [INFO] running `"docker" "start" "-a" "f9cd073e7ffb9ae668e03accb2e8b4f37d1b07c7546f42e4a060f401bf56b9f5"` [INFO] [stderr] Checking brainfuck_rs v1.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | lbuf: lbuf, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `lbuf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | rbuf: rbuf, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `rbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | lbuf: lbuf, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `lbuf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | rbuf: rbuf, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `rbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | const ALLOWED: &'static str = "<>+-.,[]"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | const ALLOWED: &'static str = "<>+-.,[]"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | const EMPTY: &'static [u8] = b""; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/parser.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | bf_skip_unknown(i).or(Ok((i, i.take(0)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Ok((i, i.take(0))))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/parser.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | bf_skip_unknown(i).or(Ok((i, i.take(0)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Ok((i, i.take(0))))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/bin/bf.rs:34:8 [INFO] [stderr] | [INFO] [stderr] 34 | Ok(Context::new().run(&parser::parse(parser::CompleteByteSlice(contents.as_ref()))?)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 34 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/bin/bf.rs:34:8 [INFO] [stderr] | [INFO] [stderr] 34 | Ok(Context::new().run(&parser::parse(parser::CompleteByteSlice(contents.as_ref()))?)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 34 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.94s [INFO] running `"docker" "inspect" "f9cd073e7ffb9ae668e03accb2e8b4f37d1b07c7546f42e4a060f401bf56b9f5"` [INFO] running `"docker" "rm" "-f" "f9cd073e7ffb9ae668e03accb2e8b4f37d1b07c7546f42e4a060f401bf56b9f5"` [INFO] [stdout] f9cd073e7ffb9ae668e03accb2e8b4f37d1b07c7546f42e4a060f401bf56b9f5