[INFO] updating cached repository KauzClay/rust-audio-workbench [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/KauzClay/rust-audio-workbench [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/KauzClay/rust-audio-workbench" "work/ex/clippy-test-run/sources/stable/gh/KauzClay/rust-audio-workbench"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/KauzClay/rust-audio-workbench'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/KauzClay/rust-audio-workbench" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KauzClay/rust-audio-workbench"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KauzClay/rust-audio-workbench'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b66063761b0aa51a58b113b02ce661628cee22ed [INFO] sha for GitHub repo KauzClay/rust-audio-workbench: b66063761b0aa51a58b113b02ce661628cee22ed [INFO] validating manifest of KauzClay/rust-audio-workbench on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of KauzClay/rust-audio-workbench on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing KauzClay/rust-audio-workbench [INFO] finished frobbing KauzClay/rust-audio-workbench [INFO] frobbed toml for KauzClay/rust-audio-workbench written to work/ex/clippy-test-run/sources/stable/gh/KauzClay/rust-audio-workbench/Cargo.toml [INFO] started frobbing KauzClay/rust-audio-workbench [INFO] finished frobbing KauzClay/rust-audio-workbench [INFO] frobbed toml for KauzClay/rust-audio-workbench written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KauzClay/rust-audio-workbench/Cargo.toml [INFO] crate KauzClay/rust-audio-workbench has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting KauzClay/rust-audio-workbench against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KauzClay/rust-audio-workbench:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0b33dc1ff40f660c8585253dc8d51898378ccc7572140040fb37bd2dfa06572c [INFO] running `"docker" "start" "-a" "0b33dc1ff40f660c8585253dc8d51898378ccc7572140040fb37bd2dfa06572c"` [INFO] [stderr] Checking raw v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/outline.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/wavreader.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Fn` [INFO] [stderr] --> src/rawcli.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::ops::Fn; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `wavreader` [INFO] [stderr] --> src/rawcli.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use wavreader; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `samplearray::SampleArray` [INFO] [stderr] --> src/rawcli.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use samplearray::SampleArray; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rawcli.rs:220:12 [INFO] [stderr] | [INFO] [stderr] 220 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 221 | | if let Some(Some(filetype)) = path.extension().map(|s| s.to_str()) { [INFO] [stderr] 222 | | Err(format!("Unsupported file type {}.", filetype)) [INFO] [stderr] 223 | | } else { [INFO] [stderr] 224 | | Err(format!("Unsupported file type ?.")) [INFO] [stderr] 225 | | } [INFO] [stderr] 226 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 220 | } else if let Some(Some(filetype)) = path.extension().map(|s| s.to_str()) { [INFO] [stderr] 221 | Err(format!("Unsupported file type {}.", filetype)) [INFO] [stderr] 222 | } else { [INFO] [stderr] 223 | Err(format!("Unsupported file type ?.")) [INFO] [stderr] 224 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/outline.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/wavreader.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Fn` [INFO] [stderr] --> src/rawcli.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::ops::Fn; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `wavreader` [INFO] [stderr] --> src/rawcli.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use wavreader; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `samplearray::SampleArray` [INFO] [stderr] --> src/rawcli.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use samplearray::SampleArray; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/rawcli.rs:220:12 [INFO] [stderr] | [INFO] [stderr] 220 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 221 | | if let Some(Some(filetype)) = path.extension().map(|s| s.to_str()) { [INFO] [stderr] 222 | | Err(format!("Unsupported file type {}.", filetype)) [INFO] [stderr] 223 | | } else { [INFO] [stderr] 224 | | Err(format!("Unsupported file type ?.")) [INFO] [stderr] 225 | | } [INFO] [stderr] 226 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 220 | } else if let Some(Some(filetype)) = path.extension().map(|s| s.to_str()) { [INFO] [stderr] 221 | Err(format!("Unsupported file type {}.", filetype)) [INFO] [stderr] 222 | } else { [INFO] [stderr] 223 | Err(format!("Unsupported file type ?.")) [INFO] [stderr] 224 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cmd` [INFO] [stderr] --> src/rawcli.rs:139:62 [INFO] [stderr] | [INFO] [stderr] 139 | fn info(tracks: &mut Vec, clips: &mut Vec>, cmd: &str) -> Result { [INFO] [stderr] | ^^^ help: consider using `_cmd` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `clips` [INFO] [stderr] --> src/rawcli.rs:183:36 [INFO] [stderr] | [INFO] [stderr] 183 | fn import(tracks: &mut Vec, clips: &mut Vec>, cmd: &str) -> Result { [INFO] [stderr] | ^^^^^ help: consider using `_clips` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/rawcli.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | let path = Path::new(filename); [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `clips` [INFO] [stderr] --> src/rawcli.rs:230:35 [INFO] [stderr] | [INFO] [stderr] 230 | fn write(tracks: &mut Vec, clips: &mut Vec>, cmd: &str) -> Result { [INFO] [stderr] | ^^^^^ help: consider using `_clips` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tracks` [INFO] [stderr] --> src/rawcli.rs:260:12 [INFO] [stderr] | [INFO] [stderr] 260 | fn reverse(tracks: &mut Vec, clips: &mut Vec>, cmd: &str) -> Result { [INFO] [stderr] | ^^^^^^ help: consider using `_tracks` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tracks` [INFO] [stderr] --> src/rawcli.rs:272:11 [INFO] [stderr] | [INFO] [stderr] 272 | fn concat(tracks: &mut Vec, clips: &mut Vec>, cmd: &str) -> Result { [INFO] [stderr] | ^^^^^^ help: consider using `_tracks` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `side` [INFO] [stderr] --> src/track.rs:150:15 [INFO] [stderr] | [INFO] [stderr] 150 | fn remove(side: &mut Vec, position: u64, duration: u64) { [INFO] [stderr] | ^^^^ help: consider using `_side` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `position` [INFO] [stderr] --> src/track.rs:150:45 [INFO] [stderr] | [INFO] [stderr] 150 | fn remove(side: &mut Vec, position: u64, duration: u64) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_position` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `duration` [INFO] [stderr] --> src/track.rs:150:60 [INFO] [stderr] | [INFO] [stderr] 150 | fn remove(side: &mut Vec, position: u64, duration: u64) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_duration` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `split_dur` [INFO] [stderr] --> src/track.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | let split_dur = self.clips[get_idx].clip.duration(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_split_dur` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cmd` [INFO] [stderr] --> src/rawcli.rs:139:62 [INFO] [stderr] | [INFO] [stderr] 139 | fn info(tracks: &mut Vec, clips: &mut Vec>, cmd: &str) -> Result { [INFO] [stderr] | ^^^ help: consider using `_cmd` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `clips` [INFO] [stderr] --> src/rawcli.rs:183:36 [INFO] [stderr] | [INFO] [stderr] 183 | fn import(tracks: &mut Vec, clips: &mut Vec>, cmd: &str) -> Result { [INFO] [stderr] | ^^^^^ help: consider using `_clips` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/rawcli.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | let path = Path::new(filename); [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `clips` [INFO] [stderr] --> src/rawcli.rs:230:35 [INFO] [stderr] | [INFO] [stderr] 230 | fn write(tracks: &mut Vec, clips: &mut Vec>, cmd: &str) -> Result { [INFO] [stderr] | ^^^^^ help: consider using `_clips` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tracks` [INFO] [stderr] --> src/rawcli.rs:260:12 [INFO] [stderr] | [INFO] [stderr] 260 | fn reverse(tracks: &mut Vec, clips: &mut Vec>, cmd: &str) -> Result { [INFO] [stderr] | ^^^^^^ help: consider using `_tracks` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tracks` [INFO] [stderr] --> src/rawcli.rs:272:11 [INFO] [stderr] | [INFO] [stderr] 272 | fn concat(tracks: &mut Vec, clips: &mut Vec>, cmd: &str) -> Result { [INFO] [stderr] | ^^^^^^ help: consider using `_tracks` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `side` [INFO] [stderr] --> src/track.rs:150:15 [INFO] [stderr] | [INFO] [stderr] 150 | fn remove(side: &mut Vec, position: u64, duration: u64) { [INFO] [stderr] | ^^^^ help: consider using `_side` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `position` [INFO] [stderr] --> src/track.rs:150:45 [INFO] [stderr] | [INFO] [stderr] 150 | fn remove(side: &mut Vec, position: u64, duration: u64) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_position` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `duration` [INFO] [stderr] --> src/track.rs:150:60 [INFO] [stderr] | [INFO] [stderr] 150 | fn remove(side: &mut Vec, position: u64, duration: u64) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_duration` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `split_dur` [INFO] [stderr] --> src/track.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | let split_dur = self.clips[get_idx].clip.duration(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_split_dur` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `remove` [INFO] [stderr] --> src/track.rs:150:5 [INFO] [stderr] | [INFO] [stderr] 150 | fn remove(side: &mut Vec, position: u64, duration: u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/tempo.rs:46:34 [INFO] [stderr] | [INFO] [stderr] 46 | self.beat_length_sec() * self.time_signature.beats as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.time_signature.beats)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/outline.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | (self * sample_rate as f64) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(sample_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/outline.rs:45:30 [INFO] [stderr] | [INFO] [stderr] 45 | num_samples as f64 / sample_rate as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(sample_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/outline.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | if sample_at <= 0 || sample_at >= dur { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using sample_at == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/outline.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | let b = self.get(sample_at + 1) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.get(sample_at + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/outline.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | let m = self.get(sample_at) as f64 - b; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.get(sample_at))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/wavreader.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | while let Some(s) = samples.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `for s in samples { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: method is never used: `remove` [INFO] [stderr] --> src/track.rs:150:5 [INFO] [stderr] | [INFO] [stderr] 150 | fn remove(side: &mut Vec, position: u64, duration: u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/compounds.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn to_end(clip: Arc, start_time: T) -> Option> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/track.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn name<'a>(&'a self) -> &'a str { [INFO] [stderr] 50 | | &self.name [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `side`. [INFO] [stderr] --> src/track.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | for i in shift_index..side.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/tempo.rs:46:34 [INFO] [stderr] | [INFO] [stderr] 46 | self.beat_length_sec() * self.time_signature.beats as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.time_signature.beats)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/outline.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | (self * sample_rate as f64) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(sample_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/outline.rs:45:30 [INFO] [stderr] | [INFO] [stderr] 45 | num_samples as f64 / sample_rate as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(sample_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/outline.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | if sample_at <= 0 || sample_at >= dur { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using sample_at == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/outline.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | let b = self.get(sample_at + 1) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.get(sample_at + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/outline.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | let m = self.get(sample_at) as f64 - b; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.get(sample_at))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 102 | for in side.iter_mut().skip(shift_index) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/track.rs:179:35 [INFO] [stderr] | [INFO] [stderr] 179 | fn track_to_clip(&self, side: &Vec) -> Arc { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 179 | fn track_to_clip(&self, side: &[ClipPosition]) -> Arc { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `side.clone()` to [INFO] [stderr] | [INFO] [stderr] 183 | clips: side.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `rawcli::RawCliEnvironment` [INFO] [stderr] --> src/rawcli.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Self { [INFO] [stderr] 30 | | let mut env = RawCliEnvironment { [INFO] [stderr] 31 | | tracks: Vec::new(), [INFO] [stderr] 32 | | clips: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 43 | | env [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rawcli.rs:81:51 [INFO] [stderr] | [INFO] [stderr] 81 | let num_args_plus_one = cmd.split_whitespace().collect::>().len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/wavreader.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | while let Some(s) = samples.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `for s in samples { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/compounds.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn to_end(clip: Arc, start_time: T) -> Option> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/rawcli.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | Err(format!("Failure")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failure".to_string()` [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/track.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn name<'a>(&'a self) -> &'a str { [INFO] [stderr] 50 | | &self.name [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `side`. [INFO] [stderr] --> src/track.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | for i in shift_index..side.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 102 | for in side.iter_mut().skip(shift_index) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/track.rs:179:35 [INFO] [stderr] | [INFO] [stderr] 179 | fn track_to_clip(&self, side: &Vec) -> Arc { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 179 | fn track_to_clip(&self, side: &[ClipPosition]) -> Arc { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `side.clone()` to [INFO] [stderr] | [INFO] [stderr] 183 | clips: side.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `rawcli::RawCliEnvironment` [INFO] [stderr] --> src/rawcli.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Self { [INFO] [stderr] 30 | | let mut env = RawCliEnvironment { [INFO] [stderr] 31 | | tracks: Vec::new(), [INFO] [stderr] 32 | | clips: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 43 | | env [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/rawcli.rs:172:24 [INFO] [stderr] | [INFO] [stderr] 172 | .ok_or_else(|| format!("Start or duration out of bounds"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Start or duration out of bounds".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/rawcli.rs:174:24 [INFO] [stderr] | [INFO] [stderr] 174 | .ok_or_else(|| format!("Start or duration out of bounds"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Start or duration out of bounds".to_string()` [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rawcli.rs:81:51 [INFO] [stderr] | [INFO] [stderr] 81 | let num_args_plus_one = cmd.split_whitespace().collect::>().len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/rawcli.rs:224:17 [INFO] [stderr] | [INFO] [stderr] 224 | Err(format!("Unsupported file type ?.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unsupported file type ?.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/rawcli.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | Err(format!("Failure")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failure".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `raw`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/rawcli.rs:172:24 [INFO] [stderr] | [INFO] [stderr] 172 | .ok_or_else(|| format!("Start or duration out of bounds"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Start or duration out of bounds".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/rawcli.rs:174:24 [INFO] [stderr] | [INFO] [stderr] 174 | .ok_or_else(|| format!("Start or duration out of bounds"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Start or duration out of bounds".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/rawcli.rs:224:17 [INFO] [stderr] | [INFO] [stderr] 224 | Err(format!("Unsupported file type ?.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unsupported file type ?.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `raw`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0b33dc1ff40f660c8585253dc8d51898378ccc7572140040fb37bd2dfa06572c"` [INFO] running `"docker" "rm" "-f" "0b33dc1ff40f660c8585253dc8d51898378ccc7572140040fb37bd2dfa06572c"` [INFO] [stdout] 0b33dc1ff40f660c8585253dc8d51898378ccc7572140040fb37bd2dfa06572c