[INFO] updating cached repository KaKnife/asm622 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/KaKnife/asm622 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/KaKnife/asm622" "work/ex/clippy-test-run/sources/stable/gh/KaKnife/asm622"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/KaKnife/asm622'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/KaKnife/asm622" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KaKnife/asm622"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KaKnife/asm622'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7f9e9f5472f21f52298e40b7ae4b43fbb4737fb1 [INFO] sha for GitHub repo KaKnife/asm622: 7f9e9f5472f21f52298e40b7ae4b43fbb4737fb1 [INFO] validating manifest of KaKnife/asm622 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of KaKnife/asm622 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing KaKnife/asm622 [INFO] finished frobbing KaKnife/asm622 [INFO] frobbed toml for KaKnife/asm622 written to work/ex/clippy-test-run/sources/stable/gh/KaKnife/asm622/Cargo.toml [INFO] started frobbing KaKnife/asm622 [INFO] finished frobbing KaKnife/asm622 [INFO] frobbed toml for KaKnife/asm622 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KaKnife/asm622/Cargo.toml [INFO] crate KaKnife/asm622 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting KaKnife/asm622 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/KaKnife/asm622:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 262e73b4e4eeb8298004f8b26c6fe90cc649f68be16d0e53fbad717c7a9170cc [INFO] running `"docker" "start" "-a" "262e73b4e4eeb8298004f8b26c6fe90cc649f68be16d0e53fbad717c7a9170cc"` [INFO] [stderr] Checking asm622 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | Section{offset:offset, instructions:Vec::new()} [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/omf.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | HeaderRecord{name:name} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/omf.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | EndRecord{name:name, reg_msk:reg_msk} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/omf.rs:65:30 [INFO] [stderr] | [INFO] [stderr] 65 | EndRecord{name:name, reg_msk:reg_msk} [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `reg_msk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/omf.rs:104:23 [INFO] [stderr] | [INFO] [stderr] 104 | ContentRecord{offset:offset, data:data, seg_id:seg_id} [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/omf.rs:104:38 [INFO] [stderr] | [INFO] [stderr] 104 | ContentRecord{offset:offset, data:data, seg_id:seg_id} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/omf.rs:104:49 [INFO] [stderr] | [INFO] [stderr] 104 | ContentRecord{offset:offset, data:data, seg_id:seg_id} [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `seg_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | label:label, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | mnu:mnu, [INFO] [stderr] | ^^^^^^^ help: replace it with: `mnu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | ops:ops, [INFO] [stderr] | ^^^^^^^ help: replace it with: `ops` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | num:num [INFO] [stderr] | ^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:348:24 [INFO] [stderr] | [INFO] [stderr] 348 | Ok(Instruction{offset:offset, num: line.num, label:line.label, mnemonic: mne, ops:ops}) [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:348:87 [INFO] [stderr] | [INFO] [stderr] 348 | Ok(Instruction{offset:offset, num: line.num, label:line.label, mnemonic: mne, ops:ops}) [INFO] [stderr] | ^^^^^^^ help: replace it with: `ops` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hex_table.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | HexTable{table:table} [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:309:17 [INFO] [stderr] | [INFO] [stderr] 309 | write!(file, "{}\n", line_out.to_uppercase()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:317:5 [INFO] [stderr] | [INFO] [stderr] 317 | write!(file, ":00000001FF\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | Section{offset:offset, instructions:Vec::new()} [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/omf.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | HeaderRecord{name:name} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/omf.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | EndRecord{name:name, reg_msk:reg_msk} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/omf.rs:65:30 [INFO] [stderr] | [INFO] [stderr] 65 | EndRecord{name:name, reg_msk:reg_msk} [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `reg_msk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/omf.rs:104:23 [INFO] [stderr] | [INFO] [stderr] 104 | ContentRecord{offset:offset, data:data, seg_id:seg_id} [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/omf.rs:104:38 [INFO] [stderr] | [INFO] [stderr] 104 | ContentRecord{offset:offset, data:data, seg_id:seg_id} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/omf.rs:104:49 [INFO] [stderr] | [INFO] [stderr] 104 | ContentRecord{offset:offset, data:data, seg_id:seg_id} [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `seg_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | label:label, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | mnu:mnu, [INFO] [stderr] | ^^^^^^^ help: replace it with: `mnu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | ops:ops, [INFO] [stderr] | ^^^^^^^ help: replace it with: `ops` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/line.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | num:num [INFO] [stderr] | ^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:348:24 [INFO] [stderr] | [INFO] [stderr] 348 | Ok(Instruction{offset:offset, num: line.num, label:line.label, mnemonic: mne, ops:ops}) [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:348:87 [INFO] [stderr] | [INFO] [stderr] 348 | Ok(Instruction{offset:offset, num: line.num, label:line.label, mnemonic: mne, ops:ops}) [INFO] [stderr] | ^^^^^^^ help: replace it with: `ops` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hex_table.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | HexTable{table:table} [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:309:17 [INFO] [stderr] | [INFO] [stderr] 309 | write!(file, "{}\n", line_out.to_uppercase()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:317:5 [INFO] [stderr] | [INFO] [stderr] 317 | write!(file, ":00000001FF\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/section.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | offset =(offset as i32 +ins.len() as i32)as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/section.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / match ins.is_new_section() { [INFO] [stderr] 25 | | Some(d) => { [INFO] [stderr] 26 | | sections.push(curr_sec); [INFO] [stderr] 27 | | curr_sec = Section::new(d); [INFO] [stderr] ... | [INFO] [stderr] 30 | | None =>{}, [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | if let Some(d) = ins.is_new_section() { [INFO] [stderr] 25 | sections.push(curr_sec); [INFO] [stderr] 26 | curr_sec = Section::new(d); [INFO] [stderr] 27 | offset = 0; [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/section.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn fix_labels(&mut self, label_table: &Vec<(String, u16)>) -> Result<(), Vec>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, u16)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/omf.rs:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | fn checksome(vec: &Vec)->u8{ [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/omf.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | sum+=*v as u64; [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(*v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `bank.0 as u8` [INFO] [stderr] --> src/omf.rs:64:80 [INFO] [stderr] | [INFO] [stderr] 64 | let reg_msk = 0b1000*bank.3 as u8+0b100*bank.2 as u8+0b10*bank.1 as u8+0b1*bank.0 as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/omf.rs:122:12 [INFO] [stderr] | [INFO] [stderr] 122 | if self.data.len() ==0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/line.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | if line.contains(";"){ [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/line.rs:59:26 [INFO] [stderr] | [INFO] [stderr] 59 | if line.contains(":"){ [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/line.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | cmd.retain(|x| x.to_string() != ""); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/line.rs:68:12 [INFO] [stderr] | [INFO] [stderr] 68 | if cmd.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cmd.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `cmd`. [INFO] [stderr] --> src/line.rs:71:26 [INFO] [stderr] | [INFO] [stderr] 71 | for i in 1 .. cmd.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 71 | for in cmd.iter().skip(1){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | if addr as u64+0x7F < self.offset as u64+self.len() as u64{ [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:99:32 [INFO] [stderr] | [INFO] [stderr] 99 | if addr as u64+0x7F < self.offset as u64+self.len() as u64{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/instruction.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | / match &self.mnemonic { [INFO] [stderr] 108 | | &Some(Div) => self.div(), [INFO] [stderr] 109 | | &Some(Mov) => self.mov(), [INFO] [stderr] 110 | | &Some(Movc) => self.movc(), [INFO] [stderr] ... | [INFO] [stderr] 159 | | //&Some(ref a) => Err(format!("Unimplemented: {:?}", a)), [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 107 | match self.mnemonic { [INFO] [stderr] 108 | Some(Div) => self.div(), [INFO] [stderr] 109 | Some(Mov) => self.mov(), [INFO] [stderr] 110 | Some(Movc) => self.movc(), [INFO] [stderr] 111 | Some(Movx) => self.movx(), [INFO] [stderr] 112 | Some(Inc) => self.inc(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:171:12 [INFO] [stderr] | [INFO] [stderr] 171 | if self.ops.len()<1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:175:29 [INFO] [stderr] | [INFO] [stderr] 175 | Addr(d) => Some(d as u16), [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:179:37 [INFO] [stderr] | [INFO] [stderr] 179 | Addr(d) => Some(d as u16), [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `m @ _` pattern can be written as just `m` [INFO] [stderr] --> src/instruction.rs:246:17 [INFO] [stderr] | [INFO] [stderr] 246 | m @ _ => return Err(format!("unknown mnemonic: line {}: {}",line.num,m)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `op @ _` pattern can be written as just `op` [INFO] [stderr] --> src/instruction.rs:337:17 [INFO] [stderr] | [INFO] [stderr] 337 | op @ _ => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:363:25 [INFO] [stderr] | [INFO] [stderr] 363 | / match self.ops[0] { [INFO] [stderr] 364 | | Label(ref l)=> return l.len() as i32, [INFO] [stderr] 365 | | _ => {}, [INFO] [stderr] 366 | | }; [INFO] [stderr] | |_________________________^ help: try this: `if let Label(ref l) = self.ops[0] { return l.len() as i32 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:371:25 [INFO] [stderr] | [INFO] [stderr] 371 | / match self.ops[0] { [INFO] [stderr] 372 | | Addr(ref l)=> return *l as i32, [INFO] [stderr] 373 | | _ => {}, [INFO] [stderr] 374 | | }; [INFO] [stderr] | |_________________________^ help: try this: `if let Addr(ref l) = self.ops[0] { return *l as i32 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:372:50 [INFO] [stderr] | [INFO] [stderr] 372 | Addr(ref l)=> return *l as i32, [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(*l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/instruction.rs:383:16 [INFO] [stderr] | [INFO] [stderr] 383 | if self.ops.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/instruction.rs:411:40 [INFO] [stderr] | [INFO] [stderr] 411 | pub fn fix_label(&mut self, table: &Vec<(String, u16)>) -> Result<(), String>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 411 | pub fn fix_label(&mut self, table: &[(String, u16)]) -> Result<(), String>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `table.clone()` to [INFO] [stderr] | [INFO] [stderr] 419 | let label_table = table.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/instruction.rs:435:25 [INFO] [stderr] | [INFO] [stderr] 435 | / let mut add = 0; [INFO] [stderr] 436 | | if split.len()>1 { [INFO] [stderr] 437 | | add = match u8::from_str_radix(split[1], 16){ [INFO] [stderr] 438 | | Ok(a) => a, [INFO] [stderr] 439 | | Err(_) => 0, [INFO] [stderr] 440 | | }; [INFO] [stderr] 441 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 435 | let add = if split.len()>1 { match u8::from_str_radix(split[1], 16){ [INFO] [stderr] 436 | Ok(a) => a, [INFO] [stderr] 437 | Err(_) => 0, [INFO] [stderr] 438 | } } else { 0 }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:442:45 [INFO] [stderr] | [INFO] [stderr] 442 | OpType::Addr16(addr+add as u16) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(add)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `o @ _` pattern can be written as just `o` [INFO] [stderr] --> src/instruction.rs:445:17 [INFO] [stderr] | [INFO] [stderr] 445 | ref o@_=>o.clone(), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:489:14 [INFO] [stderr] | [INFO] [stderr] 489 | (ref a@_, ref b@_,ref c@_) => Err(format!("Invalid operation: CJNE {:?},{:?},{:?}", a,b,c)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:489:23 [INFO] [stderr] | [INFO] [stderr] 489 | (ref a@_, ref b@_,ref c@_) => Err(format!("Invalid operation: CJNE {:?},{:?},{:?}", a,b,c)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `c @ _` pattern can be written as just `c` [INFO] [stderr] --> src/instruction.rs:489:31 [INFO] [stderr] | [INFO] [stderr] 489 | (ref a@_, ref b@_,ref c@_) => Err(format!("Invalid operation: CJNE {:?},{:?},{:?}", a,b,c)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:494:12 [INFO] [stderr] | [INFO] [stderr] 494 | if self.ops.len() < 1{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:504:13 [INFO] [stderr] | [INFO] [stderr] 504 | ref a@_ => Err(format!("Invalid operation: CLR {:?}", a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:509:12 [INFO] [stderr] | [INFO] [stderr] 509 | if self.ops.len() < 1{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:518:13 [INFO] [stderr] | [INFO] [stderr] 518 | ref a@_ => Err(format!("Invalid operation: SETB {:?}", a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:523:12 [INFO] [stderr] | [INFO] [stderr] 523 | if self.ops.len() < 1{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:533:13 [INFO] [stderr] | [INFO] [stderr] 533 | ref a@_ => Err(format!("Invalid operation: CPL {:?}", a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:555:14 [INFO] [stderr] | [INFO] [stderr] 555 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:555:18 [INFO] [stderr] | [INFO] [stderr] 555 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:631:14 [INFO] [stderr] | [INFO] [stderr] 631 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:631:18 [INFO] [stderr] | [INFO] [stderr] 631 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:637:12 [INFO] [stderr] | [INFO] [stderr] 637 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:657:13 [INFO] [stderr] | [INFO] [stderr] 657 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:663:12 [INFO] [stderr] | [INFO] [stderr] 663 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:682:13 [INFO] [stderr] | [INFO] [stderr] 682 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:688:12 [INFO] [stderr] | [INFO] [stderr] 688 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:696:13 [INFO] [stderr] | [INFO] [stderr] 696 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:702:12 [INFO] [stderr] | [INFO] [stderr] 702 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:711:13 [INFO] [stderr] | [INFO] [stderr] 711 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:736:14 [INFO] [stderr] | [INFO] [stderr] 736 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:736:18 [INFO] [stderr] | [INFO] [stderr] 736 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:761:14 [INFO] [stderr] | [INFO] [stderr] 761 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:761:18 [INFO] [stderr] | [INFO] [stderr] 761 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:789:14 [INFO] [stderr] | [INFO] [stderr] 789 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:789:18 [INFO] [stderr] | [INFO] [stderr] 789 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:818:14 [INFO] [stderr] | [INFO] [stderr] 818 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:818:18 [INFO] [stderr] | [INFO] [stderr] 818 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:844:14 [INFO] [stderr] | [INFO] [stderr] 844 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:844:18 [INFO] [stderr] | [INFO] [stderr] 844 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:869:14 [INFO] [stderr] | [INFO] [stderr] 869 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:869:18 [INFO] [stderr] | [INFO] [stderr] 869 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:897:14 [INFO] [stderr] | [INFO] [stderr] 897 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:897:18 [INFO] [stderr] | [INFO] [stderr] 897 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:920:14 [INFO] [stderr] | [INFO] [stderr] 920 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:920:18 [INFO] [stderr] | [INFO] [stderr] 920 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:935:14 [INFO] [stderr] | [INFO] [stderr] 935 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:935:18 [INFO] [stderr] | [INFO] [stderr] 935 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/instruction.rs:941:12 [INFO] [stderr] | [INFO] [stderr] 941 | if self.ops.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/instruction.rs:949:12 [INFO] [stderr] | [INFO] [stderr] 949 | if self.ops.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:965:14 [INFO] [stderr] | [INFO] [stderr] 965 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:965:18 [INFO] [stderr] | [INFO] [stderr] 965 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:971:12 [INFO] [stderr] | [INFO] [stderr] 971 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:979:13 [INFO] [stderr] | [INFO] [stderr] 979 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:985:12 [INFO] [stderr] | [INFO] [stderr] 985 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:993:13 [INFO] [stderr] | [INFO] [stderr] 993 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:999:12 [INFO] [stderr] | [INFO] [stderr] 999 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1007:13 [INFO] [stderr] | [INFO] [stderr] 1007 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1013:12 [INFO] [stderr] | [INFO] [stderr] 1013 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1021:13 [INFO] [stderr] | [INFO] [stderr] 1021 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1027:12 [INFO] [stderr] | [INFO] [stderr] 1027 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1035:13 [INFO] [stderr] | [INFO] [stderr] 1035 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1041:12 [INFO] [stderr] | [INFO] [stderr] 1041 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1049:13 [INFO] [stderr] | [INFO] [stderr] 1049 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1055:12 [INFO] [stderr] | [INFO] [stderr] 1055 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1063:13 [INFO] [stderr] | [INFO] [stderr] 1063 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1069:12 [INFO] [stderr] | [INFO] [stderr] 1069 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1077:13 [INFO] [stderr] | [INFO] [stderr] 1077 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/instruction.rs:1083:12 [INFO] [stderr] | [INFO] [stderr] 1083 | if self.ops.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1091:12 [INFO] [stderr] | [INFO] [stderr] 1091 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1099:13 [INFO] [stderr] | [INFO] [stderr] 1099 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1105:12 [INFO] [stderr] | [INFO] [stderr] 1105 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1113:13 [INFO] [stderr] | [INFO] [stderr] 1113 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1119:12 [INFO] [stderr] | [INFO] [stderr] 1119 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1127:13 [INFO] [stderr] | [INFO] [stderr] 1127 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1133:12 [INFO] [stderr] | [INFO] [stderr] 1133 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1141:13 [INFO] [stderr] | [INFO] [stderr] 1141 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1147:12 [INFO] [stderr] | [INFO] [stderr] 1147 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1155:13 [INFO] [stderr] | [INFO] [stderr] 1155 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1161:12 [INFO] [stderr] | [INFO] [stderr] 1161 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1169:13 [INFO] [stderr] | [INFO] [stderr] 1169 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1175:12 [INFO] [stderr] | [INFO] [stderr] 1175 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/section.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | offset =(offset as i32 +ins.len() as i32)as u16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/section.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / match ins.is_new_section() { [INFO] [stderr] 25 | | Some(d) => { [INFO] [stderr] 26 | | sections.push(curr_sec); [INFO] [stderr] 27 | | curr_sec = Section::new(d); [INFO] [stderr] ... | [INFO] [stderr] 30 | | None =>{}, [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | if let Some(d) = ins.is_new_section() { [INFO] [stderr] 25 | sections.push(curr_sec); [INFO] [stderr] 26 | curr_sec = Section::new(d); [INFO] [stderr] 27 | offset = 0; [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1183:13 [INFO] [stderr] | [INFO] [stderr] 1183 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1189:12 [INFO] [stderr] | [INFO] [stderr] 1189 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1197:13 [INFO] [stderr] | [INFO] [stderr] 1197 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/section.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn fix_labels(&mut self, label_table: &Vec<(String, u16)>) -> Result<(), Vec>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, u16)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1203:12 [INFO] [stderr] | [INFO] [stderr] 1203 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1211:13 [INFO] [stderr] | [INFO] [stderr] 1211 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/omf.rs:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | fn checksome(vec: &Vec)->u8{ [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/omf.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | sum+=*v as u64; [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(*v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1217:12 [INFO] [stderr] | [INFO] [stderr] 1217 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1225:13 [INFO] [stderr] | [INFO] [stderr] 1225 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `bank.0 as u8` [INFO] [stderr] --> src/omf.rs:64:80 [INFO] [stderr] | [INFO] [stderr] 64 | let reg_msk = 0b1000*bank.3 as u8+0b100*bank.2 as u8+0b10*bank.1 as u8+0b1*bank.0 as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1239:14 [INFO] [stderr] | [INFO] [stderr] 1239 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:1239:18 [INFO] [stderr] | [INFO] [stderr] 1239 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/omf.rs:122:12 [INFO] [stderr] | [INFO] [stderr] 122 | if self.data.len() ==0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1253:14 [INFO] [stderr] | [INFO] [stderr] 1253 | (ref a@_,ref b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:1253:22 [INFO] [stderr] | [INFO] [stderr] 1253 | (ref a@_,ref b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/line.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | if line.contains(";"){ [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/line.rs:59:26 [INFO] [stderr] | [INFO] [stderr] 59 | if line.contains(":"){ [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1268:14 [INFO] [stderr] | [INFO] [stderr] 1268 | (ref a@_,ref b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/line.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | cmd.retain(|x| x.to_string() != ""); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `x` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:1268:22 [INFO] [stderr] | [INFO] [stderr] 1268 | (ref a@_,ref b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/line.rs:68:12 [INFO] [stderr] | [INFO] [stderr] 68 | if cmd.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cmd.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `cmd`. [INFO] [stderr] --> src/line.rs:71:26 [INFO] [stderr] | [INFO] [stderr] 71 | for i in 1 .. cmd.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 71 | for in cmd.iter().skip(1){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1275:12 [INFO] [stderr] | [INFO] [stderr] 1275 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1291:17 [INFO] [stderr] | [INFO] [stderr] 1291 | ref a@_ => return Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1300:12 [INFO] [stderr] | [INFO] [stderr] 1300 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1308:13 [INFO] [stderr] | [INFO] [stderr] 1308 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:1316:23 [INFO] [stderr] | [INFO] [stderr] 1316 | if op.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:1318:25 [INFO] [stderr] | [INFO] [stderr] 1318 | if op.ends_with("h") { [INFO] [stderr] | ^^^ help: try using a char instead: `'h'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:1321:13 [INFO] [stderr] | [INFO] [stderr] 1321 | / match u8::from_str_radix(&op, 16){ [INFO] [stderr] 1322 | | Ok(d) => return Ok(Data(d)), [INFO] [stderr] 1323 | | Err(_) => {}, [INFO] [stderr] 1324 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let Ok(d) = u8::from_str_radix(&op, 16) { return Ok(Data(d)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:1330:9 [INFO] [stderr] | [INFO] [stderr] 1330 | / match u8::from_str_radix(&op, 10) { [INFO] [stderr] 1331 | | Ok(a) => return Ok(Data(a)), [INFO] [stderr] 1332 | | Err(_) => {}, [INFO] [stderr] 1333 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(a) = u8::from_str_radix(&op, 10) { return Ok(Data(a)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:1339:21 [INFO] [stderr] | [INFO] [stderr] 1339 | if op.ends_with("h") { [INFO] [stderr] | ^^^ help: try using a char instead: `'h'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:1343:9 [INFO] [stderr] | [INFO] [stderr] 1343 | / match u8::from_str_radix(&temp, 16){ [INFO] [stderr] 1344 | | Ok(a) => return Ok( Addr(a)), [INFO] [stderr] 1345 | | Err(_) => {}, [INFO] [stderr] 1346 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(a) = u8::from_str_radix(&temp, 16) { return Ok( Addr(a)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:1356:9 [INFO] [stderr] | [INFO] [stderr] 1356 | / match u8::from_str_radix(&temp, 16){ [INFO] [stderr] 1357 | | Ok(a) => return Ok( Addr(a)), [INFO] [stderr] 1358 | | Err(_) => {}, [INFO] [stderr] 1359 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(a) = u8::from_str_radix(&temp, 16) { return Ok( Addr(a)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:1365:5 [INFO] [stderr] | [INFO] [stderr] 1365 | / match u8::from_str_radix(&op, 10){ [INFO] [stderr] 1366 | | Ok(a) => return Ok( Addr(a)), [INFO] [stderr] 1367 | | Err(_) => {}, [INFO] [stderr] 1368 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(a) = u8::from_str_radix(&op, 10) { return Ok( Addr(a)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:1369:5 [INFO] [stderr] | [INFO] [stderr] 1369 | / match u16::from_str_radix(&op, 10){ [INFO] [stderr] 1370 | | Ok(a) => return Ok( Addr16(a)), [INFO] [stderr] 1371 | | Err(_) => {}, [INFO] [stderr] 1372 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(a) = u16::from_str_radix(&op, 10) { return Ok( Addr16(a)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:1373:5 [INFO] [stderr] | [INFO] [stderr] 1373 | / match u64::from_str_radix(&op, 10) { [INFO] [stderr] 1374 | | Ok(_) => return Err(String::from("Invalid Address")), [INFO] [stderr] 1375 | | Err(_) => {}, [INFO] [stderr] 1376 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Ok(_) = u64::from_str_radix(&op, 10) { return Err(String::from("Invalid Address")) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/hex_table.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(ins:& Vec) -> HexTable{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | if addr as u64+0x7F < self.offset as u64+self.len() as u64{ [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:99:32 [INFO] [stderr] | [INFO] [stderr] 99 | if addr as u64+0x7F < self.offset as u64+self.len() as u64{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/hex_table.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | if inst.offset()as i32+inst.len()>max{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(inst.offset())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/hex_table.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | max = inst.offset()as i32+inst.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(inst.offset())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/hex_table.rs:23:46 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn update(&mut self, offset:u16, hex:&Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `hex` [INFO] [stderr] --> src/hex_table.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | for i in 0..(hex.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 24 | for (i, ) in hex.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/instruction.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | / match &self.mnemonic { [INFO] [stderr] 108 | | &Some(Div) => self.div(), [INFO] [stderr] 109 | | &Some(Mov) => self.mov(), [INFO] [stderr] 110 | | &Some(Movc) => self.movc(), [INFO] [stderr] ... | [INFO] [stderr] 159 | | //&Some(ref a) => Err(format!("Unimplemented: {:?}", a)), [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 107 | match self.mnemonic { [INFO] [stderr] 108 | Some(Div) => self.div(), [INFO] [stderr] 109 | Some(Mov) => self.mov(), [INFO] [stderr] 110 | Some(Movc) => self.movc(), [INFO] [stderr] 111 | Some(Movx) => self.movx(), [INFO] [stderr] 112 | Some(Inc) => self.inc(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:171:12 [INFO] [stderr] | [INFO] [stderr] 171 | if self.ops.len()<1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:175:29 [INFO] [stderr] | [INFO] [stderr] 175 | Addr(d) => Some(d as u16), [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:179:37 [INFO] [stderr] | [INFO] [stderr] 179 | Addr(d) => Some(d as u16), [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match sec.fix_labels(&label_table) { [INFO] [stderr] 68 | | Err(mut e) => errors.append(&mut e), [INFO] [stderr] 69 | | _ => {}, [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(mut e) = sec.fix_labels(&label_table) { errors.append(&mut e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the `m @ _` pattern can be written as just `m` [INFO] [stderr] --> src/instruction.rs:246:17 [INFO] [stderr] | [INFO] [stderr] 246 | m @ _ => return Err(format!("unknown mnemonic: line {}: {}",line.num,m)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:102:32 [INFO] [stderr] | [INFO] [stderr] 102 | fn build_label_table(sections: &Vec) -> Vec<(String, u16)>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[section::Section]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the `op @ _` pattern can be written as just `op` [INFO] [stderr] --> src/instruction.rs:337:17 [INFO] [stderr] | [INFO] [stderr] 337 | op @ _ => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:363:25 [INFO] [stderr] | [INFO] [stderr] 363 | / match self.ops[0] { [INFO] [stderr] 364 | | Label(ref l)=> return l.len() as i32, [INFO] [stderr] 365 | | _ => {}, [INFO] [stderr] 366 | | }; [INFO] [stderr] | |_________________________^ help: try this: `if let Label(ref l) = self.ops[0] { return l.len() as i32 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:371:25 [INFO] [stderr] | [INFO] [stderr] 371 | / match self.ops[0] { [INFO] [stderr] 372 | | Addr(ref l)=> return *l as i32, [INFO] [stderr] 373 | | _ => {}, [INFO] [stderr] 374 | | }; [INFO] [stderr] | |_________________________^ help: try this: `if let Addr(ref l) = self.ops[0] { return *l as i32 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:372:50 [INFO] [stderr] | [INFO] [stderr] 372 | Addr(ref l)=> return *l as i32, [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(*l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/instruction.rs:383:16 [INFO] [stderr] | [INFO] [stderr] 383 | if self.ops.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/instruction.rs:411:40 [INFO] [stderr] | [INFO] [stderr] 411 | pub fn fix_label(&mut self, table: &Vec<(String, u16)>) -> Result<(), String>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 411 | pub fn fix_label(&mut self, table: &[(String, u16)]) -> Result<(), String>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `table.clone()` to [INFO] [stderr] | [INFO] [stderr] 419 | let label_table = table.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/instruction.rs:435:25 [INFO] [stderr] | [INFO] [stderr] 435 | / let mut add = 0; [INFO] [stderr] 436 | | if split.len()>1 { [INFO] [stderr] 437 | | add = match u8::from_str_radix(split[1], 16){ [INFO] [stderr] 438 | | Ok(a) => a, [INFO] [stderr] 439 | | Err(_) => 0, [INFO] [stderr] 440 | | }; [INFO] [stderr] 441 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 435 | let add = if split.len()>1 { match u8::from_str_radix(split[1], 16){ [INFO] [stderr] 436 | Ok(a) => a, [INFO] [stderr] 437 | Err(_) => 0, [INFO] [stderr] 438 | } } else { 0 }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instruction.rs:442:45 [INFO] [stderr] | [INFO] [stderr] 442 | OpType::Addr16(addr+add as u16) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(add)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `o @ _` pattern can be written as just `o` [INFO] [stderr] --> src/instruction.rs:445:17 [INFO] [stderr] | [INFO] [stderr] 445 | ref o@_=>o.clone(), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:247:19 [INFO] [stderr] | [INFO] [stderr] 247 | fn checksome(vec: &Vec)->u8{ [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:250:14 [INFO] [stderr] | [INFO] [stderr] 250 | sum+=*v as u64; [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(*v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:489:14 [INFO] [stderr] | [INFO] [stderr] 489 | (ref a@_, ref b@_,ref c@_) => Err(format!("Invalid operation: CJNE {:?},{:?},{:?}", a,b,c)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:278:12 [INFO] [stderr] | [INFO] [stderr] 278 | if record.data().len()>0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!record.data().is_empty()` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:489:23 [INFO] [stderr] | [INFO] [stderr] 489 | (ref a@_, ref b@_,ref c@_) => Err(format!("Invalid operation: CJNE {:?},{:?},{:?}", a,b,c)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `c @ _` pattern can be written as just `c` [INFO] [stderr] --> src/instruction.rs:489:31 [INFO] [stderr] | [INFO] [stderr] 489 | (ref a@_, ref b@_,ref c@_) => Err(format!("Invalid operation: CJNE {:?},{:?},{:?}", a,b,c)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:279:22 [INFO] [stderr] | [INFO] [stderr] 279 | for i in 0 .. record.data().len()/0x10 +1{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=record.data().len()/0x10` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:296:20 [INFO] [stderr] | [INFO] [stderr] 296 | if temp_vec.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `temp_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:494:12 [INFO] [stderr] | [INFO] [stderr] 494 | if self.ops.len() < 1{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:504:13 [INFO] [stderr] | [INFO] [stderr] 504 | ref a@_ => Err(format!("Invalid operation: CLR {:?}", a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:509:12 [INFO] [stderr] | [INFO] [stderr] 509 | if self.ops.len() < 1{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:518:13 [INFO] [stderr] | [INFO] [stderr] 518 | ref a@_ => Err(format!("Invalid operation: SETB {:?}", a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:523:12 [INFO] [stderr] | [INFO] [stderr] 523 | if self.ops.len() < 1{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:533:13 [INFO] [stderr] | [INFO] [stderr] 533 | ref a@_ => Err(format!("Invalid operation: CPL {:?}", a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:555:14 [INFO] [stderr] | [INFO] [stderr] 555 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:555:18 [INFO] [stderr] | [INFO] [stderr] 555 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:631:14 [INFO] [stderr] | [INFO] [stderr] 631 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:631:18 [INFO] [stderr] | [INFO] [stderr] 631 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:637:12 [INFO] [stderr] | [INFO] [stderr] 637 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:657:13 [INFO] [stderr] | [INFO] [stderr] 657 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:663:12 [INFO] [stderr] | [INFO] [stderr] 663 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:682:13 [INFO] [stderr] | [INFO] [stderr] 682 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:688:12 [INFO] [stderr] | [INFO] [stderr] 688 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:696:13 [INFO] [stderr] | [INFO] [stderr] 696 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:702:12 [INFO] [stderr] | [INFO] [stderr] 702 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:711:13 [INFO] [stderr] | [INFO] [stderr] 711 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:736:14 [INFO] [stderr] | [INFO] [stderr] 736 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:736:18 [INFO] [stderr] | [INFO] [stderr] 736 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:761:14 [INFO] [stderr] | [INFO] [stderr] 761 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:761:18 [INFO] [stderr] | [INFO] [stderr] 761 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:789:14 [INFO] [stderr] | [INFO] [stderr] 789 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:789:18 [INFO] [stderr] | [INFO] [stderr] 789 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:818:14 [INFO] [stderr] | [INFO] [stderr] 818 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:818:18 [INFO] [stderr] | [INFO] [stderr] 818 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:844:14 [INFO] [stderr] | [INFO] [stderr] 844 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:844:18 [INFO] [stderr] | [INFO] [stderr] 844 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:869:14 [INFO] [stderr] | [INFO] [stderr] 869 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:869:18 [INFO] [stderr] | [INFO] [stderr] 869 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:897:14 [INFO] [stderr] | [INFO] [stderr] 897 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:897:18 [INFO] [stderr] | [INFO] [stderr] 897 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:920:14 [INFO] [stderr] | [INFO] [stderr] 920 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:920:18 [INFO] [stderr] | [INFO] [stderr] 920 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:935:14 [INFO] [stderr] | [INFO] [stderr] 935 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:935:18 [INFO] [stderr] | [INFO] [stderr] 935 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/instruction.rs:941:12 [INFO] [stderr] | [INFO] [stderr] 941 | if self.ops.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/instruction.rs:949:12 [INFO] [stderr] | [INFO] [stderr] 949 | if self.ops.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:965:14 [INFO] [stderr] | [INFO] [stderr] 965 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:965:18 [INFO] [stderr] | [INFO] [stderr] 965 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:971:12 [INFO] [stderr] | [INFO] [stderr] 971 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:979:13 [INFO] [stderr] | [INFO] [stderr] 979 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:985:12 [INFO] [stderr] | [INFO] [stderr] 985 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:993:13 [INFO] [stderr] | [INFO] [stderr] 993 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:999:12 [INFO] [stderr] | [INFO] [stderr] 999 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1007:13 [INFO] [stderr] | [INFO] [stderr] 1007 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1013:12 [INFO] [stderr] | [INFO] [stderr] 1013 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1021:13 [INFO] [stderr] | [INFO] [stderr] 1021 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1027:12 [INFO] [stderr] | [INFO] [stderr] 1027 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1035:13 [INFO] [stderr] | [INFO] [stderr] 1035 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1041:12 [INFO] [stderr] | [INFO] [stderr] 1041 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1049:13 [INFO] [stderr] | [INFO] [stderr] 1049 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1055:12 [INFO] [stderr] | [INFO] [stderr] 1055 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1063:13 [INFO] [stderr] | [INFO] [stderr] 1063 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1069:12 [INFO] [stderr] | [INFO] [stderr] 1069 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1077:13 [INFO] [stderr] | [INFO] [stderr] 1077 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/instruction.rs:1083:12 [INFO] [stderr] | [INFO] [stderr] 1083 | if self.ops.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1091:12 [INFO] [stderr] | [INFO] [stderr] 1091 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1099:13 [INFO] [stderr] | [INFO] [stderr] 1099 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1105:12 [INFO] [stderr] | [INFO] [stderr] 1105 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1113:13 [INFO] [stderr] | [INFO] [stderr] 1113 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1119:12 [INFO] [stderr] | [INFO] [stderr] 1119 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1127:13 [INFO] [stderr] | [INFO] [stderr] 1127 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1133:12 [INFO] [stderr] | [INFO] [stderr] 1133 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1141:13 [INFO] [stderr] | [INFO] [stderr] 1141 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1147:12 [INFO] [stderr] | [INFO] [stderr] 1147 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1155:13 [INFO] [stderr] | [INFO] [stderr] 1155 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1161:12 [INFO] [stderr] | [INFO] [stderr] 1161 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1169:13 [INFO] [stderr] | [INFO] [stderr] 1169 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1175:12 [INFO] [stderr] | [INFO] [stderr] 1175 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1183:13 [INFO] [stderr] | [INFO] [stderr] 1183 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1189:12 [INFO] [stderr] | [INFO] [stderr] 1189 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1197:13 [INFO] [stderr] | [INFO] [stderr] 1197 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1203:12 [INFO] [stderr] | [INFO] [stderr] 1203 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1211:13 [INFO] [stderr] | [INFO] [stderr] 1211 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1217:12 [INFO] [stderr] | [INFO] [stderr] 1217 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1225:13 [INFO] [stderr] | [INFO] [stderr] 1225 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1239:14 [INFO] [stderr] | [INFO] [stderr] 1239 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:1239:18 [INFO] [stderr] | [INFO] [stderr] 1239 | (a@_,b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1253:14 [INFO] [stderr] | [INFO] [stderr] 1253 | (ref a@_,ref b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:1253:22 [INFO] [stderr] | [INFO] [stderr] 1253 | (ref a@_,ref b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1268:14 [INFO] [stderr] | [INFO] [stderr] 1268 | (ref a@_,ref b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `b @ _` pattern can be written as just `b` [INFO] [stderr] --> src/instruction.rs:1268:22 [INFO] [stderr] | [INFO] [stderr] 1268 | (ref a@_,ref b@_) => Err(format!("Invalid operation: {} {:?},{:?}",op, a,b)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1275:12 [INFO] [stderr] | [INFO] [stderr] 1275 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1291:17 [INFO] [stderr] | [INFO] [stderr] 1291 | ref a@_ => return Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/instruction.rs:1300:12 [INFO] [stderr] | [INFO] [stderr] 1300 | if self.ops.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `a @ _` pattern can be written as just `a` [INFO] [stderr] --> src/instruction.rs:1308:13 [INFO] [stderr] | [INFO] [stderr] 1308 | ref a@_ => Err(format!("Invalid operation: {} {:?}",op, a)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:1316:23 [INFO] [stderr] | [INFO] [stderr] 1316 | if op.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:1318:25 [INFO] [stderr] | [INFO] [stderr] 1318 | if op.ends_with("h") { [INFO] [stderr] | ^^^ help: try using a char instead: `'h'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:1321:13 [INFO] [stderr] | [INFO] [stderr] 1321 | / match u8::from_str_radix(&op, 16){ [INFO] [stderr] 1322 | | Ok(d) => return Ok(Data(d)), [INFO] [stderr] 1323 | | Err(_) => {}, [INFO] [stderr] 1324 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let Ok(d) = u8::from_str_radix(&op, 16) { return Ok(Data(d)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:1330:9 [INFO] [stderr] | [INFO] [stderr] 1330 | / match u8::from_str_radix(&op, 10) { [INFO] [stderr] 1331 | | Ok(a) => return Ok(Data(a)), [INFO] [stderr] 1332 | | Err(_) => {}, [INFO] [stderr] 1333 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(a) = u8::from_str_radix(&op, 10) { return Ok(Data(a)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:1339:21 [INFO] [stderr] | [INFO] [stderr] 1339 | if op.ends_with("h") { [INFO] [stderr] | ^^^ help: try using a char instead: `'h'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:1343:9 [INFO] [stderr] | [INFO] [stderr] 1343 | / match u8::from_str_radix(&temp, 16){ [INFO] [stderr] 1344 | | Ok(a) => return Ok( Addr(a)), [INFO] [stderr] 1345 | | Err(_) => {}, [INFO] [stderr] 1346 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(a) = u8::from_str_radix(&temp, 16) { return Ok( Addr(a)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:1356:9 [INFO] [stderr] | [INFO] [stderr] 1356 | / match u8::from_str_radix(&temp, 16){ [INFO] [stderr] 1357 | | Ok(a) => return Ok( Addr(a)), [INFO] [stderr] 1358 | | Err(_) => {}, [INFO] [stderr] 1359 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(a) = u8::from_str_radix(&temp, 16) { return Ok( Addr(a)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:1365:5 [INFO] [stderr] | [INFO] [stderr] 1365 | / match u8::from_str_radix(&op, 10){ [INFO] [stderr] 1366 | | Ok(a) => return Ok( Addr(a)), [INFO] [stderr] 1367 | | Err(_) => {}, [INFO] [stderr] 1368 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(a) = u8::from_str_radix(&op, 10) { return Ok( Addr(a)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:1369:5 [INFO] [stderr] | [INFO] [stderr] 1369 | / match u16::from_str_radix(&op, 10){ [INFO] [stderr] 1370 | | Ok(a) => return Ok( Addr16(a)), [INFO] [stderr] 1371 | | Err(_) => {}, [INFO] [stderr] 1372 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(a) = u16::from_str_radix(&op, 10) { return Ok( Addr16(a)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/instruction.rs:1373:5 [INFO] [stderr] | [INFO] [stderr] 1373 | / match u64::from_str_radix(&op, 10) { [INFO] [stderr] 1374 | | Ok(_) => return Err(String::from("Invalid Address")), [INFO] [stderr] 1375 | | Err(_) => {}, [INFO] [stderr] 1376 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Ok(_) = u64::from_str_radix(&op, 10) { return Err(String::from("Invalid Address")) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/hex_table.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(ins:& Vec) -> HexTable{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/hex_table.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | if inst.offset()as i32+inst.len()>max{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(inst.offset())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/hex_table.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | max = inst.offset()as i32+inst.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(inst.offset())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/hex_table.rs:23:46 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn update(&mut self, offset:u16, hex:&Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `hex` [INFO] [stderr] --> src/hex_table.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | for i in 0..(hex.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 24 | for (i, ) in hex.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match sec.fix_labels(&label_table) { [INFO] [stderr] 68 | | Err(mut e) => errors.append(&mut e), [INFO] [stderr] 69 | | _ => {}, [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(mut e) = sec.fix_labels(&label_table) { errors.append(&mut e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:102:32 [INFO] [stderr] | [INFO] [stderr] 102 | fn build_label_table(sections: &Vec) -> Vec<(String, u16)>{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[section::Section]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:247:19 [INFO] [stderr] | [INFO] [stderr] 247 | fn checksome(vec: &Vec)->u8{ [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:250:14 [INFO] [stderr] | [INFO] [stderr] 250 | sum+=*v as u64; [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(*v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:278:12 [INFO] [stderr] | [INFO] [stderr] 278 | if record.data().len()>0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!record.data().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:279:22 [INFO] [stderr] | [INFO] [stderr] 279 | for i in 0 .. record.data().len()/0x10 +1{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=record.data().len()/0x10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:296:20 [INFO] [stderr] | [INFO] [stderr] 296 | if temp_vec.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `temp_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.76s [INFO] running `"docker" "inspect" "262e73b4e4eeb8298004f8b26c6fe90cc649f68be16d0e53fbad717c7a9170cc"` [INFO] running `"docker" "rm" "-f" "262e73b4e4eeb8298004f8b26c6fe90cc649f68be16d0e53fbad717c7a9170cc"` [INFO] [stdout] 262e73b4e4eeb8298004f8b26c6fe90cc649f68be16d0e53fbad717c7a9170cc