[INFO] updating cached repository JoshuaBatty/auto_install_gstreamer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/JoshuaBatty/auto_install_gstreamer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/JoshuaBatty/auto_install_gstreamer" "work/ex/clippy-test-run/sources/stable/gh/JoshuaBatty/auto_install_gstreamer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/JoshuaBatty/auto_install_gstreamer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/JoshuaBatty/auto_install_gstreamer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshuaBatty/auto_install_gstreamer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshuaBatty/auto_install_gstreamer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7c7f29e0224b22009a7614b6f643fdcfdb48ec04 [INFO] sha for GitHub repo JoshuaBatty/auto_install_gstreamer: 7c7f29e0224b22009a7614b6f643fdcfdb48ec04 [INFO] validating manifest of JoshuaBatty/auto_install_gstreamer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of JoshuaBatty/auto_install_gstreamer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing JoshuaBatty/auto_install_gstreamer [INFO] finished frobbing JoshuaBatty/auto_install_gstreamer [INFO] frobbed toml for JoshuaBatty/auto_install_gstreamer written to work/ex/clippy-test-run/sources/stable/gh/JoshuaBatty/auto_install_gstreamer/Cargo.toml [INFO] started frobbing JoshuaBatty/auto_install_gstreamer [INFO] finished frobbing JoshuaBatty/auto_install_gstreamer [INFO] frobbed toml for JoshuaBatty/auto_install_gstreamer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshuaBatty/auto_install_gstreamer/Cargo.toml [INFO] crate JoshuaBatty/auto_install_gstreamer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting JoshuaBatty/auto_install_gstreamer against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/JoshuaBatty/auto_install_gstreamer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c2c7f9218b72e51acb06fe1f6a863e488e199c59ec220300e60f59316ee870f [INFO] running `"docker" "start" "-a" "8c2c7f9218b72e51acb06fe1f6a863e488e199c59ec220300e60f59316ee870f"` [INFO] [stderr] Checking auto_install_gstreamer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | child [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | let child = child [INFO] [stderr] | _________________^ [INFO] [stderr] 51 | | .arg("search") [INFO] [stderr] 52 | | .arg("gstreamer") [INFO] [stderr] 53 | | .stderr(Stdio::piped()) [INFO] [stderr] 54 | | .stdout(Stdio::piped()) [INFO] [stderr] 55 | | .spawn(); [INFO] [stderr] | |________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | child [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | let child = child [INFO] [stderr] | _________________^ [INFO] [stderr] 72 | | .arg("-e") [INFO] [stderr] 73 | | .arg("$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)") [INFO] [stderr] 74 | | .stderr(Stdio::piped()) [INFO] [stderr] 75 | | .stdout(Stdio::piped()) [INFO] [stderr] 76 | | .spawn(); [INFO] [stderr] | |________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | child [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | let child = child [INFO] [stderr] | _________________^ [INFO] [stderr] 84 | | .arg("-e") [INFO] [stderr] 85 | | .arg("$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/uninstall)") [INFO] [stderr] 86 | | .stderr(Stdio::piped()) [INFO] [stderr] 87 | | .stdout(Stdio::piped()) [INFO] [stderr] 88 | | .spawn(); [INFO] [stderr] | |________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | child [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | let child = child [INFO] [stderr] | _____________________^ [INFO] [stderr] 107 | | .arg("install") [INFO] [stderr] 108 | | .arg("gstreamer") [INFO] [stderr] 109 | | .arg("gst-plugins-base") [INFO] [stderr] ... | [INFO] [stderr] 122 | | .stdout(Stdio::piped()) [INFO] [stderr] 123 | | .spawn(); [INFO] [stderr] | |____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | child [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | let child = child [INFO] [stderr] | _____________________^ [INFO] [stderr] 128 | | .arg("-S") [INFO] [stderr] 129 | | .arg("pkg-config") [INFO] [stderr] 130 | | .arg("mingw-w64-x86_64-gstreamer") [INFO] [stderr] ... | [INFO] [stderr] 138 | | .stdout(Stdio::piped()) [INFO] [stderr] 139 | | .spawn(); [INFO] [stderr] | |____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | child [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | let child = child [INFO] [stderr] | _____________________^ [INFO] [stderr] 144 | | .arg("install") [INFO] [stderr] 145 | | .arg("libgstreamer1.0-dev") [INFO] [stderr] 146 | | .arg("libgstreamer-plugins-base1.0-dev") [INFO] [stderr] ... | [INFO] [stderr] 151 | | .stdout(Stdio::piped()) [INFO] [stderr] 152 | | .spawn(); [INFO] [stderr] | |____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | child [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:161:17 [INFO] [stderr] | [INFO] [stderr] 161 | let child = child [INFO] [stderr] | _________________^ [INFO] [stderr] 162 | | .arg("uninstall") [INFO] [stderr] 163 | | .arg("gstreamer") [INFO] [stderr] 164 | | .arg("gst-plugins-base") [INFO] [stderr] ... | [INFO] [stderr] 172 | | .stdout(Stdio::piped()) [INFO] [stderr] 173 | | .spawn(); [INFO] [stderr] | |________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | child [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | let child = child [INFO] [stderr] | _________________^ [INFO] [stderr] 51 | | .arg("search") [INFO] [stderr] 52 | | .arg("gstreamer") [INFO] [stderr] 53 | | .stderr(Stdio::piped()) [INFO] [stderr] 54 | | .stdout(Stdio::piped()) [INFO] [stderr] 55 | | .spawn(); [INFO] [stderr] | |________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | child [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | let child = child [INFO] [stderr] | _________________^ [INFO] [stderr] 72 | | .arg("-e") [INFO] [stderr] 73 | | .arg("$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)") [INFO] [stderr] 74 | | .stderr(Stdio::piped()) [INFO] [stderr] 75 | | .stdout(Stdio::piped()) [INFO] [stderr] 76 | | .spawn(); [INFO] [stderr] | |________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | child [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | let child = child [INFO] [stderr] | _________________^ [INFO] [stderr] 84 | | .arg("-e") [INFO] [stderr] 85 | | .arg("$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/uninstall)") [INFO] [stderr] 86 | | .stderr(Stdio::piped()) [INFO] [stderr] 87 | | .stdout(Stdio::piped()) [INFO] [stderr] 88 | | .spawn(); [INFO] [stderr] | |________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | child [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | let child = child [INFO] [stderr] | _____________________^ [INFO] [stderr] 107 | | .arg("install") [INFO] [stderr] 108 | | .arg("gstreamer") [INFO] [stderr] 109 | | .arg("gst-plugins-base") [INFO] [stderr] ... | [INFO] [stderr] 122 | | .stdout(Stdio::piped()) [INFO] [stderr] 123 | | .spawn(); [INFO] [stderr] | |____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | child [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | let child = child [INFO] [stderr] | _____________________^ [INFO] [stderr] 128 | | .arg("-S") [INFO] [stderr] 129 | | .arg("pkg-config") [INFO] [stderr] 130 | | .arg("mingw-w64-x86_64-gstreamer") [INFO] [stderr] ... | [INFO] [stderr] 138 | | .stdout(Stdio::piped()) [INFO] [stderr] 139 | | .spawn(); [INFO] [stderr] | |____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | child [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | let child = child [INFO] [stderr] | _____________________^ [INFO] [stderr] 144 | | .arg("install") [INFO] [stderr] 145 | | .arg("libgstreamer1.0-dev") [INFO] [stderr] 146 | | .arg("libgstreamer-plugins-base1.0-dev") [INFO] [stderr] ... | [INFO] [stderr] 151 | | .stdout(Stdio::piped()) [INFO] [stderr] 152 | | .spawn(); [INFO] [stderr] | |____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | child [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:161:17 [INFO] [stderr] | [INFO] [stderr] 161 | let child = child [INFO] [stderr] | _________________^ [INFO] [stderr] 162 | | .arg("uninstall") [INFO] [stderr] 163 | | .arg("gstreamer") [INFO] [stderr] 164 | | .arg("gst-plugins-base") [INFO] [stderr] ... | [INFO] [stderr] 172 | | .stdout(Stdio::piped()) [INFO] [stderr] 173 | | .spawn(); [INFO] [stderr] | |________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `uninstall` [INFO] [stderr] --> src/main.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | fn uninstall() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `uninstall_hombrew` [INFO] [stderr] --> src/main.rs:81:1 [INFO] [stderr] | [INFO] [stderr] 81 | fn uninstall_hombrew() -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `uninstall_gstreamer` [INFO] [stderr] --> src/main.rs:159:1 [INFO] [stderr] | [INFO] [stderr] 159 | fn uninstall_gstreamer() -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:181:14 [INFO] [stderr] | [INFO] [stderr] 181 | .arg("echo ".to_owned() + &string) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: function is never used: `uninstall` [INFO] [stderr] --> src/main.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | fn uninstall() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `uninstall_hombrew` [INFO] [stderr] --> src/main.rs:81:1 [INFO] [stderr] | [INFO] [stderr] 81 | fn uninstall_hombrew() -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `uninstall_gstreamer` [INFO] [stderr] --> src/main.rs:159:1 [INFO] [stderr] | [INFO] [stderr] 159 | fn uninstall_gstreamer() -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:181:14 [INFO] [stderr] | [INFO] [stderr] 181 | .arg("echo ".to_owned() + &string) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.62s [INFO] running `"docker" "inspect" "8c2c7f9218b72e51acb06fe1f6a863e488e199c59ec220300e60f59316ee870f"` [INFO] running `"docker" "rm" "-f" "8c2c7f9218b72e51acb06fe1f6a863e488e199c59ec220300e60f59316ee870f"` [INFO] [stdout] 8c2c7f9218b72e51acb06fe1f6a863e488e199c59ec220300e60f59316ee870f